diff mbox series

[v11,2/9] PCI: Remove unused __weak attribute in pci_register_io_range()

Message ID 1516537647-50553-3-git-send-email-john.garry@huawei.com
State Superseded
Headers show
Series None | expand

Commit Message

John Garry Jan. 21, 2018, 12:27 p.m. UTC
From: Gabriele Paoloni <gabriele.paoloni@huawei.com>


Currently pci_register_io_range() has only one definition;
therefore there is no use of the __weak attribute.

Signed-off-by: Gabriele Paoloni <gabriele.paoloni@huawei.com>

Acked-by: Bjorn Helgaas <bhelgaas@google.com>

---
 drivers/pci/pci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

John Garry Jan. 22, 2018, 11:59 a.m. UTC | #1
On 21/01/2018 12:27, John Garry wrote:
> From: Gabriele Paoloni <gabriele.paoloni@huawei.com>

>

> Currently pci_register_io_range() has only one definition;

> therefore there is no use of the __weak attribute.

>

> Signed-off-by: Gabriele Paoloni <gabriele.paoloni@huawei.com>

> Acked-by: Bjorn Helgaas <bhelgaas@google.com>

> ---


Hi Bjorn,

So I will need to respin this series again (and it still requires many 
more SOB tags), so do you want to pick up this minor patch in isolation 
now? It would save me carrying it, and save people receiving it in future.

Thanks,
John

>  drivers/pci/pci.c | 2 +-

>  1 file changed, 1 insertion(+), 1 deletion(-)

>

> diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c

> index 764ca7b..d8357ff 100644

> --- a/drivers/pci/pci.c

> +++ b/drivers/pci/pci.c

> @@ -3383,7 +3383,7 @@ struct io_range {

>   * Record the PCI IO range (expressed as CPU physical address + size).

>   * Return a negative value if an error has occured, zero otherwise

>   */

> -int __weak pci_register_io_range(phys_addr_t addr, resource_size_t size)

> +int pci_register_io_range(phys_addr_t addr, resource_size_t size)

>  {

>  	int err = 0;

>

>



--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox series

Patch

diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
index 764ca7b..d8357ff 100644
--- a/drivers/pci/pci.c
+++ b/drivers/pci/pci.c
@@ -3383,7 +3383,7 @@  struct io_range {
  * Record the PCI IO range (expressed as CPU physical address + size).
  * Return a negative value if an error has occured, zero otherwise
  */
-int __weak pci_register_io_range(phys_addr_t addr, resource_size_t size)
+int pci_register_io_range(phys_addr_t addr, resource_size_t size)
 {
 	int err = 0;