diff mbox series

[V4,1/5] bindings: regulator: added support for suspend states

Message ID 1516607961-379-1-git-send-email-zhang.chunyan@linaro.org
State Superseded
Headers show
Series [V4,1/5] bindings: regulator: added support for suspend states | expand

Commit Message

Chunyan Zhang Jan. 22, 2018, 7:59 a.m. UTC
Some systems need to set regulators to specific states when they enter
low power modes, especially around CPUs. There are many of these modes
depending on the particular runtime state.

Currently the regulator consumers are not granted permission to change
suspend state of regulator devices, the constraints are configured at
startup.  In order to allow changes in a vlotage range, we need to add
new properties for voltage range and a flag to give permission to
change the suspend voltage and suspend on/off in suspend mode.

Signed-off-by: Chunyan Zhang <zhang.chunyan@linaro.org>

---
 Documentation/devicetree/bindings/regulator/regulator.txt | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)

-- 
2.7.4

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Rob Herring Jan. 22, 2018, 7:50 p.m. UTC | #1
On Mon, Jan 22, 2018 at 1:59 AM, Chunyan Zhang <zhang.chunyan@linaro.org> wrote:
> Some systems need to set regulators to specific states when they enter

> low power modes, especially around CPUs. There are many of these modes

> depending on the particular runtime state.

>

> Currently the regulator consumers are not granted permission to change

> suspend state of regulator devices, the constraints are configured at

> startup.  In order to allow changes in a vlotage range, we need to add

> new properties for voltage range and a flag to give permission to

> change the suspend voltage and suspend on/off in suspend mode.

>

> Signed-off-by: Chunyan Zhang <zhang.chunyan@linaro.org>

> ---

>  Documentation/devicetree/bindings/regulator/regulator.txt | 12 ++++++++++--

>  1 file changed, 10 insertions(+), 2 deletions(-)


Reviewed-by: Rob Herring <robh@kernel.org>

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Mark Brown Jan. 23, 2018, 11:28 a.m. UTC | #2
On Mon, Jan 22, 2018 at 01:50:35PM -0600, Rob Herring wrote:
> On Mon, Jan 22, 2018 at 1:59 AM, Chunyan Zhang <zhang.chunyan@linaro.org> wrote:

> > Some systems need to set regulators to specific states when they enter

> > low power modes, especially around CPUs. There are many of these modes

> > depending on the particular runtime state.


This v4 appears to have failed to arrive in either my inbox or on my
copy of lkml, not sure what's going on there but can you resend please?
Last I have in either place is v3.
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/regulator/regulator.txt b/Documentation/devicetree/bindings/regulator/regulator.txt
index 378f6dc..e459226 100644
--- a/Documentation/devicetree/bindings/regulator/regulator.txt
+++ b/Documentation/devicetree/bindings/regulator/regulator.txt
@@ -42,8 +42,16 @@  Optional properties:
 - regulator-state-[mem/disk] node has following common properties:
 	- regulator-on-in-suspend: regulator should be on in suspend state.
 	- regulator-off-in-suspend: regulator should be off in suspend state.
-	- regulator-suspend-microvolt: regulator should be set to this voltage
-	  in suspend.
+	- regulator-suspend-min-microvolt: minimum voltage may be set in
+	  suspend state.
+	- regulator-suspend-max-microvolt: maximum voltage may be set in
+	  suspend state.
+	- regulator-suspend-microvolt: the default voltage which regulator
+	  would be set in suspend. This property is now deprecated, instead
+	  setting voltage for suspend mode via the API which regulator
+	  driver provides is recommended.
+	- regulator-changeable-in-suspend: whether the default voltage and
+	  the regulator on/off in suspend can be changed in runtime.
 	- regulator-mode: operating mode in the given suspend state.
 	  The set of possible operating modes depends on the capabilities of
 	  every hardware so the valid modes are documented on each regulator