From patchwork Tue Jan 23 20:16:53 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Maxime Ripard X-Patchwork-Id: 125572 Delivered-To: patch@linaro.org Received: by 10.46.66.141 with SMTP id h13csp1982467ljf; Tue, 23 Jan 2018 12:19:51 -0800 (PST) X-Google-Smtp-Source: AH8x225s03aCFTLkJ8SVSBFw2OGOK/wENZg7FlPea4/wr47ipNOUQ5IVy6NrDHVS9/r1ZSmYcm4H X-Received: by 10.80.187.73 with SMTP id y67mr20754920ede.172.1516738791334; Tue, 23 Jan 2018 12:19:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1516738791; cv=none; d=google.com; s=arc-20160816; b=a0wlKKMiV86uxcPCL8bmwtwBJ6AhZ752oQ9cxslTs4MsLEE0/lXPmB18kEtx1WGWu/ asoJBPytGQ4BymIynFxs+R3R3TUpFNWxXpZwout6yZUnKQFg4+aXi29ILfN4bcQ7yIz5 8PdNAo8Ivwg4d37NA7YfmVnuMWBzLExevkzwgRc9WkbeViPH+E4q2bnKni1L9ShcM4U0 uSHaC/pWD4br0EPiSFPaZCy/XWMhXTLAbNwvG9yZsvS94qYL/CGl2SaNFAGWQPCAEB1r j0j4GK9IgmmNTgTR7b1HdxXDPbIp94nDPJJ7bmOfHO1r7K2FqchIEtlPM9n2i0qojg1u zERg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:cc:references:in-reply-to:references :in-reply-to:message-id:date:to:from:arc-authentication-results; bh=kXcr5n1LiW9AvT3hRujCxexv7sN1a/pKsvVqfZ88TQQ=; b=M2hqTumelegGx7SFJZMBql67/dwo3yjLprDmcZRqu0em8ziMKVy9xTy8ixtjWlK+tk 5P+42B8bwtmunY0qop1ctgazgGp9UDMVw1okdGzKNBcK0BS0wm5s6U3FFn6Ld8rME8T5 M1lJv+gWsnVtxV+YWixYd6A4RqnyaNwfVwa8m1wsq7pnEJVfrN51EZFTzpi0y1NiHQTT HTngBqP6+ROP/0c1ZlwwqlghZ5P0zzsJsdRCOj2GN5GAoX7gCM/5Tmj59RNmCZvCpUkt a3CzCBMttywWBATCuZK5+jxq/gBi6kuA3HDb3idYkiXcsMBOhQu+wifIzAhhqZZopZ7/ GZWw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of u-boot-bounces@lists.denx.de designates 81.169.180.215 as permitted sender) smtp.mailfrom=u-boot-bounces@lists.denx.de Return-Path: Received: from lists.denx.de (dione.denx.de. [81.169.180.215]) by mx.google.com with ESMTP id 34si4316902edj.250.2018.01.23.12.19.50; Tue, 23 Jan 2018 12:19:51 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of u-boot-bounces@lists.denx.de designates 81.169.180.215 as permitted sender) client-ip=81.169.180.215; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of u-boot-bounces@lists.denx.de designates 81.169.180.215 as permitted sender) smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by lists.denx.de (Postfix, from userid 105) id AAA6FC220DC; Tue, 23 Jan 2018 20:18:31 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id EAFB0C220DC; Tue, 23 Jan 2018 20:17:15 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id DE36FC21EDE; Tue, 23 Jan 2018 20:17:09 +0000 (UTC) Received: from mail.free-electrons.com (mail.free-electrons.com [62.4.15.54]) by lists.denx.de (Postfix) with ESMTP id 36A59C21DA6 for ; Tue, 23 Jan 2018 20:17:09 +0000 (UTC) Received: by mail.free-electrons.com (Postfix, from userid 110) id 142C520C53; Tue, 23 Jan 2018 21:17:09 +0100 (CET) Received: from localhost (LFbn-1-2035-97.w90-76.abo.wanadoo.fr [90.76.104.97]) by mail.free-electrons.com (Postfix) with ESMTPSA id CB850207A8; Tue, 23 Jan 2018 21:17:08 +0100 (CET) From: Maxime Ripard To: Tom Rini Date: Tue, 23 Jan 2018 21:16:53 +0100 Message-Id: X-Mailer: git-send-email 2.14.3 In-Reply-To: References: In-Reply-To: References: Cc: Andre Przywara , agraf@suse.de, u-boot@lists.denx.de, Maxime Ripard , Jagan Teki Subject: [U-Boot] [PATCH v3 04/15] env: Make the env save message a bit more explicit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" Since we'll soon have support for multiple environments, the environment saving message might end up being printed multiple times if the higher priority environment cannot be used. That might confuse the user, so let's make it explicit if the operation failed or not. Reviewed-by: Andre Przywara Reviewed-by: Lukasz Majewski Reviewed-by: Simon Glass Signed-off-by: Maxime Ripard --- env/env.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/env/env.c b/env/env.c index 73da149fd8ca..11667a3cbc71 100644 --- a/env/env.c +++ b/env/env.c @@ -166,8 +166,9 @@ int env_save(void) if (!drv->save) continue; - printf("Saving Environment to %s...\n", drv->name); + printf("Saving Environment to %s... ", drv->name); ret = drv->save(); + printf("%s\n", ret ? "Failed" : "OK"); if (!ret) return 0;