[v3,11/15] env: mmc: depends on the MMC framework

Message ID 2700368ef3020748126407597a416a3943eae6ba.1516723179.git-series.maxime.ripard@free-electrons.com
State Accepted
Commit d282a1db6aead313649ad7be6d3ff0fb68fca4ef
Headers show
Series
  • env: Multiple env support and env transition for sunxi
Related show

Commit Message

Maxime Ripard Jan. 23, 2018, 8:17 p.m.
The raw MMC environment directly calls into the MMC framework. Make sure
it's enabled before we can select it.

Reviewed-by: Simon Glass <sjg@chromium.org>
Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
---
 env/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Jaehoon Chung Jan. 24, 2018, 1:51 p.m. | #1
On 2018년 01월 24일 05:17, Maxime Ripard wrote:
> The raw MMC environment directly calls into the MMC framework. Make sure
> it's enabled before we can select it.
> 
> Reviewed-by: Simon Glass <sjg@chromium.org>
> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>

Reviewed-by: Jaehoon Chung <jh80.chung@samsung.com>

> ---
>  env/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/env/Kconfig b/env/Kconfig
> index bef6e89bfc3c..ad5ccc253762 100644
> --- a/env/Kconfig
> +++ b/env/Kconfig
> @@ -156,6 +156,7 @@ config ENV_IS_IN_FLASH
>  config ENV_IS_IN_MMC
>  	bool "Environment in an MMC device"
>  	depends on !CHAIN_OF_TRUST
> +	depends on MMC
>  	help
>  	  Define this if you have an MMC device which you want to use for the
>  	  environment.
>
Tom Rini Jan. 27, 2018, 7:21 p.m. | #2
On Tue, Jan 23, 2018 at 09:17:00PM +0100, Maxime Ripard wrote:

> The raw MMC environment directly calls into the MMC framework. Make sure

> it's enabled before we can select it.

> 

> Reviewed-by: Simon Glass <sjg@chromium.org>

> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>

> Reviewed-by: Jaehoon Chung <jh80.chung@samsung.com>


Applied to u-boot/master, thanks!

-- 
Tom

Patch

diff --git a/env/Kconfig b/env/Kconfig
index bef6e89bfc3c..ad5ccc253762 100644
--- a/env/Kconfig
+++ b/env/Kconfig
@@ -156,6 +156,7 @@  config ENV_IS_IN_FLASH
 config ENV_IS_IN_MMC
 	bool "Environment in an MMC device"
 	depends on !CHAIN_OF_TRUST
+	depends on MMC
 	help
 	  Define this if you have an MMC device which you want to use for the
 	  environment.