| Message ID | 20180125110556.76352-7-agraf@suse.de |
|---|---|
| State | Accepted |
| Commit | bceab8d569953dc21d263dc20b2d4c0c37f8b28c |
| Headers | show |
| Series | RPi: Properly handle dynamic serial configuration | expand |
On Thu, Jan 25, 2018 at 12:05:47PM +0100, Alexander Graf wrote: > The serial initialization doesn't always quite work for me, so let's > always skip it for now. We know that firmware on the RPi initializes > us properly already. > > Signed-off-by: Alexander Graf <agraf@suse.de> Applied to u-boot/master, thanks! -- Tom
diff --git a/drivers/serial/serial_bcm283x_mu.c b/drivers/serial/serial_bcm283x_mu.c index 20dc3defcc..c6132b4463 100644 --- a/drivers/serial/serial_bcm283x_mu.c +++ b/drivers/serial/serial_bcm283x_mu.c @@ -147,7 +147,12 @@ static int bcm283x_mu_serial_ofdata_to_platdata(struct udevice *dev) plat->base = addr; plat->clock = dev_read_u32_default(dev, "clock", 1); - plat->skip_init = dev_read_bool(dev, "skip-init"); + + /* + * TODO: Reinitialization doesn't always work for now, just skip + * init always - we know we're already initialized + */ + plat->skip_init = true; return 0; }
The serial initialization doesn't always quite work for me, so let's always skip it for now. We know that firmware on the RPi initializes us properly already. Signed-off-by: Alexander Graf <agraf@suse.de> --- drivers/serial/serial_bcm283x_mu.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)