[edk2] BeagleBoardPkg: reroute Firmware Vendor Pcd to MdeModulePkg

Message ID 20180126173006.17324-1-leif.lindholm@linaro.org
State New
Headers show
Series
  • [edk2] BeagleBoardPkg: reroute Firmware Vendor Pcd to MdeModulePkg
Related show

Commit Message

Leif Lindholm Jan. 26, 2018, 5:30 p.m.
Commit f9669f09fb53 ("ArmPlatformPkg: retire obsolete PCDs") got rid of
the unfortunate ARM-specific variant of PcdFirmwareVendor.

However, BeagleBoard was still using it, so the change broke the build.
Fix this by moving BeagleBoard to use the MdeModulePkg one instead.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>

---
 BeagleBoardPkg/BeagleBoardPkg.dsc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.11.0

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Comments

Ard Biesheuvel Jan. 26, 2018, 5:31 p.m. | #1
On 26 January 2018 at 17:30, Leif Lindholm <leif.lindholm@linaro.org> wrote:
> Commit f9669f09fb53 ("ArmPlatformPkg: retire obsolete PCDs") got rid of

> the unfortunate ARM-specific variant of PcdFirmwareVendor.

>

> However, BeagleBoard was still using it, so the change broke the build.

> Fix this by moving BeagleBoard to use the MdeModulePkg one instead.

>

> Contributed-under: TianoCore Contribution Agreement 1.1

> Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>

> ---

>  BeagleBoardPkg/BeagleBoardPkg.dsc | 2 +-

>  1 file changed, 1 insertion(+), 1 deletion(-)

>

> diff --git a/BeagleBoardPkg/BeagleBoardPkg.dsc b/BeagleBoardPkg/BeagleBoardPkg.dsc

> index 5d87ee3891..cef2e095d4 100644

> --- a/BeagleBoardPkg/BeagleBoardPkg.dsc

> +++ b/BeagleBoardPkg/BeagleBoardPkg.dsc

> @@ -262,7 +262,7 @@ [PcdsFeatureFlag.common]

>    gEfiMdeModulePkgTokenSpaceGuid.PcdConOutGopSupport|TRUE

>

>  [PcdsFixedAtBuild.common]

> -  gArmPlatformTokenSpaceGuid.PcdFirmwareVendor|"Beagle Board"

> +  gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVendor|"Beagle Board"


That should probably be L"Beagle Board"


>

>    gEfiMdePkgTokenSpaceGuid.PcdMaximumUnicodeStringLength|1000000

>    gEfiMdePkgTokenSpaceGuid.PcdMaximumAsciiStringLength|1000000

> --

> 2.11.0

>

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Leif Lindholm Jan. 26, 2018, 5:34 p.m. | #2
On Fri, Jan 26, 2018 at 05:31:25PM +0000, Ard Biesheuvel wrote:
> On 26 January 2018 at 17:30, Leif Lindholm <leif.lindholm@linaro.org> wrote:

> > Commit f9669f09fb53 ("ArmPlatformPkg: retire obsolete PCDs") got rid of

> > the unfortunate ARM-specific variant of PcdFirmwareVendor.

> >

> > However, BeagleBoard was still using it, so the change broke the build.

> > Fix this by moving BeagleBoard to use the MdeModulePkg one instead.

> >

> > Contributed-under: TianoCore Contribution Agreement 1.1

> > Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>

> > ---

> >  BeagleBoardPkg/BeagleBoardPkg.dsc | 2 +-

> >  1 file changed, 1 insertion(+), 1 deletion(-)

> >

> > diff --git a/BeagleBoardPkg/BeagleBoardPkg.dsc b/BeagleBoardPkg/BeagleBoardPkg.dsc

> > index 5d87ee3891..cef2e095d4 100644

> > --- a/BeagleBoardPkg/BeagleBoardPkg.dsc

> > +++ b/BeagleBoardPkg/BeagleBoardPkg.dsc

> > @@ -262,7 +262,7 @@ [PcdsFeatureFlag.common]

> >    gEfiMdeModulePkgTokenSpaceGuid.PcdConOutGopSupport|TRUE

> >

> >  [PcdsFixedAtBuild.common]

> > -  gArmPlatformTokenSpaceGuid.PcdFirmwareVendor|"Beagle Board"

> > +  gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVendor|"Beagle Board"

> 

> That should probably be L"Beagle Board"


Good point.
Happy with me folding that in?

> 

> >

> >    gEfiMdePkgTokenSpaceGuid.PcdMaximumUnicodeStringLength|1000000

> >    gEfiMdePkgTokenSpaceGuid.PcdMaximumAsciiStringLength|1000000

> > --

> > 2.11.0

> >

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Ard Biesheuvel Jan. 26, 2018, 5:35 p.m. | #3
On 26 January 2018 at 17:34, Leif Lindholm <leif.lindholm@linaro.org> wrote:
> On Fri, Jan 26, 2018 at 05:31:25PM +0000, Ard Biesheuvel wrote:

>> On 26 January 2018 at 17:30, Leif Lindholm <leif.lindholm@linaro.org> wrote:

>> > Commit f9669f09fb53 ("ArmPlatformPkg: retire obsolete PCDs") got rid of

>> > the unfortunate ARM-specific variant of PcdFirmwareVendor.

>> >

>> > However, BeagleBoard was still using it, so the change broke the build.

>> > Fix this by moving BeagleBoard to use the MdeModulePkg one instead.

>> >

>> > Contributed-under: TianoCore Contribution Agreement 1.1

>> > Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>

>> > ---

>> >  BeagleBoardPkg/BeagleBoardPkg.dsc | 2 +-

>> >  1 file changed, 1 insertion(+), 1 deletion(-)

>> >

>> > diff --git a/BeagleBoardPkg/BeagleBoardPkg.dsc b/BeagleBoardPkg/BeagleBoardPkg.dsc

>> > index 5d87ee3891..cef2e095d4 100644

>> > --- a/BeagleBoardPkg/BeagleBoardPkg.dsc

>> > +++ b/BeagleBoardPkg/BeagleBoardPkg.dsc

>> > @@ -262,7 +262,7 @@ [PcdsFeatureFlag.common]

>> >    gEfiMdeModulePkgTokenSpaceGuid.PcdConOutGopSupport|TRUE

>> >

>> >  [PcdsFixedAtBuild.common]

>> > -  gArmPlatformTokenSpaceGuid.PcdFirmwareVendor|"Beagle Board"

>> > +  gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVendor|"Beagle Board"

>>

>> That should probably be L"Beagle Board"

>

> Good point.

> Happy with me folding that in?

>


Sure

Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Leif Lindholm Jan. 26, 2018, 5:38 p.m. | #4
On Fri, Jan 26, 2018 at 05:35:38PM +0000, Ard Biesheuvel wrote:
> >> > --- a/BeagleBoardPkg/BeagleBoardPkg.dsc

> >> > +++ b/BeagleBoardPkg/BeagleBoardPkg.dsc

> >> > @@ -262,7 +262,7 @@ [PcdsFeatureFlag.common]

> >> >    gEfiMdeModulePkgTokenSpaceGuid.PcdConOutGopSupport|TRUE

> >> >

> >> >  [PcdsFixedAtBuild.common]

> >> > -  gArmPlatformTokenSpaceGuid.PcdFirmwareVendor|"Beagle Board"

> >> > +  gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVendor|"Beagle Board"

> >>

> >> That should probably be L"Beagle Board"

> >

> > Good point.

> > Happy with me folding that in?

> 

> Sure

> 

> Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>


Thanks - pushed as 06c1f423e1.
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Patch

diff --git a/BeagleBoardPkg/BeagleBoardPkg.dsc b/BeagleBoardPkg/BeagleBoardPkg.dsc
index 5d87ee3891..cef2e095d4 100644
--- a/BeagleBoardPkg/BeagleBoardPkg.dsc
+++ b/BeagleBoardPkg/BeagleBoardPkg.dsc
@@ -262,7 +262,7 @@  [PcdsFeatureFlag.common]
   gEfiMdeModulePkgTokenSpaceGuid.PcdConOutGopSupport|TRUE
 
 [PcdsFixedAtBuild.common]
-  gArmPlatformTokenSpaceGuid.PcdFirmwareVendor|"Beagle Board"
+  gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVendor|"Beagle Board"
 
   gEfiMdePkgTokenSpaceGuid.PcdMaximumUnicodeStringLength|1000000
   gEfiMdePkgTokenSpaceGuid.PcdMaximumAsciiStringLength|1000000