[oe,meta-networking,1/2] net-snmp: Fix compiler options with paths in net-snmp-config

Message ID 20180201014414.12948-1-raj.khem@gmail.com
State Accepted
Commit d751b85efe65a4b504c41dae7e8689680843d677
Headers show
Series
  • [oe,meta-networking,1/2] net-snmp: Fix compiler options with paths in net-snmp-config
Related show

Commit Message

Khem Raj Feb. 1, 2018, 1:44 a.m.
options which involve paths into workspace are usually filtered out
with the sed command, however currently it does half the job and the
resulting config file gets partial replacements leaving the compiler
options with bad syntax e.g.

-fdebug-prefix-map option is left with -fdebug-prefix-map=
which is not correct syntax, the effect of this is seen in other
recipes which then invoke net-snmp-config script and add the
flags obtained from this script into its own configure scripts
and then tries to execute tests, these tests fail because of
bad compiler options e.g. keepalived where configure tests fails like

| configure: error: *** incorrect CFLAGS from net-snmp-config

this is because of wrong compiler options that it got from
recipe-sysroot/usr/bin/crossscripts/net-snmp-config

This patch tries to be specific about which options should
be skimmed and removes the options completely

Signed-off-by: Khem Raj <raj.khem@gmail.com>

---
 meta-networking/recipes-protocols/net-snmp/net-snmp_5.7.3.bb | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

-- 
2.16.1

-- 
_______________________________________________
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Patch

diff --git a/meta-networking/recipes-protocols/net-snmp/net-snmp_5.7.3.bb b/meta-networking/recipes-protocols/net-snmp/net-snmp_5.7.3.bb
index 29cd6b3bf..584593b17 100644
--- a/meta-networking/recipes-protocols/net-snmp/net-snmp_5.7.3.bb
+++ b/meta-networking/recipes-protocols/net-snmp/net-snmp_5.7.3.bb
@@ -118,10 +118,10 @@  do_install_append() {
     sed    -e "s@^NSC_SRCDIR=.*@NSC_SRCDIR=.@g" \
         -i ${D}${bindir}/net-snmp-create-v3-user
     sed    -e "s@^NSC_SRCDIR=.*@NSC_SRCDIR=.@g" \
-           -e "s@${STAGING_DIR_NATIVE}[=]*@@g" \
-           -e "s@${STAGING_DIR_HOST}[=]*@@g" \
-           -e "s@${WORKDIR}[=]*@@g" \
-           -e "s@${D}@@g" \
+           -e "s@\([^ ]*-fdebug-prefix-map=[^ ]*\)\1*@@g" \
+           -e "s@\([^ ]*--sysroot=[^ ]*\)\1*@@g" \
+           -e "s@\([^ ]*--with-libtool-sysroot=[^ ]*\)\1*@@g" \
+           -e "s@\([^ ]*--with-install-prefix=[^ ]*\)\1*@@g" \
         -i ${D}${bindir}/net-snmp-config
 
     if [ "${HAS_PERL}" = "1" ]; then