cramfs: better MTD dependency expression

Message ID nycvar.YSQ.7.76.1802072149330.7021@knanqh.ubzr
State Accepted
Commit a8c6db00bff2bdb466d80b7ec7ff25d327071f9b
Headers show
Series
  • cramfs: better MTD dependency expression
Related show

Commit Message

Nicolas Pitre Feb. 8, 2018, 3:08 a.m.
Commit b9f5fb1800d8 ("cramfs: fix MTD dependency") did what it says.
Since commit 9059a3493efe ("kconfig: fix relational operators for bool
and tristate symbols") it is possible to do it slightly better though.

Signed-off-by: Nicolas Pitre <nico@linaro.org>

---

Linus,

Viro once told me that my cramfs pull requests could go either to him or 
to you. I have only this one patch at the moment, and since it depends 
on a commit that recently appeared in your tree I'm therefore sending it 
directly to you.

Comments

Linus Torvalds Feb. 8, 2018, 7:38 p.m. | #1
On Wed, Feb 7, 2018 at 7:08 PM, Nicolas Pitre <nicolas.pitre@linaro.org> wrote:
>

> Viro once told me that my cramfs pull requests could go either to him or

> to you. I have only this one patch at the moment, and since it depends

> on a commit that recently appeared in your tree I'm therefore sending it

> directly to you.


Applied.

Although I'm not entirely convinced that the simpler dependency is
easier to _read_ and understand.

It is clearly simpler, though.

            Linus
Randy Dunlap Feb. 8, 2018, 8:01 p.m. | #2
On 02/08/2018 11:38 AM, Linus Torvalds wrote:
> On Wed, Feb 7, 2018 at 7:08 PM, Nicolas Pitre <nicolas.pitre@linaro.org> wrote:

>>

>> Viro once told me that my cramfs pull requests could go either to him or

>> to you. I have only this one patch at the moment, and since it depends

>> on a commit that recently appeared in your tree I'm therefore sending it

>> directly to you.

> 

> Applied.

> 

> Although I'm not entirely convinced that the simpler dependency is

> easier to _read_ and understand.

> 

> It is clearly simpler, though.

> 

>             Linus

> 



There was some pushback on the patch, mostly from Arnd.

I think we agree that it's not easier to read/understand, but Nicolas
is the maintainer... and he patched kconfig so that this would work.
kconfig did need fixing in that respect -- it was supposed to work
but didn't.

(That was commit 9059a3493efea6492451430c7e2fa0af799a2abb:
kconfig: fix relational operators for bool and tristate symbols)

-- 
~Randy
Nicolas Pitre Feb. 8, 2018, 8:10 p.m. | #3
On Thu, 8 Feb 2018, Linus Torvalds wrote:

> On Wed, Feb 7, 2018 at 7:08 PM, Nicolas Pitre <nicolas.pitre@linaro.org> wrote:

> >

> > Viro once told me that my cramfs pull requests could go either to him or

> > to you. I have only this one patch at the moment, and since it depends

> > on a commit that recently appeared in your tree I'm therefore sending it

> > directly to you.

> 

> Applied.


Thanks.

> Although I'm not entirely convinced that the simpler dependency is

> easier to _read_ and understand.

> 

> It is clearly simpler, though.


Probably depends on the mental representation you make of it. If you 
consider driver A depending on driver B then having A <= B in terms of 
build level dependency is pretty natural. Maybe it is just me but the 
alternative always gave me pause.


Nicolas

Patch

diff --git a/fs/cramfs/Kconfig b/fs/cramfs/Kconfig
index 58e2fe40b2..5933f99530 100644
--- a/fs/cramfs/Kconfig
+++ b/fs/cramfs/Kconfig
@@ -33,8 +33,7 @@  config CRAMFS_BLOCKDEV
 
 config CRAMFS_MTD
 	bool "Support CramFs image directly mapped in physical memory"
-	depends on CRAMFS && MTD
-	depends on CRAMFS=m || MTD=y
+	depends on CRAMFS && CRAMFS <= MTD
 	default y if !CRAMFS_BLOCKDEV
 	help
 	  This option allows the CramFs driver to load data directly from