From patchwork Thu Feb 8 10:21:01 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jyri Sarha X-Patchwork-Id: 127281 Delivered-To: patch@linaro.org Received: by 10.46.124.24 with SMTP id x24csp1339430ljc; Thu, 8 Feb 2018 02:21:19 -0800 (PST) X-Google-Smtp-Source: AH8x2263PaAnG30qLpqbKnzgxGcmG1RNb3qGmcZvrh7FISFyWrpVMwQTTxMoL8PY8zsQO35uDK3h X-Received: by 10.101.78.201 with SMTP id w9mr135679pgq.43.1518085279016; Thu, 08 Feb 2018 02:21:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1518085279; cv=none; d=google.com; s=arc-20160816; b=Lu3pH42a7k+i4hndJw8ijoEphKBfzNdZSvNZqM/paP6gqdlx3Zmf8H/hRjYQndGaBw pg3jqjWFQhSTgwlclk7dIk7JdLx/+kRJG+mQs7HVty3bydHp9Kid6W+oFmfFcbs5WAOe 38thjCb78Yu0knm/Fh+SooSz1JHPAGR8y5VBkrcWmFV0qZQy8z/sbzcs+83StDU3OZzB vYD3BnwwybGQka3+bQoJPqT8kuKKfCg7bnuddNrs+PAzv/fVfzw9no1i/3gVETP0v6Wy 4ucM4D8qtPt+HqwXkdSlwgHt1dGv+Ic2yo1JX8fbySqKktscN2OkpTcIrXPiUc9N/naZ T+QQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to :arc-authentication-results; bh=Wwh6k+c32m3rR/4sg2iPWAdvJEfHbLiCkRTGvaP3nGI=; b=l5uAgBHMzC0u3XETo7RchIz64yW4mW2Z8s8W2Jd9AqWBtwTO0ahNnZ++1owaTGIu6Q tho1yxkcxBXmHuY/75iEDXitVdxz5GtzsB7qnxO2WRor//NX8qxN6fArFIvaxVAzAj0Q QbVah7HfVeMflTWRLtq7EbVLhkSYQbd73jddLIIRQFRZFZs6fzZYdD8gK95vTlcv+SJ7 /8KcOiJFwDLtrsGdHGjrKGKfzL9fcTCCv/LyKCx8KnSkEyeOHd+D8D0c77HQmwSGDi8W wD2yCR3Cj8ysenopiFe+Zy2s8VlhGGTb4G7vLnO9TDvRyWxNwIaTsKc7jQQjulZeeGwo xBuQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@ti.com header.s=ti-com-17Q1 header.b=QIaWJ1So; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [131.252.210.177]) by mx.google.com with ESMTPS id u17-v6si1217013plj.646.2018.02.08.02.21.18 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 08 Feb 2018 02:21:19 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) client-ip=131.252.210.177; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@ti.com header.s=ti-com-17Q1 header.b=QIaWJ1So; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id DF8AC6E5BF; Thu, 8 Feb 2018 10:21:17 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from lelnx193.ext.ti.com (lelnx193.ext.ti.com [198.47.27.77]) by gabe.freedesktop.org (Postfix) with ESMTPS id 44F2A6E5BB for ; Thu, 8 Feb 2018 10:21:15 +0000 (UTC) Received: from dlelxv90.itg.ti.com ([172.17.2.17]) by lelnx193.ext.ti.com (8.15.1/8.15.1) with ESMTP id w18ALCS8023324; Thu, 8 Feb 2018 04:21:12 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ti.com; s=ti-com-17Q1; t=1518085272; bh=jD+6s7cUjInvSzdv0uGXHWSs1lBXiopZUy/lidUoRic=; h=From:To:CC:Subject:Date:In-Reply-To:References; b=QIaWJ1SoYtlQHhxXEOZbjsl9gahJ+Ygw7DP4NjBa2klLSk8rWwtaKYZEj+1DbJWFn m+0I0CnQHXr+XHHGFiMGm/khJ0dZw3FpaK9mD0uMkio+57c9lYSWY0kIxZRKC+5+Cv 8M36xq1BnwFxYOmLksfpvopIWzynQxLthE+0W1lE= Received: from DFLE106.ent.ti.com (dfle106.ent.ti.com [10.64.6.27]) by dlelxv90.itg.ti.com (8.14.3/8.13.8) with ESMTP id w18ALCTg015827; Thu, 8 Feb 2018 04:21:12 -0600 Received: from DFLE113.ent.ti.com (10.64.6.34) by DFLE106.ent.ti.com (10.64.6.27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1261.35; Thu, 8 Feb 2018 04:21:12 -0600 Received: from dlep32.itg.ti.com (157.170.170.100) by DFLE113.ent.ti.com (10.64.6.34) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.1261.35 via Frontend Transport; Thu, 8 Feb 2018 04:21:12 -0600 Received: from jadmar.ti.com (ileax41-snat.itg.ti.com [10.172.224.153]) by dlep32.itg.ti.com (8.14.3/8.13.8) with ESMTP id w18AL9Bv012092; Thu, 8 Feb 2018 04:21:11 -0600 From: Jyri Sarha To: Subject: [PATCH v4 1/6] drm/omap: Fail probe if irq registration fails Date: Thu, 8 Feb 2018 12:21:01 +0200 Message-ID: <802e7cedf8a697deeef3f143cc1068520b35f2f6.1518084092.git.jsarha@ti.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: References: MIME-Version: 1.0 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: tomi.valkeinen@ti.com, laurent.pinchart@ideasonboard.com, Jyri Sarha Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Call to omap_drm_irq_install() may fail with an error code. In such a case the driver probe should fail. Signed-off-by: Jyri Sarha --- drivers/gpu/drm/omapdrm/omap_drv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/omapdrm/omap_drv.c b/drivers/gpu/drm/omapdrm/omap_drv.c index 71ea43f..e6e7a2c 100644 --- a/drivers/gpu/drm/omapdrm/omap_drv.c +++ b/drivers/gpu/drm/omapdrm/omap_drv.c @@ -329,9 +329,9 @@ static int omap_modeset_init(struct drm_device *dev) drm_mode_config_reset(dev); - omap_drm_irq_install(dev); + ret = omap_drm_irq_install(dev); - return 0; + return ret; } /*