From patchwork Thu Nov 8 10:08:43 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sachin Kamat X-Patchwork-Id: 12765 Return-Path: X-Original-To: patchwork@peony.canonical.com Delivered-To: patchwork@peony.canonical.com Received: from fiordland.canonical.com (fiordland.canonical.com [91.189.94.145]) by peony.canonical.com (Postfix) with ESMTP id 157C823E0B for ; Thu, 8 Nov 2012 10:14:27 +0000 (UTC) Received: from mail-ia0-f180.google.com (mail-ia0-f180.google.com [209.85.210.180]) by fiordland.canonical.com (Postfix) with ESMTP id A054CA18564 for ; Thu, 8 Nov 2012 10:14:26 +0000 (UTC) Received: by mail-ia0-f180.google.com with SMTP id f6so1742836iag.11 for ; Thu, 08 Nov 2012 02:14:26 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-forwarded-to:x-forwarded-for:delivered-to:received-spf:from:to:cc :subject:date:message-id:x-mailer:x-gm-message-state; bh=j8sle9G+s1vzHcPPeZcKLJoKqJ0k6UgPIpbB9uE4CLU=; b=XhnR76/Ip98GvZQ9WKODbAyhR+aNH3qsa0KP0xE1TIJp5fo43nw9mvqMRN+2gB3wp5 SL97xV2TLTKmGanhdg8BfTH2lOq/RdQ5nHxqvmFS4Z4+XLzfwqAxjzKS1jkqWtAAxC1Z dvFop8tv5P53gZgnb1b73KYUdoKxNpowl1NXTPuSRNW8/PU6sOhK7SjKP6loWMoXUetZ A/ut2zFoGjomQo4qw61/HXi01qmrYVIzDrvXw9oBI/m+XW+RegN7+xXyXLlo/s3CQWxh r37eRVEQLY8UD+RPk4ju6GNvQ7p0mLVf8/w0ilYPVk9YiJS4PgmgsMP+oiOVMJjptZZD GBKw== Received: by 10.50.140.97 with SMTP id rf1mr19261301igb.70.1352369665957; Thu, 08 Nov 2012 02:14:25 -0800 (PST) X-Forwarded-To: linaro-patchwork@canonical.com X-Forwarded-For: patch@linaro.org linaro-patchwork@canonical.com Delivered-To: patches@linaro.org Received: by 10.50.67.148 with SMTP id n20csp347543igt; Thu, 8 Nov 2012 02:14:25 -0800 (PST) Received: by 10.68.135.101 with SMTP id pr5mr22320322pbb.140.1352369664886; Thu, 08 Nov 2012 02:14:24 -0800 (PST) Received: from mail-pa0-f46.google.com (mail-pa0-f46.google.com [209.85.220.46]) by mx.google.com with ESMTPS id e6si34649105paw.201.2012.11.08.02.14.24 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 08 Nov 2012 02:14:24 -0800 (PST) Received-SPF: neutral (google.com: 209.85.220.46 is neither permitted nor denied by best guess record for domain of sachin.kamat@linaro.org) client-ip=209.85.220.46; Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.220.46 is neither permitted nor denied by best guess record for domain of sachin.kamat@linaro.org) smtp.mail=sachin.kamat@linaro.org Received: by mail-pa0-f46.google.com with SMTP id hz1so1880866pad.19 for ; Thu, 08 Nov 2012 02:14:24 -0800 (PST) Received: by 10.68.232.201 with SMTP id tq9mr22578741pbc.12.1352369664563; Thu, 08 Nov 2012 02:14:24 -0800 (PST) Received: from localhost.localdomain ([115.113.119.130]) by mx.google.com with ESMTPS id m8sm15896110pax.38.2012.11.08.02.14.20 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 08 Nov 2012 02:14:22 -0800 (PST) From: Sachin Kamat To: linux-mtd@lists.infradead.org Cc: dwmw2@infradead.org, dedekind1@gmail.com, sachin.kamat@linaro.org, patches@linaro.org Subject: [PATCH 1/2] mtd: s3c2410: Change return type of s3c2410_nand_add_partition function Date: Thu, 8 Nov 2012 15:38:43 +0530 Message-Id: <1352369324-25771-1-git-send-email-sachin.kamat@linaro.org> X-Mailer: git-send-email 1.7.4.1 X-Gm-Message-State: ALoCoQngIqMB+lrzpG2ySYgtIuewhyDxvSZv08uOx8dUd36fTw907fU4jTGAiyqUhg4VvHUL2WJM The return value of s3c2410_nand_add_partition() is not checked for error or success in the calling function. Hence change the return type to void. Signed-off-by: Sachin Kamat --- drivers/mtd/nand/s3c2410.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/mtd/nand/s3c2410.c b/drivers/mtd/nand/s3c2410.c index 295e4be..dfb8636 100644 --- a/drivers/mtd/nand/s3c2410.c +++ b/drivers/mtd/nand/s3c2410.c @@ -726,15 +726,15 @@ static int s3c24xx_nand_remove(struct platform_device *pdev) return 0; } -static int s3c2410_nand_add_partition(struct s3c2410_nand_info *info, +static void s3c2410_nand_add_partition(struct s3c2410_nand_info *info, struct s3c2410_nand_mtd *mtd, struct s3c2410_nand_set *set) { if (set) mtd->mtd.name = set->name; - return mtd_device_parse_register(&mtd->mtd, NULL, NULL, - set->partitions, set->nr_partitions); + mtd_device_parse_register(&mtd->mtd, NULL, NULL, + set->partitions, set->nr_partitions); } /**