From patchwork Thu Feb 8 17:31:54 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 127719 Delivered-To: patch@linaro.org Received: by 10.46.124.24 with SMTP id x24csp1751162ljc; Thu, 8 Feb 2018 10:29:55 -0800 (PST) X-Google-Smtp-Source: AH8x225N7O0dMpt5NAWQ7U1mtAVo1fDAQzqmaHIhA2jrgw83oeVrzQNYIxJfkHiPtILZJxCuA8i3 X-Received: by 10.37.73.194 with SMTP id w185mr16347yba.427.1518114595502; Thu, 08 Feb 2018 10:29:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1518114595; cv=none; d=google.com; s=arc-20160816; b=ouox9j3TVLsuqJO2bvjgOgYFQ7/7ue8rnyHdEcH2rMT99X4BTjzNJj4fx+X+6OkIui k4PkcnV/hq0QqtZ7N8kTZ48FHvXcL/kchvf3QQdSVAA49uImPToxd8/k6POv7tfIzBJH yFvwv0+sarotWeK+7x0URb/NV8VRsQd5XW/z16hcFwzP2LnvMWcTJTsUcZ/jFDGuPJgQ 06N4NMG+XxuSCyZKPuUwQdgNiHHbXCW8fntTW88XjqD3t0o4N8AeYAYXKvwpOz1OIYlC ssoD32hzLCLznymPTlCrMVFNrfxW37sZnXO+Rou7+pkk63nwgmNC0SsA1Nu4lNhkoeZ3 ZNLw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:to:from:dkim-signature:arc-authentication-results; bh=6ruzjgKhgbGahv2tciRTBdbawFZedjHFVJrsITdlH2Q=; b=KzU1FEFJCiiaW9HtKDAho7vRMSl7jTba7/uCCls//omUVnivRwUlLcGVv80aPRu7ZX xqoTZejD+AurAKRrFZmUwHJbWbgTVarnbCVzEIwEBAEQ7TDK3GXp1mTLjNjb4bvBHiuq 2lMMe0mXe5ix3JvF4Vg14IfhJ0ZOejY6V7hvHan4904SvQK7xbwi24BXvime1koW/5Zz wD2WNOggNoBi67O+GhI2QQABfvEkSmQO4cXIBNxjVjVoKttWuG54iL3qsv8R2WJZJ00G yiA0DMAquNLle3kqyUAKYhITH0kP/MMtfpOvytMjZeiOAk3SLeMx244qIYmjcdECqlkS ugvw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=hbTzsOOh; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id p4si95948ybd.466.2018.02.08.10.29.55 for (version=TLS1 cipher=AES128-SHA bits=128/128); Thu, 08 Feb 2018 10:29:55 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=hbTzsOOh; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:60566 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ejqxG-00040P-QN for patch@linaro.org; Thu, 08 Feb 2018 13:29:54 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57596) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ejqBb-00037F-FT for qemu-devel@nongnu.org; Thu, 08 Feb 2018 12:40:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ejqBY-0000Yx-UA for qemu-devel@nongnu.org; Thu, 08 Feb 2018 12:40:39 -0500 Received: from mail-wr0-x242.google.com ([2a00:1450:400c:c0c::242]:36004) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ejqBY-0000Xh-El for qemu-devel@nongnu.org; Thu, 08 Feb 2018 12:40:36 -0500 Received: by mail-wr0-x242.google.com with SMTP id y3so5599982wrh.3 for ; Thu, 08 Feb 2018 09:40:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=6ruzjgKhgbGahv2tciRTBdbawFZedjHFVJrsITdlH2Q=; b=hbTzsOOhom7j5n1436igXSZyxGvV4ABtVkk8OkUyBY/TSq2NhI/0wz8W7GqtuYdMUt 08dgYkHiZkKMheU2XTZxxDqAHXDZOg5GQ/5MZ8zF0Ij0yhSJeL6Kmz55pa4XOfqrge2C kakecb61vQ6zQT0AUtK61lm6MoLxhndkCPvt4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=6ruzjgKhgbGahv2tciRTBdbawFZedjHFVJrsITdlH2Q=; b=R+1wD4qM8XgbTcrTvVztdgHZFlxxBHlv2a9BjG6ZID/8bSeq6LCQmFrlOg82IHS45N wToUCuWd4HRVjtPK5WllV9/Ydt7I9uPSjbZ9LZkThYgRvP/Nngj91N9sIItZObFcDoMz dA4mbbrvZ84ip7xj8Z2DX4euewsWvlF/O+WYgO6l0MS6MIiF2MreenOgbP8LHHY32TOx P7cT5QBNIEnftaNC3iU4R5YlcZvS7eXawfC9fhH99ld+0w7p3XIGDALauEDwjZzv+hHZ 3KR6rnkxfEfUDOitPJ7Doz7OiyZpfiEL2jRnm5Qn8amd0HZZh5NPA9ToBEB+J37IPUMy O2HQ== X-Gm-Message-State: APf1xPAKANQtVqiieaBk07tb3yC/gBuhOZrOaM+V8Kv0J4G3tmFUuQxV BdqGNjX5ZygNKBFxsEecW5Q25w== X-Received: by 10.223.131.230 with SMTP id 93mr1468821wre.59.1518111635187; Thu, 08 Feb 2018 09:40:35 -0800 (PST) Received: from zen.linaro.local ([81.128.185.34]) by smtp.gmail.com with ESMTPSA id p21sm418801wmc.28.2018.02.08.09.40.28 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 08 Feb 2018 09:40:30 -0800 (PST) Received: from zen.linaroharston (localhost [127.0.0.1]) by zen.linaro.local (Postfix) with ESMTP id E009C3E0FB8; Thu, 8 Feb 2018 17:31:59 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-arm@nongnu.org Date: Thu, 8 Feb 2018 17:31:54 +0000 Message-Id: <20180208173157.24705-30-alex.bennee@linaro.org> X-Mailer: git-send-email 2.15.1 In-Reply-To: <20180208173157.24705-1-alex.bennee@linaro.org> References: <20180208173157.24705-1-alex.bennee@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c0c::242 Subject: [Qemu-devel] [PATCH v2 29/32] arm/translate-a64: add FP16 FMOV to simd_mod_imm X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , =?utf-8?q?Alex_Benn=C3=A9e?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Only one half-precision instruction has been added to this group. Signed-off-by: Alex Bennée --- v2 - checkpatch fixes --- target/arm/translate-a64.c | 48 ++++++++++++++++++++++++++++++++++++---------- 1 file changed, 38 insertions(+), 10 deletions(-) -- 2.15.1 diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c index fa21299061..b209f57d55 100644 --- a/target/arm/translate-a64.c +++ b/target/arm/translate-a64.c @@ -6160,6 +6160,8 @@ static void disas_simd_copy(DisasContext *s, uint32_t insn) * MVNI - move inverted (shifted) imm into register * ORR - bitwise OR of (shifted) imm with register * BIC - bitwise clear of (shifted) imm with register + * With ARMv8.2 we also have: + * FMOV half-precision */ static void disas_simd_mod_imm(DisasContext *s, uint32_t insn) { @@ -6176,8 +6178,11 @@ static void disas_simd_mod_imm(DisasContext *s, uint32_t insn) int i; if (o2 != 0 || ((cmode == 0xf) && is_neg && !is_q)) { - unallocated_encoding(s); - return; + /* Check for FMOV (vector, immediate) - half-precision */ + if (!(arm_dc_feature(s, ARM_FEATURE_V8_FP16) && o2 && cmode == 0xf)) { + unallocated_encoding(s); + return; + } } if (!fp_access_check(s)) { @@ -6235,19 +6240,42 @@ static void disas_simd_mod_imm(DisasContext *s, uint32_t insn) imm |= 0x4000000000000000ULL; } } else { - imm = (abcdefgh & 0x3f) << 19; - if (abcdefgh & 0x80) { - imm |= 0x80000000; - } - if (abcdefgh & 0x40) { - imm |= 0x3e000000; + if (o2) { + /* FMOV (vector, immediate) - half-precision + * + * We don't need fancy immediate expansion, just: + * imm16 = imm8<7>:NOT(imm8<6>):Replicate(imm8<6>,2): + * imm8<5:0>:Zeros(6); + */ + uint32_t imm8_5_0 = extract32(abcdefgh, 0, 6); + uint32_t imm8_6 = extract32(abcdefgh, 6, 1); + uint32_t imm8_7 = extract32(abcdefgh, 7, 1); + uint32_t imm8_6_rep = imm8_6 << 1 | imm8_6; + uint32_t imm8_6_not = ~imm8_6; + imm = deposit64(imm, 6, 6, imm8_5_0); + imm = deposit64(imm, 12, 2, imm8_6_rep); + imm = deposit64(imm, 14, 1, imm8_6_not); + imm = deposit64(imm, 15, 1, imm8_7); + /* now duplicate across the lanes */ + imm = bitfield_replicate(imm, 16); } else { - imm |= 0x40000000; + imm = (abcdefgh & 0x3f) << 19; + if (abcdefgh & 0x80) { + imm |= 0x80000000; + } + if (abcdefgh & 0x40) { + imm |= 0x3e000000; + } else { + imm |= 0x40000000; + } + imm |= (imm << 32); } - imm |= (imm << 32); } } break; + default: + fprintf(stderr, "%s: cmode_3_1: %x\n", __func__, cmode_3_1); + g_assert_not_reached(); } if (cmode_3_1 != 7 && is_neg) {