diff mbox series

[PULL,29/30] target/arm/translate.c: Fix missing 'break' for TT insns

Message ID 20180209110314.11766-30-peter.maydell@linaro.org
State Accepted
Commit 384c6c03fb687bea239a5990a538c4bc50fdcecb
Headers show
Series target-arm queue | expand

Commit Message

Peter Maydell Feb. 9, 2018, 11:03 a.m. UTC 
The code where we added the TT instruction was accidentally
missing a 'break', which meant that after generating the code
to execute the TT we would fall through to 'goto illegal_op'
and generate code to take an UNDEF insn.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

Message-id: 20180206103941.13985-1-peter.maydell@linaro.org
---
 target/arm/translate.c | 1 +
 1 file changed, 1 insertion(+)

-- 
2.16.1
diff mbox series

Patch

diff --git a/target/arm/translate.c b/target/arm/translate.c
index a8c13d3758..1270022289 100644
--- a/target/arm/translate.c
+++ b/target/arm/translate.c
@@ -9925,6 +9925,7 @@  static void disas_thumb2_insn(DisasContext *s, uint32_t insn)
                         tcg_temp_free_i32(addr);
                         tcg_temp_free_i32(op);
                         store_reg(s, rd, ttresp);
+                        break;
                     }
                     goto illegal_op;
                 }