From patchwork Mon Feb 12 14:58:31 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jerome Brunet X-Patchwork-Id: 128126 Delivered-To: patch@linaro.org Received: by 10.46.124.24 with SMTP id x24csp3287614ljc; Mon, 12 Feb 2018 06:59:06 -0800 (PST) X-Google-Smtp-Source: AH8x226l2st2OcQ0A90m71tkwXv2z6Q6xKr9rJyl8HTrJt/pNe3kmC9w5ApmK4nizZG2AnXra1iK X-Received: by 2002:a17:902:6843:: with SMTP id f3-v6mr10812428pln.182.1518447545876; Mon, 12 Feb 2018 06:59:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1518447545; cv=none; d=google.com; s=arc-20160816; b=WSs4tsImdqR2sch8SNkPNusPZmHhwZATDbLyJBP7QoLKl341XREK1h7+xAQcUD0QSl Njrs/iKbJcDPKRxIDJesbI/jVsswe5RVCY7ZCd+2CIVCCPcoIzoJIt7GYB110A7AhKs7 mZIoVTz56FzSEOnNxMH7oRsDBoe0KWvX6DeMWI5TfvTlOaRUwcImD4U2oOfEMhA1W0/z otXUKg9YDsF50y7FKkd74FwgB2auQ0XdgvBgEHwRMIcgcgxZ3fjDqn+aH2OY3auudiC2 Rsi8eZQUtNg9sCNJbi7ln2e5C+b9WfFgtDwtTEBxkQL/+AoNqbobcedFJybtm1FYR6P6 tyCA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=mzsMSS4BEKPyHePoAMJZ+kBbonUrGv7wstZ56GdDsGo=; b=MBRgD7rbU46YLJ9P4enM6xOQ2D+uYakbkXGMo4fobjLnhjAI7Wg+rChXgdTXzKIVKm xr0TxYvKY8q5kQXEwIxDBFjgct6XNK+snjUVwg7NTo8poWz+b1HTZBStQo3vDBUalBaB SRpyVsGh65YOy2irzY8HI3NO7wJfwhPlVQEv9bXOzlWwNTmYr9rw/38pb7qTARNMvfP/ kcP74G3KVZhqvfZhJm7xEKhXFRPpDmC3HSFS/BL73zFcPCktVjTTdCNyYBewUGzMknTv HwDBXvEX4UMoLs8QOT/IFugadj9l8bh98Sz+bM4H4W6I3V/lS90XLxg0BFRiOG1M0YMc sIog== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@baylibre-com.20150623.gappssmtp.com header.s=20150623 header.b=I+kd/4L1; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 3-v6si3983008plz.209.2018.02.12.06.59.05; Mon, 12 Feb 2018 06:59:05 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@baylibre-com.20150623.gappssmtp.com header.s=20150623 header.b=I+kd/4L1; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932428AbeBLO7A (ORCPT + 15 others); Mon, 12 Feb 2018 09:59:00 -0500 Received: from mail-wr0-f196.google.com ([209.85.128.196]:45244 "EHLO mail-wr0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932293AbeBLO6z (ORCPT ); Mon, 12 Feb 2018 09:58:55 -0500 Received: by mail-wr0-f196.google.com with SMTP id h9so15499617wre.12 for ; Mon, 12 Feb 2018 06:58:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=mzsMSS4BEKPyHePoAMJZ+kBbonUrGv7wstZ56GdDsGo=; b=I+kd/4L1DQuXxSL2FBepFB5SpQgEFV0d5t/JhIX9lgj8atCA+mqEoiX/Bxu+KpDJdH Y8qPxwT07dj+kgJMktANt77nMJtEKG4Ju42R9B0aJumknQCu/9ThLydQF9fmCwRYOAVr mRoWvlIBy2U3iHYKTrfmX0n1CCN5vZYkfmjvZS2FSCLVeoGqtvg7OZi3lWS7RmU7gbWE ZLtNxKcMJcNrH0wi1b2gy2KApRk8Ih8KogBzkzsxHPlYDKUsRzQPYE2xdPxkQ1AW/Mq0 VFtARiFC3teVYzKdcK+4ADaKr4NIrPsUIZyttYRL7EOMlyjOKKHTd6V58ykC/FghyMMx hORg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=mzsMSS4BEKPyHePoAMJZ+kBbonUrGv7wstZ56GdDsGo=; b=eSmPA1fz+itnfm9W9hFL6pft90TVeTfhGa1nWQ2Eu+uKHb3mHpr4Jm6PF7lhf/RPuk hhlzD/queOKjly6fX9a0Lb57rYozD+aIlVLo+nNNxN1pvZLpLvg1wD3AEtJn8KPGUE+e Av7AFBiarQ9IF1C1mWUg3r+SZSE2kaW/WctRkXyjPMXvrMf0x1gRdt6oE4CFVYfvmBAi xXsAlKUdWuQ5PayFs+j2LS6aF+RY3B2M4DzVkN9i8U5SKodQyWgr/MQgaRRa1ZY0mO3A hFDI46ubPcOiynfDfAzwnyYitwxPq+KpQMAh7hvFb5F1CcACR7OivIPBQ0RBvYtsT3Ab Wy4Q== X-Gm-Message-State: APf1xPD+cO6RXwaiCjXKX74hkWXcil7o4cgEvQ+jcvR3mIeeygM6cNBm Dpq4APxYlm2IMeXZsfbLn/1dzw== X-Received: by 10.223.172.76 with SMTP id v70mr6267405wrc.8.1518447534261; Mon, 12 Feb 2018 06:58:54 -0800 (PST) Received: from boomer.baylibre.local ([90.63.244.31]) by smtp.googlemail.com with ESMTPSA id p21sm4633218wmc.28.2018.02.12.06.58.53 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 12 Feb 2018 06:58:53 -0800 (PST) From: Jerome Brunet To: Neil Armstrong , Kevin Hilman Cc: Jerome Brunet , Stephen Boyd , Michael Turquette , Carlo Caione , linux-amlogic@lists.infradead.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 04/19] clk: meson: remove obsolete comments Date: Mon, 12 Feb 2018 15:58:31 +0100 Message-Id: <20180212145846.19380-5-jbrunet@baylibre.com> X-Mailer: git-send-email 2.14.3 In-Reply-To: <20180212145846.19380-1-jbrunet@baylibre.com> References: <20180212145846.19380-1-jbrunet@baylibre.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Over time things changes in CCF and issues have been fixed in meson controllers. Now, clk81 is decently modeled by read-only PLLs, a mux, a divider and a gate. We can remove the FIXME comments related to clk81. Also remove the comment about devm_clk_hw_register, as there is apparently nothing wrong with it. Signed-off-by: Jerome Brunet --- drivers/clk/meson/axg.c | 5 ----- drivers/clk/meson/gxbb.c | 6 ------ drivers/clk/meson/meson8b.c | 1 - 3 files changed, 12 deletions(-) -- 2.14.3 diff --git a/drivers/clk/meson/axg.c b/drivers/clk/meson/axg.c index 3bb77b4f1e8d..bc5c29f13282 100644 --- a/drivers/clk/meson/axg.c +++ b/drivers/clk/meson/axg.c @@ -411,11 +411,6 @@ static struct meson_clk_mpll axg_mpll3 = { }, }; -/* - * FIXME The legacy composite clocks (e.g. clk81) are both PLL post-dividers - * and should be modeled with their respective PLLs via the forthcoming - * coordinated clock rates feature - */ static u32 mux_table_clk81[] = { 0, 2, 3, 4, 5, 6, 7 }; static const char * const clk81_parent_names[] = { "xtal", "fclk_div7", "mpll1", "mpll2", "fclk_div4", diff --git a/drivers/clk/meson/gxbb.c b/drivers/clk/meson/gxbb.c index e6adab49c0ba..6609024eee00 100644 --- a/drivers/clk/meson/gxbb.c +++ b/drivers/clk/meson/gxbb.c @@ -575,12 +575,6 @@ static struct meson_clk_mpll gxbb_mpll2 = { }, }; -/* - * FIXME The legacy composite clocks (e.g. clk81) are both PLL post-dividers - * and should be modeled with their respective PLLs via the forthcoming - * coordinated clock rates feature - */ - static u32 mux_table_clk81[] = { 0, 2, 3, 4, 5, 6, 7 }; static const char * const clk81_parent_names[] = { "xtal", "fclk_div7", "mpll1", "mpll2", "fclk_div4", diff --git a/drivers/clk/meson/meson8b.c b/drivers/clk/meson/meson8b.c index ffadad27375e..db017c29a84c 100644 --- a/drivers/clk/meson/meson8b.c +++ b/drivers/clk/meson/meson8b.c @@ -849,7 +849,6 @@ static int meson8b_clkc_probe(struct platform_device *pdev) if (!meson8b_hw_onecell_data.hws[i]) continue; - /* FIXME convert to devm_clk_register */ ret = devm_clk_hw_register(dev, meson8b_hw_onecell_data.hws[i]); if (ret) return ret;