From patchwork Mon Feb 12 14:58:30 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jerome Brunet X-Patchwork-Id: 128142 Delivered-To: patch@linaro.org Received: by 10.46.124.24 with SMTP id x24csp3296359ljc; Mon, 12 Feb 2018 07:06:48 -0800 (PST) X-Google-Smtp-Source: AH8x226OgDedmHBvMjBgTVt3QnmOWxe8Bcu4ZLvn9kbC+a7P/AhHRhoH4gN4MuTdgi/Ns1Ezo42a X-Received: by 2002:a17:902:261:: with SMTP id 88-v6mr9660908plc.384.1518448008426; Mon, 12 Feb 2018 07:06:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1518448008; cv=none; d=google.com; s=arc-20160816; b=PF2emBgf0MwgtOZUOPGqAXHv6RdJ7DdpYGyWoNtfU+GyZkR3LuBi80irBfxXX3v/Rj JL1ydYKfPJBI0yHKRxeky4BS+fuFU5xL8z7n/Y+oyKlLB5nqFUFDkKPCKINbJAv5RAkX Q7tDGx8gx7kodhGpbSLYttttcH8FujrDwxaevHLI0JT5kobM1ViRMj+jSJum64THkZi7 j9WsBb6DpA+7SSHF4jLPMll3M4BAouzHlNkatyThHljp1hzzspSRjR0/ITJXT06xJ/VF nCKTVYxnrGYjrP9OhKY8uCO//LbvQuWPEHiAyswTUjsBQYTEXZycy05PVfwNNdRgXJRF oU9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=ITfljnTWXXx1peAxkmQKnxmAqTxINyPBQ0hb1QbZXt4=; b=fpkIZRYqf+yDpH9M6hxA1cggnQ9jwCSlZ66ZoSGppgFeaGpLjpqKTlOugXo7EPj4Zj uR+3OCBMZP3p98Y7UmtgAKFFWlVhiUiFDrxdX4FYBgleWGGrIzL9ZPS8R0PWL2ozVsWH FWhDGQfUFSy5hgdNIdEtRbeVNPp0hoRuVpYp9iMjQDIazS9iqRlLxeSicB/r5DxGXzwY OYnRFZpJh1prGwQc5z6+4R1VUxwV6Mf9Gt/Wbs317pbI5SoG7BCcFICwDclPoRPV2OFv xBjiJJ6joDPyVbYLOaMYfPb44o3ss+iGxbAOWGTehuCcrvlJeycKY/OVGWjySmq0F2xd R3kQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@baylibre-com.20150623.gappssmtp.com header.s=20150623 header.b=Ku3SfbS0; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k136si5268776pga.44.2018.02.12.07.06.48; Mon, 12 Feb 2018 07:06:48 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@baylibre-com.20150623.gappssmtp.com header.s=20150623 header.b=Ku3SfbS0; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934709AbeBLPGp (ORCPT + 15 others); Mon, 12 Feb 2018 10:06:45 -0500 Received: from mail-wr0-f196.google.com ([209.85.128.196]:46312 "EHLO mail-wr0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932271AbeBLO6y (ORCPT ); Mon, 12 Feb 2018 09:58:54 -0500 Received: by mail-wr0-f196.google.com with SMTP id 34so5237215wre.13 for ; Mon, 12 Feb 2018 06:58:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=ITfljnTWXXx1peAxkmQKnxmAqTxINyPBQ0hb1QbZXt4=; b=Ku3SfbS0Wb+GUROZylXs9aHVb096y1sMBtW+OOQ05/Ij/02J8pXBJfoeiHd5xKwgWr iFEwsdgbmLxVYqk78RmWlcApgJ7qWhEjsur26KVzgYFxHfgAfp33hCeT+3CxGmSFm08Q U1k3dAiEIEggDG/mOUgQEv/9SbhU9tUuns1+Oiv7t24tOT+hqZuE6wNq7rnaPbHV9fS3 H7xF1wXV/2abeuDFO0XwXEVKLpbZ7MrunA6dBwJ4oEpMWOcCHrd/pDeLko6qxTXQDitZ hXC9CI/BkNGIeaKzcOVJo7BX3AXnNoeedljDWPXaYZuSHefuEJudlnJ//c/bPTIBuFsL PSKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=ITfljnTWXXx1peAxkmQKnxmAqTxINyPBQ0hb1QbZXt4=; b=ne4sxgGGBnMm3zDt6D+NNDI6Jka9Ao0p5DwdQCbtLVXHQTPjbQCNb4AuGtLKqu1RvP uW5JkPcIoU7BdPkVtV9ecToek3FwcUc/FYb60EjZUmwbqYfYcpg5AcxF/dBuB8e/9wOH 0kQ05rFKnpYW2HafO+elxU8SrCdpHZtAsa8PNlL0nH6VlZ8j6mwOYlzpXgUleNUWbn3z /DIwKZ2n2Ljv1Wmp6LR3B6zAHKXWBNqDD9PnbuWcEdcaq5DYXF6HGh43v51UNQHdbiv5 GrB1RVjeh9/DMQXxeW12YfChTpaEAGzuHLLOkWGh25FXq1pwExXPfOy52Q22y/QzRY5W cc3Q== X-Gm-Message-State: APf1xPAaRfczDYZgcB2Z75DN3UooMzQR10OAFZ1CLv8ewxcP6L9alYEq Wn5ZWDqW/DfDh8asj03DL5msFw== X-Received: by 10.223.163.215 with SMTP id m23mr2609972wrb.90.1518447533218; Mon, 12 Feb 2018 06:58:53 -0800 (PST) Received: from boomer.baylibre.local ([90.63.244.31]) by smtp.googlemail.com with ESMTPSA id p21sm4633218wmc.28.2018.02.12.06.58.52 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 12 Feb 2018 06:58:52 -0800 (PST) From: Jerome Brunet To: Neil Armstrong , Kevin Hilman Cc: Jerome Brunet , Stephen Boyd , Michael Turquette , Carlo Caione , linux-amlogic@lists.infradead.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 03/19] clk: meson: only one loop index is necessary in probe Date: Mon, 12 Feb 2018 15:58:30 +0100 Message-Id: <20180212145846.19380-4-jbrunet@baylibre.com> X-Mailer: git-send-email 2.14.3 In-Reply-To: <20180212145846.19380-1-jbrunet@baylibre.com> References: <20180212145846.19380-1-jbrunet@baylibre.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org We don't need several loop index variables in the probe function This is far from being critical but since we are doing a vast rework of meson clock controllers, now is the time to lower the entropy a bit Signed-off-by: Jerome Brunet --- drivers/clk/meson/axg.c | 8 ++++---- drivers/clk/meson/gxbb.c | 13 ++++++------- drivers/clk/meson/meson8b.c | 8 ++++---- 3 files changed, 14 insertions(+), 15 deletions(-) -- 2.14.3 diff --git a/drivers/clk/meson/axg.c b/drivers/clk/meson/axg.c index e16d53b6be30..3bb77b4f1e8d 100644 --- a/drivers/clk/meson/axg.c +++ b/drivers/clk/meson/axg.c @@ -802,7 +802,7 @@ static int axg_clkc_probe(struct platform_device *pdev) const struct clkc_data *clkc_data; struct resource *res; void __iomem *clk_base; - int ret, clkid, i; + int ret, i; clkc_data = of_device_get_match_data(dev); if (!clkc_data) @@ -841,13 +841,13 @@ static int axg_clkc_probe(struct platform_device *pdev) clkc_data->clk_dividers[i]->reg = clk_base + (u64)clkc_data->clk_dividers[i]->reg; - for (clkid = 0; clkid < clkc_data->hw_onecell_data->num; clkid++) { + for (i = 0; i < clkc_data->hw_onecell_data->num; i++) { /* array might be sparse */ - if (!clkc_data->hw_onecell_data->hws[clkid]) + if (!clkc_data->hw_onecell_data->hws[i]) continue; ret = devm_clk_hw_register(dev, - clkc_data->hw_onecell_data->hws[clkid]); + clkc_data->hw_onecell_data->hws[i]); if (ret) { dev_err(dev, "Clock registration failed\n"); return ret; diff --git a/drivers/clk/meson/gxbb.c b/drivers/clk/meson/gxbb.c index 17f44ac751b3..e6adab49c0ba 100644 --- a/drivers/clk/meson/gxbb.c +++ b/drivers/clk/meson/gxbb.c @@ -1947,7 +1947,7 @@ static int gxbb_clkc_probe(struct platform_device *pdev) { const struct clkc_data *clkc_data; void __iomem *clk_base; - int ret, clkid, i; + int ret, i; struct device *dev = &pdev->dev; clkc_data = of_device_get_match_data(dev); @@ -1988,16 +1988,15 @@ static int gxbb_clkc_probe(struct platform_device *pdev) for (i = 0; i < clkc_data->clk_audio_dividers_count; i++) clkc_data->clk_audio_dividers[i]->base = clk_base; - /* - * register all clks - */ - for (clkid = 0; clkid < clkc_data->hw_onecell_data->num; clkid++) { + + /* Register all clks */ + for (i = 0; i < clkc_data->hw_onecell_data->num; i++) { /* array might be sparse */ - if (!clkc_data->hw_onecell_data->hws[clkid]) + if (!clkc_data->hw_onecell_data->hws[i]) continue; ret = devm_clk_hw_register(dev, - clkc_data->hw_onecell_data->hws[clkid]); + clkc_data->hw_onecell_data->hws[i]); if (ret) goto iounmap; } diff --git a/drivers/clk/meson/meson8b.c b/drivers/clk/meson/meson8b.c index abac079ff77f..ffadad27375e 100644 --- a/drivers/clk/meson/meson8b.c +++ b/drivers/clk/meson/meson8b.c @@ -806,7 +806,7 @@ static const struct reset_control_ops meson8b_clk_reset_ops = { static int meson8b_clkc_probe(struct platform_device *pdev) { - int ret, clkid, i; + int ret, i; struct clk_hw *parent_hw; struct clk *parent_clk; struct device *dev = &pdev->dev; @@ -844,13 +844,13 @@ static int meson8b_clkc_probe(struct platform_device *pdev) * register all clks * CLKID_UNUSED = 0, so skip it and start with CLKID_XTAL = 1 */ - for (clkid = CLKID_XTAL; clkid < CLK_NR_CLKS; clkid++) { + for (i = CLKID_XTAL; i < CLK_NR_CLKS; i++) { /* array might be sparse */ - if (!meson8b_hw_onecell_data.hws[clkid]) + if (!meson8b_hw_onecell_data.hws[i]) continue; /* FIXME convert to devm_clk_register */ - ret = devm_clk_hw_register(dev, meson8b_hw_onecell_data.hws[clkid]); + ret = devm_clk_hw_register(dev, meson8b_hw_onecell_data.hws[i]); if (ret) return ret; }