[2/9] mmc: hsmmc_omap: include types.h and provide header inclusion guard

Message ID 20180213013243.8378-3-s-anna@ti.com
State New
Headers show
Series
  • Some OMAP2+ legacy hwmod data cleanup
Related show

Commit Message

Suman Anna Feb. 13, 2018, 1:32 a.m.
The hsmmc-omap platform data header file uses some u8/u16/u32 types,
so include the linux types.h header file so that it is self-contained.
The lack of this header caused some build errors while cleaning up some
other header files from various omap_hwmod data files.

While at this, also add the missing header inclusion guard.

Cc: Ulf Hansson <ulf.hansson@linaro.org>
Signed-off-by: Suman Anna <s-anna@ti.com>

---
Hi Ulf,

This patch is part of a hwmod cleanup series, and is needed before I
can do the cleanup in those files. So prefer to have this patch go
through Tony as part of the series.

regards
Suman

 include/linux/platform_data/hsmmc-omap.h | 8 ++++++++
 1 file changed, 8 insertions(+)

-- 
2.15.1

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Tony Lindgren Feb. 14, 2018, 5:50 p.m. | #1
* Suman Anna <s-anna@ti.com> [180213 01:33]:
> The hsmmc-omap platform data header file uses some u8/u16/u32 types,

> so include the linux types.h header file so that it is self-contained.

> The lack of this header caused some build errors while cleaning up some

> other header files from various omap_hwmod data files.

> 

> While at this, also add the missing header inclusion guard.

> 

> Cc: Ulf Hansson <ulf.hansson@linaro.org>

> Signed-off-by: Suman Anna <s-anna@ti.com>

> ---

> Hi Ulf,

> 

> This patch is part of a hwmod cleanup series, and is needed before I

> can do the cleanup in those files. So prefer to have this patch go

> through Tony as part of the series.


No need for this, I'll post a patch that includes types.h
directly in the calling code.

Regards,

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/include/linux/platform_data/hsmmc-omap.h b/include/linux/platform_data/hsmmc-omap.h
index 73d9098ada2d..9573b87dae14 100644
--- a/include/linux/platform_data/hsmmc-omap.h
+++ b/include/linux/platform_data/hsmmc-omap.h
@@ -24,6 +24,12 @@ 
  *    Operation Issue" in _OMAP3530/3525/3515/3503 Silicon Errata_
  *    Revision F (October 2010) (SPRZ278F).
  */
+
+#ifndef __LINUX_PLATFORM_DATA_OMAP_HSMMC_H__
+#define __LINUX_PLATFORM_DATA_OMAP_HSMMC_H__
+
+#include <linux/types.h>
+
 #define OMAP_HSMMC_SUPPORTS_DUAL_VOLT		BIT(0)
 #define OMAP_HSMMC_BROKEN_MULTIBLOCK_READ	BIT(1)
 #define OMAP_HSMMC_SWAKEUP_MISSING		BIT(2)
@@ -79,3 +85,5 @@  struct omap_hsmmc_platform_data {
 	const char *name;
 	u32 ocr_mask;
 };
+
+#endif