From patchwork Tue Feb 13 12:16:11 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Brown X-Patchwork-Id: 128223 Delivered-To: patch@linaro.org Received: by 10.46.124.24 with SMTP id x24csp4191584ljc; Tue, 13 Feb 2018 04:17:44 -0800 (PST) X-Google-Smtp-Source: AH8x224Q3yIMqe76lwpufDpuQfFH9TOmu11wlK4MXEjEBJ22dSIWyx/1dDo7ublnWTEKb33MEFnG X-Received: by 10.28.191.19 with SMTP id p19mr1104972wmf.142.1518524264014; Tue, 13 Feb 2018 04:17:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1518524264; cv=none; d=google.com; s=arc-20160816; b=AbvGnzjTIVNS+gqIUmqgOd5PKZ8OyKrnPXCK7BoB0M9DZB6HDzGvi+uKcliKx7hyi3 Kwop6d/uB1U80BsSdUy+mmvAipp2gPqo//txrzweStc5j9iw+ob20jMQBB8Zi5huzTHR yUQOQdMOHHlpxhE75Mzk3oqIxJCi5ZG4sPJdpWkyDSO8cJCsvatCjJzGgr+jinRFfmsR JrlX2gZKnE5Pn2diXfgZv8JSvwgPfZT9mlS2sxzs8u1BrbF2zmEBfN9PAjy+bH3whAs7 l2s8XibjVkGWq6gFrHSlUngiw+NlveTXJg2HNm4rtGgnk1tJsK8YDWxGYPoPtJQnvwY0 ZTrw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:cc:date:message-id:in-reply-to:to:from :dkim-signature:delivered-to:arc-authentication-results; bh=eNxHnu6U28vf1VgYe8eTct2CLIxDEaAWcb890nj7s3s=; b=WneCy0YrsuiLpgW6DJBSfLxxuAUcGIr6aeg5sw2oE4ama2DkUpkGlRoyI6CUv+SN08 Rbz99tnXLv8/7vDb3kPZWwESpHRQAs2AyAlY4EdovQ3luOPrzI8SEr2OEAzmCqqKumU7 DiuV4eIutBi+T8Q2hIfTK62gECUBN1//EzG4J3b8Y/PdSka9xm/Y/Hih7b2gakIdnq6A JFLR1s8eYMXC8Q3JmT+RGmSCUcf/AV6T/O/OIEurh9tH/5ORcGO4AjTQiBYz9Po/N/Dh EILox8cinmSPJDo4v74qfIGb/PnpuHDdbJtD0P6NTEASvavfIutVgMHb2BJqcmNFPJG5 uwbw== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=VZQQ1z2O; spf=pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) smtp.mailfrom=alsa-devel-bounces@alsa-project.org Return-Path: Received: from alsa0.perex.cz (alsa0.perex.cz. [77.48.224.243]) by mx.google.com with ESMTP id t7si5223765wmc.214.2018.02.13.04.17.43; Tue, 13 Feb 2018 04:17:44 -0800 (PST) Received-SPF: pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) client-ip=77.48.224.243; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=VZQQ1z2O; spf=pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id D76A226794E; Tue, 13 Feb 2018 13:17:22 +0100 (CET) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id C5ACD267920; Tue, 13 Feb 2018 13:17:20 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mail1.perex.cz X-Spam-Level: X-Spam-Status: No, score=0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, SPF_PASS, T_RP_MATCHES_RCVD autolearn=disabled version=3.4.0 Received: from heliosphere.sirena.org.uk (heliosphere.sirena.org.uk [172.104.155.198]) by alsa0.perex.cz (Postfix) with ESMTP id BC3B8267963 for ; Tue, 13 Feb 2018 13:16:13 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=Date:Message-Id:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner: List-Archive; bh=rjipOEYXJAsxofwnmd7Wz9tbMtL4RIG8sc+XhXmdn3Y=; b=VZQQ1z2Oc8Hq 29XKXH2TqtIErhLKEK0n0+xLgHcZbizTkt4wPThcflKNYrYqhxUWyrmG4iH+ZnwzZM15qlaOmZtZh f61uaXtxKRc4BH8zMFqYmB9T7+50BKEGz21KAmSZYKM2PTvqEW+VeEhFEluuujvRTNXOsK8fSsVVN HixOM=; Received: from debutante.sirena.org.uk ([2001:470:1f1d:6b5::3] helo=debutante) by heliosphere.sirena.org.uk with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1elZVL-0006Su-VY; Tue, 13 Feb 2018 12:16:12 +0000 Received: from broonie by debutante with local (Exim 4.90) (envelope-from ) id 1elZVL-0005YN-Gv; Tue, 13 Feb 2018 12:16:11 +0000 From: Mark Brown To: Kuninori Morimoto In-Reply-To: <873725lk0x.wl%kuninori.morimoto.gx@renesas.com> Message-Id: Date: Tue, 13 Feb 2018 12:16:11 +0000 Cc: alsa-devel@alsa-project.org, Mark Brown , hiroyuki.yokoyama.vx@renesas.com Subject: [alsa-devel] Applied "ASoC: rsnd: suppress rsnd_dai_call() debug message" to the asoc tree X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org The patch ASoC: rsnd: suppress rsnd_dai_call() debug message has been applied to the asoc tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark >From 1f6e920faae065fa8e6985b99ec86899bc3308de Mon Sep 17 00:00:00 2001 From: Kuninori Morimoto Date: Tue, 13 Feb 2018 02:09:14 +0000 Subject: [PATCH] ASoC: rsnd: suppress rsnd_dai_call() debug message rsnd_dai_call() is using dev_dbg(), but its message is sometimes blocks nessesary other messages. If RSND_DEBUG_NO_DAI_CALL was defined it will be suppressed by this patch. Reported-by: Hiroyuki Yokoyama Signed-off-by: Kuninori Morimoto Tested-by: Hiroyuki Yokoyama Signed-off-by: Mark Brown --- sound/soc/sh/rcar/core.c | 11 ++++++++++- sound/soc/sh/rcar/rsnd.h | 10 ++++++++++ 2 files changed, 20 insertions(+), 1 deletion(-) -- 2.16.1 _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel diff --git a/sound/soc/sh/rcar/core.c b/sound/soc/sh/rcar/core.c index 64d5ecb86528..5aafc37f5119 100644 --- a/sound/soc/sh/rcar/core.c +++ b/sound/soc/sh/rcar/core.c @@ -93,6 +93,15 @@ * [mod]->fn() -> [mod]->fn() -> [mod]->fn()... * */ + +/* + * you can enable below define if you don't need + * DAI status debug message when debugging + * see rsnd_dbg_dai_call() + * + * #define RSND_DEBUG_NO_DAI_CALL 1 + */ + #include #include "rsnd.h" @@ -468,7 +477,7 @@ static int rsnd_status_update(u32 *status, __rsnd_mod_shift_##fn, \ __rsnd_mod_add_##fn, \ __rsnd_mod_call_##fn); \ - dev_dbg(dev, "%s[%d]\t0x%08x %s\n", \ + rsnd_dbg_dai_call(dev, "%s[%d]\t0x%08x %s\n", \ rsnd_mod_name(mod), rsnd_mod_id(mod), *status, \ (func_call && (mod)->ops->fn) ? #fn : ""); \ if (func_call && (mod)->ops->fn) \ diff --git a/sound/soc/sh/rcar/rsnd.h b/sound/soc/sh/rcar/rsnd.h index 5241ea7cf153..172c8d612890 100644 --- a/sound/soc/sh/rcar/rsnd.h +++ b/sound/soc/sh/rcar/rsnd.h @@ -798,4 +798,14 @@ void rsnd_mod_make_sure(struct rsnd_mod *mod, enum rsnd_mod_type type); if (!IS_BUILTIN(RSND_DEBUG_NO_IRQ_STATUS)) \ dev_dbg(dev, param) +/* + * If you don't need rsnd_dai_call debug message, + * define RSND_DEBUG_NO_DAI_CALL as 1 on top of core.c + * + * #define RSND_DEBUG_NO_DAI_CALL 1 + */ +#define rsnd_dbg_dai_call(dev, param...) \ + if (!IS_BUILTIN(RSND_DEBUG_NO_DAI_CALL)) \ + dev_dbg(dev, param) + #endif