diff mbox series

[oe,meta-qt5] qtbase: Replace -isystem with -I

Message ID 20180215043848.14310-1-raj.khem@gmail.com
State Superseded
Headers show
Series [oe,meta-qt5] qtbase: Replace -isystem with -I | expand

Commit Message

Khem Raj Feb. 15, 2018, 4:38 a.m. UTC
Fixes no-x11 builds (eglfs)

Signed-off-by: Khem Raj <raj.khem@gmail.com>

---
 recipes-qt/qt5/qtbase-native_git.bb                |  1 +
 ...mon-gcc-base.conf-Use-I-instead-of-isyste.patch | 36 ++++++++++++++++++++++
 recipes-qt/qt5/qtbase_git.bb                       |  1 +
 3 files changed, 38 insertions(+)
 create mode 100644 recipes-qt/qt5/qtbase/0014-mkspecs-common-gcc-base.conf-Use-I-instead-of-isyste.patch

-- 
2.16.1

-- 
_______________________________________________
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Comments

Denys Dmytriyenko Feb. 15, 2018, 11:41 p.m. UTC | #1
On Wed, Feb 14, 2018 at 08:38:48PM -0800, Khem Raj wrote:
> Fixes no-x11 builds (eglfs)

> 

> Signed-off-by: Khem Raj <raj.khem@gmail.com>

> ---

>  recipes-qt/qt5/qtbase-native_git.bb                |  1 +

>  ...mon-gcc-base.conf-Use-I-instead-of-isyste.patch | 36 ++++++++++++++++++++++

>  recipes-qt/qt5/qtbase_git.bb                       |  1 +

>  3 files changed, 38 insertions(+)

>  create mode 100644 recipes-qt/qt5/qtbase/0014-mkspecs-common-gcc-base.conf-Use-I-instead-of-isyste.patch

> 

> diff --git a/recipes-qt/qt5/qtbase-native_git.bb b/recipes-qt/qt5/qtbase-native_git.bb

> index ac3924e..ffde8ee 100644

> --- a/recipes-qt/qt5/qtbase-native_git.bb

> +++ b/recipes-qt/qt5/qtbase-native_git.bb

> @@ -34,6 +34,7 @@ SRC_URI += "\

>      file://0009-Add-OE-specific-specs-for-clang-compiler.patch \

>      file://0010-linux-clang-Invert-conditional-for-defining-QT_SOCKL.patch \

>      file://0011-tst_qlocale-Enable-QT_USE_FENV-only-on-glibc.patch \

> +    file://0014-mkspecs-common-gcc-base.conf-Use-I-instead-of-isyste.patch \

>  "

>  

>  # common for qtbase-native and nativesdk-qtbase

> diff --git a/recipes-qt/qt5/qtbase/0014-mkspecs-common-gcc-base.conf-Use-I-instead-of-isyste.patch b/recipes-qt/qt5/qtbase/0014-mkspecs-common-gcc-base.conf-Use-I-instead-of-isyste.patch

> new file mode 100644

> index 0000000..44e9009

> --- /dev/null

> +++ b/recipes-qt/qt5/qtbase/0014-mkspecs-common-gcc-base.conf-Use-I-instead-of-isyste.patch

> @@ -0,0 +1,36 @@

> +From 61c858474804fd772d612e6c5b4bb6df261d521a Mon Sep 17 00:00:00 2001

> +From: Khem Raj <raj.khem@gmail.com>

> +Date: Wed, 14 Feb 2018 17:08:43 -0800

> +Subject: [PATCH] mkspecs/common/gcc-base.conf: Use -I instead of -isystem

> +

> +-isystem fails to build when code uses include_next on certain files e.g.

> +

> +qtbase/5.10.0+gitAUTOINC+50117d738a-r0/recipe-sysroot/usr/include/c++/7.3.0/cstdlib:75:15: fatal error: stdlib.h: No such file or directory

> + #include_next <stdlib.h>

> +               ^~~~~~~~~~


I'm building qt 5.10.0 in master with gcc 7.3.0 in a no-x11 environment with 
eglfs and not seeing this issue. What else is different?


> +compilation terminated.

> +make[2]: *** [Makefile:11592: .obj/qgenericpluginfactory.o] Error 1

> +

> +Upstream-Status: Pending

> +

> +Signed-off-by: Khem Raj <raj.khem@gmail.com>

> +---

> + mkspecs/common/gcc-base.conf | 2 +-

> + 1 file changed, 1 insertion(+), 1 deletion(-)

> +

> +diff --git a/mkspecs/common/gcc-base.conf b/mkspecs/common/gcc-base.conf

> +index 234f71d495..ee3da023e6 100644

> +--- a/mkspecs/common/gcc-base.conf

> ++++ b/mkspecs/common/gcc-base.conf

> +@@ -46,7 +46,7 @@ QMAKE_CFLAGS_DEBUG         += -g

> + QMAKE_CFLAGS_SHLIB         += $$QMAKE_CFLAGS_PIC

> + QMAKE_CFLAGS_STATIC_LIB    += $$QMAKE_CFLAGS_PIC

> + QMAKE_CFLAGS_APP           += $$QMAKE_CFLAGS_PIC

> +-QMAKE_CFLAGS_ISYSTEM        = -isystem

> ++QMAKE_CFLAGS_ISYSTEM        = -I

> + QMAKE_CFLAGS_YACC          += -Wno-unused -Wno-parentheses

> + QMAKE_CFLAGS_HIDESYMS      += -fvisibility=hidden

> + QMAKE_CFLAGS_EXCEPTIONS_OFF += -fno-exceptions

> +-- 

> +2.16.1

> +

> diff --git a/recipes-qt/qt5/qtbase_git.bb b/recipes-qt/qt5/qtbase_git.bb

> index 4f3ade2..cc9bce3 100644

> --- a/recipes-qt/qt5/qtbase_git.bb

> +++ b/recipes-qt/qt5/qtbase_git.bb

> @@ -29,6 +29,7 @@ SRC_URI += "\

>      file://0009-Add-OE-specific-specs-for-clang-compiler.patch \

>      file://0010-linux-clang-Invert-conditional-for-defining-QT_SOCKL.patch \

>      file://0011-tst_qlocale-Enable-QT_USE_FENV-only-on-glibc.patch \

> +    file://0014-mkspecs-common-gcc-base.conf-Use-I-instead-of-isyste.patch \

>      file://run-ptest \

>  "

>  

> -- 

> 2.16.1

> 

> -- 

> _______________________________________________

> Openembedded-devel mailing list

> Openembedded-devel@lists.openembedded.org

> http://lists.openembedded.org/mailman/listinfo/openembedded-devel

-- 
_______________________________________________
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Khem Raj Feb. 15, 2018, 11:50 p.m. UTC | #2
On Thu, Feb 15, 2018 at 3:41 PM, Denys Dmytriyenko <denis@denix.org> wrote:
> On Wed, Feb 14, 2018 at 08:38:48PM -0800, Khem Raj wrote:

>> Fixes no-x11 builds (eglfs)

>>

>> Signed-off-by: Khem Raj <raj.khem@gmail.com>

>> ---

>>  recipes-qt/qt5/qtbase-native_git.bb                |  1 +

>>  ...mon-gcc-base.conf-Use-I-instead-of-isyste.patch | 36 ++++++++++++++++++++++

>>  recipes-qt/qt5/qtbase_git.bb                       |  1 +

>>  3 files changed, 38 insertions(+)

>>  create mode 100644 recipes-qt/qt5/qtbase/0014-mkspecs-common-gcc-base.conf-Use-I-instead-of-isyste.patch

>>

>> diff --git a/recipes-qt/qt5/qtbase-native_git.bb b/recipes-qt/qt5/qtbase-native_git.bb

>> index ac3924e..ffde8ee 100644

>> --- a/recipes-qt/qt5/qtbase-native_git.bb

>> +++ b/recipes-qt/qt5/qtbase-native_git.bb

>> @@ -34,6 +34,7 @@ SRC_URI += "\

>>      file://0009-Add-OE-specific-specs-for-clang-compiler.patch \

>>      file://0010-linux-clang-Invert-conditional-for-defining-QT_SOCKL.patch \

>>      file://0011-tst_qlocale-Enable-QT_USE_FENV-only-on-glibc.patch \

>> +    file://0014-mkspecs-common-gcc-base.conf-Use-I-instead-of-isyste.patch \

>>  "

>>

>>  # common for qtbase-native and nativesdk-qtbase

>> diff --git a/recipes-qt/qt5/qtbase/0014-mkspecs-common-gcc-base.conf-Use-I-instead-of-isyste.patch b/recipes-qt/qt5/qtbase/0014-mkspecs-common-gcc-base.conf-Use-I-instead-of-isyste.patch

>> new file mode 100644

>> index 0000000..44e9009

>> --- /dev/null

>> +++ b/recipes-qt/qt5/qtbase/0014-mkspecs-common-gcc-base.conf-Use-I-instead-of-isyste.patch

>> @@ -0,0 +1,36 @@

>> +From 61c858474804fd772d612e6c5b4bb6df261d521a Mon Sep 17 00:00:00 2001

>> +From: Khem Raj <raj.khem@gmail.com>

>> +Date: Wed, 14 Feb 2018 17:08:43 -0800

>> +Subject: [PATCH] mkspecs/common/gcc-base.conf: Use -I instead of -isystem

>> +

>> +-isystem fails to build when code uses include_next on certain files e.g.

>> +

>> +qtbase/5.10.0+gitAUTOINC+50117d738a-r0/recipe-sysroot/usr/include/c++/7.3.0/cstdlib:75:15: fatal error: stdlib.h: No such file or directory

>> + #include_next <stdlib.h>

>> +               ^~~~~~~~~~

>

> I'm building qt 5.10.0 in master with gcc 7.3.0 in a no-x11 environment with

> eglfs and not seeing this issue. What else is different?


DISTRO_FEATURES_remove = "x11"
DISTRO_FEATURES_remove = "wayland"
DISTRO_FEATURES_append = " directfb"

then in qtbase
PACKAGECONFIG_GL = "gles2"
PACKAGECONFIG_FONTS = "fontconfig"
PACKAGECONFIG_append = " libinput eglfs"
PACKAGECONFIG_remove = "tests"


>

>

>> +compilation terminated.

>> +make[2]: *** [Makefile:11592: .obj/qgenericpluginfactory.o] Error 1

>> +

>> +Upstream-Status: Pending

>> +

>> +Signed-off-by: Khem Raj <raj.khem@gmail.com>

>> +---

>> + mkspecs/common/gcc-base.conf | 2 +-

>> + 1 file changed, 1 insertion(+), 1 deletion(-)

>> +

>> +diff --git a/mkspecs/common/gcc-base.conf b/mkspecs/common/gcc-base.conf

>> +index 234f71d495..ee3da023e6 100644

>> +--- a/mkspecs/common/gcc-base.conf

>> ++++ b/mkspecs/common/gcc-base.conf

>> +@@ -46,7 +46,7 @@ QMAKE_CFLAGS_DEBUG         += -g

>> + QMAKE_CFLAGS_SHLIB         += $$QMAKE_CFLAGS_PIC

>> + QMAKE_CFLAGS_STATIC_LIB    += $$QMAKE_CFLAGS_PIC

>> + QMAKE_CFLAGS_APP           += $$QMAKE_CFLAGS_PIC

>> +-QMAKE_CFLAGS_ISYSTEM        = -isystem

>> ++QMAKE_CFLAGS_ISYSTEM        = -I

>> + QMAKE_CFLAGS_YACC          += -Wno-unused -Wno-parentheses

>> + QMAKE_CFLAGS_HIDESYMS      += -fvisibility=hidden

>> + QMAKE_CFLAGS_EXCEPTIONS_OFF += -fno-exceptions

>> +--

>> +2.16.1

>> +

>> diff --git a/recipes-qt/qt5/qtbase_git.bb b/recipes-qt/qt5/qtbase_git.bb

>> index 4f3ade2..cc9bce3 100644

>> --- a/recipes-qt/qt5/qtbase_git.bb

>> +++ b/recipes-qt/qt5/qtbase_git.bb

>> @@ -29,6 +29,7 @@ SRC_URI += "\

>>      file://0009-Add-OE-specific-specs-for-clang-compiler.patch \

>>      file://0010-linux-clang-Invert-conditional-for-defining-QT_SOCKL.patch \

>>      file://0011-tst_qlocale-Enable-QT_USE_FENV-only-on-glibc.patch \

>> +    file://0014-mkspecs-common-gcc-base.conf-Use-I-instead-of-isyste.patch \

>>      file://run-ptest \

>>  "

>>

>> --

>> 2.16.1

>>

>> --

>> _______________________________________________

>> Openembedded-devel mailing list

>> Openembedded-devel@lists.openembedded.org

>> http://lists.openembedded.org/mailman/listinfo/openembedded-devel

-- 
_______________________________________________
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Denys Dmytriyenko Feb. 16, 2018, 10:01 p.m. UTC | #3
On Thu, Feb 15, 2018 at 03:50:56PM -0800, Khem Raj wrote:
> On Thu, Feb 15, 2018 at 3:41 PM, Denys Dmytriyenko <denis@denix.org> wrote:

> > On Wed, Feb 14, 2018 at 08:38:48PM -0800, Khem Raj wrote:

> >> Fixes no-x11 builds (eglfs)

> >>

> >> Signed-off-by: Khem Raj <raj.khem@gmail.com>

> >> ---

> >>  recipes-qt/qt5/qtbase-native_git.bb                |  1 +

> >>  ...mon-gcc-base.conf-Use-I-instead-of-isyste.patch | 36 ++++++++++++++++++++++

> >>  recipes-qt/qt5/qtbase_git.bb                       |  1 +

> >>  3 files changed, 38 insertions(+)

> >>  create mode 100644 recipes-qt/qt5/qtbase/0014-mkspecs-common-gcc-base.conf-Use-I-instead-of-isyste.patch

> >>

> >> diff --git a/recipes-qt/qt5/qtbase-native_git.bb b/recipes-qt/qt5/qtbase-native_git.bb

> >> index ac3924e..ffde8ee 100644

> >> --- a/recipes-qt/qt5/qtbase-native_git.bb

> >> +++ b/recipes-qt/qt5/qtbase-native_git.bb

> >> @@ -34,6 +34,7 @@ SRC_URI += "\

> >>      file://0009-Add-OE-specific-specs-for-clang-compiler.patch \

> >>      file://0010-linux-clang-Invert-conditional-for-defining-QT_SOCKL.patch \

> >>      file://0011-tst_qlocale-Enable-QT_USE_FENV-only-on-glibc.patch \

> >> +    file://0014-mkspecs-common-gcc-base.conf-Use-I-instead-of-isyste.patch \

> >>  "

> >>

> >>  # common for qtbase-native and nativesdk-qtbase

> >> diff --git a/recipes-qt/qt5/qtbase/0014-mkspecs-common-gcc-base.conf-Use-I-instead-of-isyste.patch b/recipes-qt/qt5/qtbase/0014-mkspecs-common-gcc-base.conf-Use-I-instead-of-isyste.patch

> >> new file mode 100644

> >> index 0000000..44e9009

> >> --- /dev/null

> >> +++ b/recipes-qt/qt5/qtbase/0014-mkspecs-common-gcc-base.conf-Use-I-instead-of-isyste.patch

> >> @@ -0,0 +1,36 @@

> >> +From 61c858474804fd772d612e6c5b4bb6df261d521a Mon Sep 17 00:00:00 2001

> >> +From: Khem Raj <raj.khem@gmail.com>

> >> +Date: Wed, 14 Feb 2018 17:08:43 -0800

> >> +Subject: [PATCH] mkspecs/common/gcc-base.conf: Use -I instead of -isystem

> >> +

> >> +-isystem fails to build when code uses include_next on certain files e.g.

> >> +

> >> +qtbase/5.10.0+gitAUTOINC+50117d738a-r0/recipe-sysroot/usr/include/c++/7.3.0/cstdlib:75:15: fatal error: stdlib.h: No such file or directory

> >> + #include_next <stdlib.h>

> >> +               ^~~~~~~~~~

> >

> > I'm building qt 5.10.0 in master with gcc 7.3.0 in a no-x11 environment with

> > eglfs and not seeing this issue. What else is different?

> 

> DISTRO_FEATURES_remove = "x11"

> DISTRO_FEATURES_remove = "wayland"

> DISTRO_FEATURES_append = " directfb"

> 

> then in qtbase

> PACKAGECONFIG_GL = "gles2"

> PACKAGECONFIG_FONTS = "fontconfig"

> PACKAGECONFIG_append = " libinput eglfs"

> PACKAGECONFIG_remove = "tests"


Yeah, I had slightly different flags - no-x11, but wayland+kms.

After disabling wayland and enabling eglfs explicitly, I still don't see any 
issues building qtbase.

Anyone else see the problem?


> >> +compilation terminated.

> >> +make[2]: *** [Makefile:11592: .obj/qgenericpluginfactory.o] Error 1

> >> +

> >> +Upstream-Status: Pending

> >> +

> >> +Signed-off-by: Khem Raj <raj.khem@gmail.com>

> >> +---

> >> + mkspecs/common/gcc-base.conf | 2 +-

> >> + 1 file changed, 1 insertion(+), 1 deletion(-)

> >> +

> >> +diff --git a/mkspecs/common/gcc-base.conf b/mkspecs/common/gcc-base.conf

> >> +index 234f71d495..ee3da023e6 100644

> >> +--- a/mkspecs/common/gcc-base.conf

> >> ++++ b/mkspecs/common/gcc-base.conf

> >> +@@ -46,7 +46,7 @@ QMAKE_CFLAGS_DEBUG         += -g

> >> + QMAKE_CFLAGS_SHLIB         += $$QMAKE_CFLAGS_PIC

> >> + QMAKE_CFLAGS_STATIC_LIB    += $$QMAKE_CFLAGS_PIC

> >> + QMAKE_CFLAGS_APP           += $$QMAKE_CFLAGS_PIC

> >> +-QMAKE_CFLAGS_ISYSTEM        = -isystem

> >> ++QMAKE_CFLAGS_ISYSTEM        = -I

> >> + QMAKE_CFLAGS_YACC          += -Wno-unused -Wno-parentheses

> >> + QMAKE_CFLAGS_HIDESYMS      += -fvisibility=hidden

> >> + QMAKE_CFLAGS_EXCEPTIONS_OFF += -fno-exceptions

> >> +--

> >> +2.16.1

> >> +

> >> diff --git a/recipes-qt/qt5/qtbase_git.bb b/recipes-qt/qt5/qtbase_git.bb

> >> index 4f3ade2..cc9bce3 100644

> >> --- a/recipes-qt/qt5/qtbase_git.bb

> >> +++ b/recipes-qt/qt5/qtbase_git.bb

> >> @@ -29,6 +29,7 @@ SRC_URI += "\

> >>      file://0009-Add-OE-specific-specs-for-clang-compiler.patch \

> >>      file://0010-linux-clang-Invert-conditional-for-defining-QT_SOCKL.patch \

> >>      file://0011-tst_qlocale-Enable-QT_USE_FENV-only-on-glibc.patch \

> >> +    file://0014-mkspecs-common-gcc-base.conf-Use-I-instead-of-isyste.patch \

> >>      file://run-ptest \

> >>  "

> >>

> >> --

> >> 2.16.1

> >>

> >> --

> >> _______________________________________________

> >> Openembedded-devel mailing list

> >> Openembedded-devel@lists.openembedded.org

> >> http://lists.openembedded.org/mailman/listinfo/openembedded-devel

> 

-- 
_______________________________________________
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Khem Raj Feb. 16, 2018, 10:59 p.m. UTC | #4
I am using arch Linux for host distro and security flags enabled May be
that is something

On Fri, Feb 16, 2018 at 2:01 PM Denys Dmytriyenko <denis@denix.org> wrote:

> On Thu, Feb 15, 2018 at 03:50:56PM -0800, Khem Raj wrote:

> > On Thu, Feb 15, 2018 at 3:41 PM, Denys Dmytriyenko <denis@denix.org>

> wrote:

> > > On Wed, Feb 14, 2018 at 08:38:48PM -0800, Khem Raj wrote:

> > >> Fixes no-x11 builds (eglfs)

> > >>

> > >> Signed-off-by: Khem Raj <raj.khem@gmail.com>

> > >> ---

> > >>  recipes-qt/qt5/qtbase-native_git.bb                |  1 +

> > >>  ...mon-gcc-base.conf-Use-I-instead-of-isyste.patch | 36

> ++++++++++++++++++++++

> > >>  recipes-qt/qt5/qtbase_git.bb                       |  1 +

> > >>  3 files changed, 38 insertions(+)

> > >>  create mode 100644

> recipes-qt/qt5/qtbase/0014-mkspecs-common-gcc-base.conf-Use-I-instead-of-isyste.patch

> > >>

> > >> diff --git a/recipes-qt/qt5/qtbase-native_git.bb b/recipes-qt/qt5/

> qtbase-native_git.bb

> > >> index ac3924e..ffde8ee 100644

> > >> --- a/recipes-qt/qt5/qtbase-native_git.bb

> > >> +++ b/recipes-qt/qt5/qtbase-native_git.bb

> > >> @@ -34,6 +34,7 @@ SRC_URI += "\

> > >>      file://0009-Add-OE-specific-specs-for-clang-compiler.patch \

> > >>

> file://0010-linux-clang-Invert-conditional-for-defining-QT_SOCKL.patch \

> > >>      file://0011-tst_qlocale-Enable-QT_USE_FENV-only-on-glibc.patch \

> > >> +

> file://0014-mkspecs-common-gcc-base.conf-Use-I-instead-of-isyste.patch \

> > >>  "

> > >>

> > >>  # common for qtbase-native and nativesdk-qtbase

> > >> diff --git

> a/recipes-qt/qt5/qtbase/0014-mkspecs-common-gcc-base.conf-Use-I-instead-of-isyste.patch

> b/recipes-qt/qt5/qtbase/0014-mkspecs-common-gcc-base.conf-Use-I-instead-of-isyste.patch

> > >> new file mode 100644

> > >> index 0000000..44e9009

> > >> --- /dev/null

> > >> +++

> b/recipes-qt/qt5/qtbase/0014-mkspecs-common-gcc-base.conf-Use-I-instead-of-isyste.patch

> > >> @@ -0,0 +1,36 @@

> > >> +From 61c858474804fd772d612e6c5b4bb6df261d521a Mon Sep 17 00:00:00

> 2001

> > >> +From: Khem Raj <raj.khem@gmail.com>

> > >> +Date: Wed, 14 Feb 2018 17:08:43 -0800

> > >> +Subject: [PATCH] mkspecs/common/gcc-base.conf: Use -I instead of

> -isystem

> > >> +

> > >> +-isystem fails to build when code uses include_next on certain files

> e.g.

> > >> +

> > >>

> +qtbase/5.10.0+gitAUTOINC+50117d738a-r0/recipe-sysroot/usr/include/c++/7.3.0/cstdlib:75:15:

> fatal error: stdlib.h: No such file or directory

> > >> + #include_next <stdlib.h>

> > >> +               ^~~~~~~~~~

> > >

> > > I'm building qt 5.10.0 in master with gcc 7.3.0 in a no-x11

> environment with

> > > eglfs and not seeing this issue. What else is different?

> >

> > DISTRO_FEATURES_remove = "x11"

> > DISTRO_FEATURES_remove = "wayland"

> > DISTRO_FEATURES_append = " directfb"

> >

> > then in qtbase

> > PACKAGECONFIG_GL = "gles2"

> > PACKAGECONFIG_FONTS = "fontconfig"

> > PACKAGECONFIG_append = " libinput eglfs"

> > PACKAGECONFIG_remove = "tests"

>

> Yeah, I had slightly different flags - no-x11, but wayland+kms.

>

> After disabling wayland and enabling eglfs explicitly, I still don't see

> any

> issues building qtbase.

>

> Anyone else see the problem?

>

>

> > >> +compilation terminated.

> > >> +make[2]: *** [Makefile:11592: .obj/qgenericpluginfactory.o] Error 1

> > >> +

> > >> +Upstream-Status: Pending

> > >> +

> > >> +Signed-off-by: Khem Raj <raj.khem@gmail.com>

> > >> +---

> > >> + mkspecs/common/gcc-base.conf | 2 +-

> > >> + 1 file changed, 1 insertion(+), 1 deletion(-)

> > >> +

> > >> +diff --git a/mkspecs/common/gcc-base.conf

> b/mkspecs/common/gcc-base.conf

> > >> +index 234f71d495..ee3da023e6 100644

> > >> +--- a/mkspecs/common/gcc-base.conf

> > >> ++++ b/mkspecs/common/gcc-base.conf

> > >> +@@ -46,7 +46,7 @@ QMAKE_CFLAGS_DEBUG         += -g

> > >> + QMAKE_CFLAGS_SHLIB         += $$QMAKE_CFLAGS_PIC

> > >> + QMAKE_CFLAGS_STATIC_LIB    += $$QMAKE_CFLAGS_PIC

> > >> + QMAKE_CFLAGS_APP           += $$QMAKE_CFLAGS_PIC

> > >> +-QMAKE_CFLAGS_ISYSTEM        = -isystem

> > >> ++QMAKE_CFLAGS_ISYSTEM        = -I

> > >> + QMAKE_CFLAGS_YACC          += -Wno-unused -Wno-parentheses

> > >> + QMAKE_CFLAGS_HIDESYMS      += -fvisibility=hidden

> > >> + QMAKE_CFLAGS_EXCEPTIONS_OFF += -fno-exceptions

> > >> +--

> > >> +2.16.1

> > >> +

> > >> diff --git a/recipes-qt/qt5/qtbase_git.bb b/recipes-qt/qt5/

> qtbase_git.bb

> > >> index 4f3ade2..cc9bce3 100644

> > >> --- a/recipes-qt/qt5/qtbase_git.bb

> > >> +++ b/recipes-qt/qt5/qtbase_git.bb

> > >> @@ -29,6 +29,7 @@ SRC_URI += "\

> > >>      file://0009-Add-OE-specific-specs-for-clang-compiler.patch \

> > >>

> file://0010-linux-clang-Invert-conditional-for-defining-QT_SOCKL.patch \

> > >>      file://0011-tst_qlocale-Enable-QT_USE_FENV-only-on-glibc.patch \

> > >> +

> file://0014-mkspecs-common-gcc-base.conf-Use-I-instead-of-isyste.patch \

> > >>      file://run-ptest \

> > >>  "

> > >>

> > >> --

> > >> 2.16.1

> > >>

> > >> --

> > >> _______________________________________________

> > >> Openembedded-devel mailing list

> > >> Openembedded-devel@lists.openembedded.org

> > >> http://lists.openembedded.org/mailman/listinfo/openembedded-devel

> >

>

-- 
_______________________________________________
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Denys Dmytriyenko Feb. 16, 2018, 11:08 p.m. UTC | #5
On Fri, Feb 16, 2018 at 10:59:39PM +0000, Khem Raj wrote:
> I am using arch Linux for host distro and security flags enabled May be

> that is something


Could be... I'm on Ubuntu 16.04.


> On Fri, Feb 16, 2018 at 2:01 PM Denys Dmytriyenko <denis@denix.org> wrote:

> 

> > On Thu, Feb 15, 2018 at 03:50:56PM -0800, Khem Raj wrote:

> > > On Thu, Feb 15, 2018 at 3:41 PM, Denys Dmytriyenko <denis@denix.org>

> > wrote:

> > > > On Wed, Feb 14, 2018 at 08:38:48PM -0800, Khem Raj wrote:

> > > >> Fixes no-x11 builds (eglfs)

> > > >>

> > > >> Signed-off-by: Khem Raj <raj.khem@gmail.com>

> > > >> ---

> > > >>  recipes-qt/qt5/qtbase-native_git.bb                |  1 +

> > > >>  ...mon-gcc-base.conf-Use-I-instead-of-isyste.patch | 36

> > ++++++++++++++++++++++

> > > >>  recipes-qt/qt5/qtbase_git.bb                       |  1 +

> > > >>  3 files changed, 38 insertions(+)

> > > >>  create mode 100644

> > recipes-qt/qt5/qtbase/0014-mkspecs-common-gcc-base.conf-Use-I-instead-of-isyste.patch

> > > >>

> > > >> diff --git a/recipes-qt/qt5/qtbase-native_git.bb b/recipes-qt/qt5/

> > qtbase-native_git.bb

> > > >> index ac3924e..ffde8ee 100644

> > > >> --- a/recipes-qt/qt5/qtbase-native_git.bb

> > > >> +++ b/recipes-qt/qt5/qtbase-native_git.bb

> > > >> @@ -34,6 +34,7 @@ SRC_URI += "\

> > > >>      file://0009-Add-OE-specific-specs-for-clang-compiler.patch \

> > > >>

> > file://0010-linux-clang-Invert-conditional-for-defining-QT_SOCKL.patch \

> > > >>      file://0011-tst_qlocale-Enable-QT_USE_FENV-only-on-glibc.patch \

> > > >> +

> > file://0014-mkspecs-common-gcc-base.conf-Use-I-instead-of-isyste.patch \

> > > >>  "

> > > >>

> > > >>  # common for qtbase-native and nativesdk-qtbase

> > > >> diff --git

> > a/recipes-qt/qt5/qtbase/0014-mkspecs-common-gcc-base.conf-Use-I-instead-of-isyste.patch

> > b/recipes-qt/qt5/qtbase/0014-mkspecs-common-gcc-base.conf-Use-I-instead-of-isyste.patch

> > > >> new file mode 100644

> > > >> index 0000000..44e9009

> > > >> --- /dev/null

> > > >> +++

> > b/recipes-qt/qt5/qtbase/0014-mkspecs-common-gcc-base.conf-Use-I-instead-of-isyste.patch

> > > >> @@ -0,0 +1,36 @@

> > > >> +From 61c858474804fd772d612e6c5b4bb6df261d521a Mon Sep 17 00:00:00

> > 2001

> > > >> +From: Khem Raj <raj.khem@gmail.com>

> > > >> +Date: Wed, 14 Feb 2018 17:08:43 -0800

> > > >> +Subject: [PATCH] mkspecs/common/gcc-base.conf: Use -I instead of

> > -isystem

> > > >> +

> > > >> +-isystem fails to build when code uses include_next on certain files

> > e.g.

> > > >> +

> > > >>

> > +qtbase/5.10.0+gitAUTOINC+50117d738a-r0/recipe-sysroot/usr/include/c++/7.3.0/cstdlib:75:15:

> > fatal error: stdlib.h: No such file or directory

> > > >> + #include_next <stdlib.h>

> > > >> +               ^~~~~~~~~~

> > > >

> > > > I'm building qt 5.10.0 in master with gcc 7.3.0 in a no-x11

> > environment with

> > > > eglfs and not seeing this issue. What else is different?

> > >

> > > DISTRO_FEATURES_remove = "x11"

> > > DISTRO_FEATURES_remove = "wayland"

> > > DISTRO_FEATURES_append = " directfb"

> > >

> > > then in qtbase

> > > PACKAGECONFIG_GL = "gles2"

> > > PACKAGECONFIG_FONTS = "fontconfig"

> > > PACKAGECONFIG_append = " libinput eglfs"

> > > PACKAGECONFIG_remove = "tests"

> >

> > Yeah, I had slightly different flags - no-x11, but wayland+kms.

> >

> > After disabling wayland and enabling eglfs explicitly, I still don't see

> > any

> > issues building qtbase.

> >

> > Anyone else see the problem?

> >

> >

> > > >> +compilation terminated.

> > > >> +make[2]: *** [Makefile:11592: .obj/qgenericpluginfactory.o] Error 1

> > > >> +

> > > >> +Upstream-Status: Pending

> > > >> +

> > > >> +Signed-off-by: Khem Raj <raj.khem@gmail.com>

> > > >> +---

> > > >> + mkspecs/common/gcc-base.conf | 2 +-

> > > >> + 1 file changed, 1 insertion(+), 1 deletion(-)

> > > >> +

> > > >> +diff --git a/mkspecs/common/gcc-base.conf

> > b/mkspecs/common/gcc-base.conf

> > > >> +index 234f71d495..ee3da023e6 100644

> > > >> +--- a/mkspecs/common/gcc-base.conf

> > > >> ++++ b/mkspecs/common/gcc-base.conf

> > > >> +@@ -46,7 +46,7 @@ QMAKE_CFLAGS_DEBUG         += -g

> > > >> + QMAKE_CFLAGS_SHLIB         += $$QMAKE_CFLAGS_PIC

> > > >> + QMAKE_CFLAGS_STATIC_LIB    += $$QMAKE_CFLAGS_PIC

> > > >> + QMAKE_CFLAGS_APP           += $$QMAKE_CFLAGS_PIC

> > > >> +-QMAKE_CFLAGS_ISYSTEM        = -isystem

> > > >> ++QMAKE_CFLAGS_ISYSTEM        = -I

> > > >> + QMAKE_CFLAGS_YACC          += -Wno-unused -Wno-parentheses

> > > >> + QMAKE_CFLAGS_HIDESYMS      += -fvisibility=hidden

> > > >> + QMAKE_CFLAGS_EXCEPTIONS_OFF += -fno-exceptions

> > > >> +--

> > > >> +2.16.1

> > > >> +

> > > >> diff --git a/recipes-qt/qt5/qtbase_git.bb b/recipes-qt/qt5/

> > qtbase_git.bb

> > > >> index 4f3ade2..cc9bce3 100644

> > > >> --- a/recipes-qt/qt5/qtbase_git.bb

> > > >> +++ b/recipes-qt/qt5/qtbase_git.bb

> > > >> @@ -29,6 +29,7 @@ SRC_URI += "\

> > > >>      file://0009-Add-OE-specific-specs-for-clang-compiler.patch \

> > > >>

> > file://0010-linux-clang-Invert-conditional-for-defining-QT_SOCKL.patch \

> > > >>      file://0011-tst_qlocale-Enable-QT_USE_FENV-only-on-glibc.patch \

> > > >> +

> > file://0014-mkspecs-common-gcc-base.conf-Use-I-instead-of-isyste.patch \

> > > >>      file://run-ptest \

> > > >>  "

> > > >>

> > > >> --

> > > >> 2.16.1

> > > >>

> > > >> --

> > > >> _______________________________________________

> > > >> Openembedded-devel mailing list

> > > >> Openembedded-devel@lists.openembedded.org

> > > >> http://lists.openembedded.org/mailman/listinfo/openembedded-devel

> > >

> >

-- 
_______________________________________________
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Khem Raj Feb. 17, 2018, 2:35 a.m. UTC | #6
On Fri, Feb 16, 2018 at 3:08 PM, Denys Dmytriyenko <denis@denix.org> wrote:
> On Fri, Feb 16, 2018 at 10:59:39PM +0000, Khem Raj wrote:

>> I am using arch Linux for host distro and security flags enabled May be

>> that is something

>

> Could be... I'm on Ubuntu 16.04.


maybe you can try to enable security flags and see if you see it
-- 
_______________________________________________
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Khem Raj Feb. 21, 2018, 6:20 a.m. UTC | #7
i can still see it with 5.10.1

                 from
/mnt/a/zonit/oe-build/build/tmp/work/aarch64-bec-linux/qtbase/5.10.1+gitAUTOINC+6c6ace9d23-r0/git/src/gui/kernel/qgenericpluginfactory.cpp:40:
/mnt/a/zonit/oe-build/build/tmp/work/aarch64-bec-linux/qtbase/5.10.1+gitAUTOINC+6c6ace9d23-r0/recipe-sysroot/usr/include/c++/7.3.0/cstdlib:75:15:
fatal error: stdlib.h: No such file or directory
 #include_next <stdlib.h>
               ^~~~~~~~~~
compilation terminated.
make[2]: *** [Makefile:11592: .obj/qgenericpluginfactory.o] Error 1
make[2]: Leaving directory
'/mnt/a/zonit/oe-build/build/tmp/work/aarch64-bec-linux/qtbase/5.10.1+gitAUTOINC+6c6ace9d23-r0/build/src/gui'

On Fri, Feb 16, 2018 at 6:35 PM, Khem Raj <raj.khem@gmail.com> wrote:
> On Fri, Feb 16, 2018 at 3:08 PM, Denys Dmytriyenko <denis@denix.org> wrote:

>> On Fri, Feb 16, 2018 at 10:59:39PM +0000, Khem Raj wrote:

>>> I am using arch Linux for host distro and security flags enabled May be

>>> that is something

>>

>> Could be... I'm on Ubuntu 16.04.

>

> maybe you can try to enable security flags and see if you see it

-- 
_______________________________________________
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Denys Dmytriyenko Feb. 21, 2018, 7:55 p.m. UTC | #8
On Tue, Feb 20, 2018 at 10:20:03PM -0800, Khem Raj wrote:
> i can still see it with 5.10.1

> 

>                  from

> /mnt/a/zonit/oe-build/build/tmp/work/aarch64-bec-linux/qtbase/5.10.1+gitAUTOINC+6c6ace9d23-r0/git/src/gui/kernel/qgenericpluginfactory.cpp:40:

> /mnt/a/zonit/oe-build/build/tmp/work/aarch64-bec-linux/qtbase/5.10.1+gitAUTOINC+6c6ace9d23-r0/recipe-sysroot/usr/include/c++/7.3.0/cstdlib:75:15:

> fatal error: stdlib.h: No such file or directory

>  #include_next <stdlib.h>

>                ^~~~~~~~~~

> compilation terminated.

> make[2]: *** [Makefile:11592: .obj/qgenericpluginfactory.o] Error 1

> make[2]: Leaving directory

> '/mnt/a/zonit/oe-build/build/tmp/work/aarch64-bec-linux/qtbase/5.10.1+gitAUTOINC+6c6ace9d23-r0/build/src/gui'

> 

> On Fri, Feb 16, 2018 at 6:35 PM, Khem Raj <raj.khem@gmail.com> wrote:

> > On Fri, Feb 16, 2018 at 3:08 PM, Denys Dmytriyenko <denis@denix.org> wrote:

> >> On Fri, Feb 16, 2018 at 10:59:39PM +0000, Khem Raj wrote:

> >>> I am using arch Linux for host distro and security flags enabled May be

> >>> that is something

> >>

> >> Could be... I'm on Ubuntu 16.04.

> >

> > maybe you can try to enable security flags and see if you see it


Do you have any specifics regarding enabling security flags?
-- 
_______________________________________________
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Khem Raj Feb. 21, 2018, 8:15 p.m. UTC | #9
On 2/21/18 11:55 AM, Denys Dmytriyenko wrote:
> On Tue, Feb 20, 2018 at 10:20:03PM -0800, Khem Raj wrote:

>> i can still see it with 5.10.1

>>

>>                  from

>> /mnt/a/zonit/oe-build/build/tmp/work/aarch64-bec-linux/qtbase/5.10.1+gitAUTOINC+6c6ace9d23-r0/git/src/gui/kernel/qgenericpluginfactory.cpp:40:

>> /mnt/a/zonit/oe-build/build/tmp/work/aarch64-bec-linux/qtbase/5.10.1+gitAUTOINC+6c6ace9d23-r0/recipe-sysroot/usr/include/c++/7.3.0/cstdlib:75:15:

>> fatal error: stdlib.h: No such file or directory

>>  #include_next <stdlib.h>

>>                ^~~~~~~~~~

>> compilation terminated.

>> make[2]: *** [Makefile:11592: .obj/qgenericpluginfactory.o] Error 1

>> make[2]: Leaving directory

>> '/mnt/a/zonit/oe-build/build/tmp/work/aarch64-bec-linux/qtbase/5.10.1+gitAUTOINC+6c6ace9d23-r0/build/src/gui'

>>

>> On Fri, Feb 16, 2018 at 6:35 PM, Khem Raj <raj.khem@gmail.com> wrote:

>>> On Fri, Feb 16, 2018 at 3:08 PM, Denys Dmytriyenko <denis@denix.org> wrote:

>>>> On Fri, Feb 16, 2018 at 10:59:39PM +0000, Khem Raj wrote:

>>>>> I am using arch Linux for host distro and security flags enabled May be

>>>>> that is something

>>>>

>>>> Could be... I'm on Ubuntu 16.04.

>>>

>>> maybe you can try to enable security flags and see if you see it

> 

> Do you have any specifics regarding enabling security flags?

> 


add

require conf/distro/include/security_flags.inc

in local.conf
-- 
_______________________________________________
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Denys Dmytriyenko Feb. 24, 2018, 4:40 a.m. UTC | #10
On Wed, Feb 21, 2018 at 12:15:39PM -0800, Khem Raj wrote:
> On 2/21/18 11:55 AM, Denys Dmytriyenko wrote:

> > On Tue, Feb 20, 2018 at 10:20:03PM -0800, Khem Raj wrote:

> >> i can still see it with 5.10.1

> >>

> >>                  from

> >> /mnt/a/zonit/oe-build/build/tmp/work/aarch64-bec-linux/qtbase/5.10.1+gitAUTOINC+6c6ace9d23-r0/git/src/gui/kernel/qgenericpluginfactory.cpp:40:

> >> /mnt/a/zonit/oe-build/build/tmp/work/aarch64-bec-linux/qtbase/5.10.1+gitAUTOINC+6c6ace9d23-r0/recipe-sysroot/usr/include/c++/7.3.0/cstdlib:75:15:

> >> fatal error: stdlib.h: No such file or directory

> >>  #include_next <stdlib.h>

> >>                ^~~~~~~~~~

> >> compilation terminated.

> >> make[2]: *** [Makefile:11592: .obj/qgenericpluginfactory.o] Error 1

> >> make[2]: Leaving directory

> >> '/mnt/a/zonit/oe-build/build/tmp/work/aarch64-bec-linux/qtbase/5.10.1+gitAUTOINC+6c6ace9d23-r0/build/src/gui'

> >>

> >> On Fri, Feb 16, 2018 at 6:35 PM, Khem Raj <raj.khem@gmail.com> wrote:

> >>> On Fri, Feb 16, 2018 at 3:08 PM, Denys Dmytriyenko <denis@denix.org> wrote:

> >>>> On Fri, Feb 16, 2018 at 10:59:39PM +0000, Khem Raj wrote:

> >>>>> I am using arch Linux for host distro and security flags enabled May be

> >>>>> that is something

> >>>>

> >>>> Could be... I'm on Ubuntu 16.04.

> >>>

> >>> maybe you can try to enable security flags and see if you see it

> > 

> > Do you have any specifics regarding enabling security flags?

> > 

> 

> add

> 

> require conf/distro/include/security_flags.inc

> 

> in local.conf


Ha, got confused - thought you were talking about security (SELinux?) on the 
host...

Anyway, got some time to try it with security_flags.inc included and it still 
builds fine here on latest master.

-- 
Denys
-- 
_______________________________________________
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel
diff mbox series

Patch

diff --git a/recipes-qt/qt5/qtbase-native_git.bb b/recipes-qt/qt5/qtbase-native_git.bb
index ac3924e..ffde8ee 100644
--- a/recipes-qt/qt5/qtbase-native_git.bb
+++ b/recipes-qt/qt5/qtbase-native_git.bb
@@ -34,6 +34,7 @@  SRC_URI += "\
     file://0009-Add-OE-specific-specs-for-clang-compiler.patch \
     file://0010-linux-clang-Invert-conditional-for-defining-QT_SOCKL.patch \
     file://0011-tst_qlocale-Enable-QT_USE_FENV-only-on-glibc.patch \
+    file://0014-mkspecs-common-gcc-base.conf-Use-I-instead-of-isyste.patch \
 "
 
 # common for qtbase-native and nativesdk-qtbase
diff --git a/recipes-qt/qt5/qtbase/0014-mkspecs-common-gcc-base.conf-Use-I-instead-of-isyste.patch b/recipes-qt/qt5/qtbase/0014-mkspecs-common-gcc-base.conf-Use-I-instead-of-isyste.patch
new file mode 100644
index 0000000..44e9009
--- /dev/null
+++ b/recipes-qt/qt5/qtbase/0014-mkspecs-common-gcc-base.conf-Use-I-instead-of-isyste.patch
@@ -0,0 +1,36 @@ 
+From 61c858474804fd772d612e6c5b4bb6df261d521a Mon Sep 17 00:00:00 2001
+From: Khem Raj <raj.khem@gmail.com>
+Date: Wed, 14 Feb 2018 17:08:43 -0800
+Subject: [PATCH] mkspecs/common/gcc-base.conf: Use -I instead of -isystem
+
+-isystem fails to build when code uses include_next on certain files e.g.
+
+qtbase/5.10.0+gitAUTOINC+50117d738a-r0/recipe-sysroot/usr/include/c++/7.3.0/cstdlib:75:15: fatal error: stdlib.h: No such file or directory
+ #include_next <stdlib.h>
+               ^~~~~~~~~~
+compilation terminated.
+make[2]: *** [Makefile:11592: .obj/qgenericpluginfactory.o] Error 1
+
+Upstream-Status: Pending
+
+Signed-off-by: Khem Raj <raj.khem@gmail.com>
+---
+ mkspecs/common/gcc-base.conf | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/mkspecs/common/gcc-base.conf b/mkspecs/common/gcc-base.conf
+index 234f71d495..ee3da023e6 100644
+--- a/mkspecs/common/gcc-base.conf
++++ b/mkspecs/common/gcc-base.conf
+@@ -46,7 +46,7 @@ QMAKE_CFLAGS_DEBUG         += -g
+ QMAKE_CFLAGS_SHLIB         += $$QMAKE_CFLAGS_PIC
+ QMAKE_CFLAGS_STATIC_LIB    += $$QMAKE_CFLAGS_PIC
+ QMAKE_CFLAGS_APP           += $$QMAKE_CFLAGS_PIC
+-QMAKE_CFLAGS_ISYSTEM        = -isystem
++QMAKE_CFLAGS_ISYSTEM        = -I
+ QMAKE_CFLAGS_YACC          += -Wno-unused -Wno-parentheses
+ QMAKE_CFLAGS_HIDESYMS      += -fvisibility=hidden
+ QMAKE_CFLAGS_EXCEPTIONS_OFF += -fno-exceptions
+-- 
+2.16.1
+
diff --git a/recipes-qt/qt5/qtbase_git.bb b/recipes-qt/qt5/qtbase_git.bb
index 4f3ade2..cc9bce3 100644
--- a/recipes-qt/qt5/qtbase_git.bb
+++ b/recipes-qt/qt5/qtbase_git.bb
@@ -29,6 +29,7 @@  SRC_URI += "\
     file://0009-Add-OE-specific-specs-for-clang-compiler.patch \
     file://0010-linux-clang-Invert-conditional-for-defining-QT_SOCKL.patch \
     file://0011-tst_qlocale-Enable-QT_USE_FENV-only-on-glibc.patch \
+    file://0014-mkspecs-common-gcc-base.conf-Use-I-instead-of-isyste.patch \
     file://run-ptest \
 "