From patchwork Fri Feb 16 11:25:03 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jyri Sarha X-Patchwork-Id: 128546 Delivered-To: patch@linaro.org Received: by 10.46.124.24 with SMTP id x24csp453857ljc; Fri, 16 Feb 2018 03:25:56 -0800 (PST) X-Google-Smtp-Source: AH8x227a8+qqyEEtUC4j8Kbx7e2XcOItyPtObdyR8vU/x6oLZ3LyghLEmgiCpskPHoq3YvAZrbUD X-Received: by 10.98.238.2 with SMTP id e2mr5876337pfi.206.1518780356268; Fri, 16 Feb 2018 03:25:56 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1518780356; cv=none; d=google.com; s=arc-20160816; b=VKOUAWKobiFkJfPUqlH/PE/kC+ffLF7U8i3jBF3JAxdzfD+bI64cmnkXBCXTAw9GBH 5E2PHFbXUC9BQ9g1mfTc2kWIEwy76Djo+568svgDMWPBr/B3DVHDNsRJbSGRbzZ6MQf/ lPsknO8ZUiuaPM/1f/UZAljdPpg8vL7RXCIxx2f199VbYCf9IV+CaIcfYpabZaZ9to/f eky1bOboq5ltdh9W3fiXzGWV5fJFT8r6DPHV34ECIoWlwLfmpncZ8VOCHzhsoOs/xIqS c0ZjuleU1oTr4aYOh+FRs3nLOZ97SQ8Ap6NT4/0PBVLcD1Z1E0FhBegtVpIPpUV7g7YY Lg0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to :arc-authentication-results; bh=powthYI4cCjqZFhJGPVZje/85jIccfWttcdhVBc5yVI=; b=ClD1ahIP+VAlDOF+pmw2Pkjs2MOWUFRTrTNPc/ax4mvWafASfdIuYebJXJvQir2YPu 2+kOSd/u6wIJXp43TxBPly9pJ1BhsJgxzwglJfmxW/X/X5LngZ/U1/lL4iHc1Z1S9YVi CCcxHh5WqTOmzC15i2zEYAAMtTy+MYb3tTr1O5VhRbwcfh5zS6KvfyphPN8HTof0O1j3 oI35ieIpCnuGjum6Wz6mMxeBgt097xexoNCULPMIiUtfsoTzgf6bhEkGL7/I+2VCK9Io DY9JmKhFbspuD19Cyt5o0V6r9khRstg9QXv6lMFp5UxOZ1AD8kK/1jzBUWkhuldpO66P 3m6g== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@ti.com header.s=ti-com-17Q1 header.b=SxF8maea; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [131.252.210.177]) by mx.google.com with ESMTPS id j15si84260pfn.111.2018.02.16.03.25.56 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 16 Feb 2018 03:25:56 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) client-ip=131.252.210.177; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@ti.com header.s=ti-com-17Q1 header.b=SxF8maea; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E10AE6E610; Fri, 16 Feb 2018 11:25:22 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from fllnx209.ext.ti.com (fllnx209.ext.ti.com [198.47.19.16]) by gabe.freedesktop.org (Postfix) with ESMTPS id BE1DF6E014 for ; Fri, 16 Feb 2018 11:25:19 +0000 (UTC) Received: from dflxv15.itg.ti.com ([128.247.5.124]) by fllnx209.ext.ti.com (8.15.1/8.15.1) with ESMTP id w1GBPHb8009115; Fri, 16 Feb 2018 05:25:17 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ti.com; s=ti-com-17Q1; t=1518780317; bh=Uw9tptZCYHPARLR92RdBgXXvx5WH+1cjx5Pff2PyuVM=; h=From:To:CC:Subject:Date:In-Reply-To:References; b=SxF8maeaiDwY6OXl/vReZNE6E1H045LScL5Pdmyx8ulpuiMjy/8zBxFTUcmGUT+HM pMCA4ENDuCIl0k+2aI0d6srXOK/3ZP29DQ91XgLqniUQRNAA+iKwLezjq/pEMKMBKh XYJo3ZFrHUzfNto0Mt9V1u2/4FlsqQ41GEeLk6Uw= Received: from DLEE115.ent.ti.com (dlee115.ent.ti.com [157.170.170.26]) by dflxv15.itg.ti.com (8.14.3/8.13.8) with ESMTP id w1GBPHNJ003459; Fri, 16 Feb 2018 05:25:17 -0600 Received: from DLEE101.ent.ti.com (157.170.170.31) by DLEE115.ent.ti.com (157.170.170.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1261.35; Fri, 16 Feb 2018 05:25:17 -0600 Received: from dflp32.itg.ti.com (10.64.6.15) by DLEE101.ent.ti.com (157.170.170.31) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.1261.35 via Frontend Transport; Fri, 16 Feb 2018 05:25:17 -0600 Received: from jadmar.ti.com (ileax41-snat.itg.ti.com [10.172.224.153]) by dflp32.itg.ti.com (8.14.3/8.13.8) with ESMTP id w1GBPCie028841; Fri, 16 Feb 2018 05:25:16 -0600 From: Jyri Sarha To: , , Subject: [PATCH RFC 2/9] drm/omap: Fail probe if irq registration fails Date: Fri, 16 Feb 2018 13:25:03 +0200 Message-ID: <9b81b22145e303cb33df02b6770e295c7418bad2.1518780268.git.jsarha@ti.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: References: MIME-Version: 1.0 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jyri Sarha Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Call to omap_drm_irq_install() may fail with an error code. In such a case the driver probe should fail. Signed-off-by: Jyri Sarha Reviewed-by: Tomi Valkeinen Reviewed-by: Laurent Pinchart --- drivers/gpu/drm/omapdrm/omap_drv.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/omapdrm/omap_drv.c b/drivers/gpu/drm/omapdrm/omap_drv.c index 65a567d..979bede 100644 --- a/drivers/gpu/drm/omapdrm/omap_drv.c +++ b/drivers/gpu/drm/omapdrm/omap_drv.c @@ -321,7 +321,9 @@ static int omap_modeset_init(struct drm_device *dev) drm_mode_config_reset(dev); - omap_drm_irq_install(dev); + ret = omap_drm_irq_install(dev); + if (ret) + return ret; return 0; }