From patchwork Thu Nov 15 07:02:27 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zhang Rui X-Patchwork-Id: 12858 Return-Path: X-Original-To: patchwork@peony.canonical.com Delivered-To: patchwork@peony.canonical.com Received: from fiordland.canonical.com (fiordland.canonical.com [91.189.94.145]) by peony.canonical.com (Postfix) with ESMTP id B070523E12 for ; Thu, 15 Nov 2012 07:02:32 +0000 (UTC) Received: from mail-ia0-f180.google.com (mail-ia0-f180.google.com [209.85.210.180]) by fiordland.canonical.com (Postfix) with ESMTP id 6F630A190FC for ; Thu, 15 Nov 2012 07:02:32 +0000 (UTC) Received: by mail-ia0-f180.google.com with SMTP id f6so814065iag.11 for ; Wed, 14 Nov 2012 23:02:32 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-forwarded-to:x-forwarded-for:delivered-to:received-spf:x-extloop1 :x-ironport-av:message-id:subject:from:to:cc:date:content-type :x-mailer:content-transfer-encoding:mime-version:x-gm-message-state; bh=7rDpPv9OJl22bdBB4+9oj1qK7mXI03brLBxAwY+vhcg=; b=XnlwKe24rvV7ejGVXzwwG6FGXzfRLN0F75E9Kujej78gJzTfhf0DvVFEC9NPOC8wtH cE6vkpgeXmORz+wlVQpQ2o8wvPXW6uuzbTBG0diWMUb5Qjy0o19f85panGQlE+QBLShG D5yW5iygqMbGvgQH10DQ4+kN1nwPu5sU0aNLJAx8/96SL0lNfonf2Hi9MZ52z0mtPvX7 TZff9S2AvX8pjAMyh6oZjK83zHSN7F8l2E9u9OSkRqGu2lfPDFlQG+OeAK715AEK94ew sCD3GDXZfK+zye6Y48wSkW3axXlQ/kCBvt0pHCfTW6N1zUN1NHWsM08oK5ppvjjofCIu rnuQ== Received: by 10.50.213.34 with SMTP id np2mr130137igc.57.1352962952210; Wed, 14 Nov 2012 23:02:32 -0800 (PST) X-Forwarded-To: linaro-patchwork@canonical.com X-Forwarded-For: patch@linaro.org linaro-patchwork@canonical.com Delivered-To: patches@linaro.org Received: by 10.50.67.148 with SMTP id n20csp783102igt; Wed, 14 Nov 2012 23:02:31 -0800 (PST) Received: by 10.68.245.37 with SMTP id xl5mr1780844pbc.120.1352962951649; Wed, 14 Nov 2012 23:02:31 -0800 (PST) Received: from mga11.intel.com (mga11.intel.com. [192.55.52.93]) by mx.google.com with ESMTP id az5si21368799pbd.144.2012.11.14.23.02.30; Wed, 14 Nov 2012 23:02:31 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of rui.zhang@intel.com designates 192.55.52.93 as permitted sender) client-ip=192.55.52.93; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of rui.zhang@intel.com designates 192.55.52.93 as permitted sender) smtp.mail=rui.zhang@intel.com Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP; 14 Nov 2012 23:02:30 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.83,254,1352102400"; d="scan'208";a="247313172" Received: from unknown (HELO [10.255.21.124]) ([10.255.21.124]) by fmsmga001.fm.intel.com with ESMTP; 14 Nov 2012 23:02:28 -0800 Message-ID: <1352962947.2080.10.camel@rzhang1-mobl4> Subject: [RFC PATCH 2/2] Thermal: Exynos : add missing dependency From: Zhang Rui To: Linux PM list Cc: Sachin Kamat , Amit Kachhap , "Zhang, Rui" , patches@linaro.org Date: Thu, 15 Nov 2012 15:02:27 +0800 X-Mailer: Evolution 3.2.3-0ubuntu6 Mime-Version: 1.0 X-Gm-Message-State: ALoCoQkwqJLDf578O2/xpHhQcl144aKRauDFd2MStOidmkNeQG7Jy9/GDyT8erbCcuR2r8rfLdiU there is still something unclear to me. Amit, the next step should be remove this "depends on CPU_THERMAL" line for EXYNOS driver, right? If we do this, the exynos driver should work w/ or w/o CPU_THERMAL, but should we have something like, "hey, I like CPU_THERMAL, I work better with it set"? "Select" does not work here because it may block exynos driver when CPU_FREQ cleared. any ideas on this? thanks, rui CPU_FREQ_TABLE depends on CPU_FREQ. Selecting CPU_FREQ_TABLE without checking for dependencies gives the following compilation warnings: warning: (ARCH_TEGRA_2x_SOC && ARCH_TEGRA_3x_SOC && UX500_SOC_DB8500 && CPU_THERMAL && EXYNOS_THERMAL) selects CPU_FREQ_TABLE which has unmet direct dependencies (ARCH_HAS_CPUFREQ && CPU_FREQ) Patch-based-on: Sachin Kamat Signed-off-by: Zhang Rui --- drivers/thermal/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig index 937a23d..99b6587 100644 --- a/drivers/thermal/Kconfig +++ b/drivers/thermal/Kconfig @@ -96,7 +96,7 @@ config RCAR_THERMAL config EXYNOS_THERMAL tristate "Temperature sensor on Samsung EXYNOS" depends on (ARCH_EXYNOS4 || ARCH_EXYNOS5) - select CPU_FREQ_TABLE + depends on CPU_THERMAL help If you say yes here you get support for TMU (Thermal Managment Unit) on SAMSUNG EXYNOS series of SoC.