From patchwork Sat Feb 17 20:31:32 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 128755 Delivered-To: patch@linaro.org Received: by 10.46.124.24 with SMTP id x24csp1903853ljc; Sat, 17 Feb 2018 12:43:15 -0800 (PST) X-Google-Smtp-Source: AH8x226SXY/dyYd92xonQM5hiO5i4DvK6bMy+odsPaumyQ9BfiufwdXyf8UsY1Hcan1sn0BvqVXi X-Received: by 10.37.5.150 with SMTP id 144mr7498232ybf.119.1518900195442; Sat, 17 Feb 2018 12:43:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1518900195; cv=none; d=google.com; s=arc-20160816; b=M/T/jdG5fb21x5d+ySDISlUG1oFSGPZauylOuz9MomI4ZZYYDekn2IzalgyQnFm2pq OOcFT3ze8Z1lA63nFAYNJTWkLcbcGPY5ZbCfuNbjRVMXiYuIHya0jvjAGUxQlfmKY2bp gL7k94yg/c9zZvvYxZA/ufzFajYx+8PA+i+S/1iVz5UarHhCwvnrio0v7xVVkAsxBRKK b+vVgSd8m+RtWyTlTaoRohVp8MzEi6uY3mdv2Sy75qlxmNdla7Uv7/FR/tmGFbh9WkWu dlkinEWLyCovOzG3tuCC5q3UZFfoVIcpjBciMbThUnDgamDNbuLzpZ8sV3fNRAjbPPq1 6XNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:references:in-reply-to :message-id:date:to:from:dkim-signature:arc-authentication-results; bh=kDEHzy+WQxgp3ia3Fq5eY81Ya/41+t13dWHrw4i4lLo=; b=Fk1Y/MEgk3kMRnbJPZQrY+nHbOT1RwnWic7I0vSHpBThlVsvf+BM6Kkm/ZT62RJfIe d6WyZR9DioO2xpU56U/cO537WOkb/Ssqop7fQd+91AuSz0a5T44PuBz0n9yo7Q+AUgyj YxgunHlHmVcTF1aP+oDfD5wOXYuW4So8ypEZPNPsp8HPg3Y43W/GpcOINIKShYsJUp+5 fOD7mQqvANF8J8fQfk8QO9tz2eAhMp9gmq0GYBqB1O8xRDdbjf9tY54LXVZnAVC3JbaG eTtB6YOovoMiR6iLXXHKX05ZpqOWXnv1ZxZ9ug9/B8ZKw2ZniRN8fx9wd9R5nHJOuczt s4Jw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=JwTlgXON; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id u141si537856ywf.490.2018.02.17.12.43.15 for (version=TLS1 cipher=AES128-SHA bits=128/128); Sat, 17 Feb 2018 12:43:15 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=JwTlgXON; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:60465 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1en9KE-0001cc-MY for patch@linaro.org; Sat, 17 Feb 2018 15:43:14 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42078) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1en99X-0000Pb-4w for qemu-devel@nongnu.org; Sat, 17 Feb 2018 15:32:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1en99W-0000se-7p for qemu-devel@nongnu.org; Sat, 17 Feb 2018 15:32:11 -0500 Received: from mail-pl0-x244.google.com ([2607:f8b0:400e:c01::244]:33220) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1en99W-0000sT-1K for qemu-devel@nongnu.org; Sat, 17 Feb 2018 15:32:10 -0500 Received: by mail-pl0-x244.google.com with SMTP id t4so3544824plo.0 for ; Sat, 17 Feb 2018 12:32:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:subject:date:message-id:in-reply-to:references; bh=kDEHzy+WQxgp3ia3Fq5eY81Ya/41+t13dWHrw4i4lLo=; b=JwTlgXONxQcp5uv5NbaJ27atrtWcgbWIbYZaBcqCYgyz+vk6mHnS31t9Z9upAUv6d5 YUawUqhVJGWjPig/Q5bpwKL76VKK7pOVvliwMlrX6p4FD0VSsKVOVWZ2G1nAZcs5Jsmx zBlEycoADkSWREf/lc+InHuWuSQpw9XRfl0HU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references; bh=kDEHzy+WQxgp3ia3Fq5eY81Ya/41+t13dWHrw4i4lLo=; b=Emo2cnklSi1Gg5PNRQIvbN/GC74NJ1eSiA4GFZhR0hJB6y0t1cU0aGcYntc+MFZk75 c2HS1qYrAp8IwGMOuUhEplFk8rb3RS2EOF7LefdnZBjxM1dH0P5Ce+GTfJ75IBTfqhK2 kRTHo/3NCj2pEfS1DK24IKapwXyBufWkiUe7S1wNHY7Q0golfSoQJgssbA8OYxmYLs6a UcSHcX6v6N/VgB286ywjmhTdUM7srrnJg5vmh6xlc10N4ROp9dqaR8b0ft4HCoOynswW NmTX8b0FB8fDV/zOPhuPBHIp1rM6kiYWXnJ4aHZ57r0EqnDgc0Y4fhiXEpwwGL7uhZat 0pUQ== X-Gm-Message-State: APf1xPB6mZioBS8RykjoXPdncBsY4rvLLcBtfRZmVBwE5VvjN279HbuU XCK79LOEHo8ydk8LejYCanPUNokD+ro= X-Received: by 2002:a17:902:6116:: with SMTP id t22-v6mr9608321plj.307.1518899528791; Sat, 17 Feb 2018 12:32:08 -0800 (PST) Received: from cloudburst.twiddle.net ([50.0.192.64]) by smtp.gmail.com with ESMTPSA id y7sm48203797pfe.26.2018.02.17.12.32.07 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 17 Feb 2018 12:32:08 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Date: Sat, 17 Feb 2018 12:31:32 -0800 Message-Id: <20180217203132.31780-20-richard.henderson@linaro.org> X-Mailer: git-send-email 2.14.3 In-Reply-To: <20180217203132.31780-1-richard.henderson@linaro.org> References: <20180217203132.31780-1-richard.henderson@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c01::244 Subject: [Qemu-devel] [PATCH 19/19] target/hppa: Merge translate_one into hppa_tr_translate_insn X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Now that the implementation is entirely within the generated decode function, eliminate the wrapper. Signed-off-by: Richard Henderson --- target/hppa/translate.c | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) -- 2.14.3 diff --git a/target/hppa/translate.c b/target/hppa/translate.c index 305a81778b..877e4dc2b7 100644 --- a/target/hppa/translate.c +++ b/target/hppa/translate.c @@ -3992,13 +3992,6 @@ static void trans_fmpyfadd_d(DisasContext *ctx, arg_fmpyfadd_d *a, nullify_end(ctx); } -static void translate_one(DisasContext *ctx, uint32_t insn) -{ - if (!decode(ctx, insn)) { - gen_illegal(ctx); - } -} - static int hppa_tr_init_disas_context(DisasContextBase *dcbase, CPUState *cs, int max_insns) { @@ -4107,7 +4100,9 @@ static void hppa_tr_translate_insn(DisasContextBase *dcbase, CPUState *cs) ret = DISAS_NEXT; } else { ctx->insn = insn; - translate_one(ctx, insn); + if (!decode(ctx, insn)) { + gen_illegal(ctx); + } ret = ctx->base.is_jmp; assert(ctx->null_lab == NULL); }