diff mbox series

[RESEND,v2] checkpatch: add Crypto ON_STACK to declaration_macros

Message ID 1518941636-4484-1-git-send-email-gilad@benyossef.com
State Accepted
Commit 3d102fc0e7b02d4e16752c15aa92923405b01388
Headers show
Series [RESEND,v2] checkpatch: add Crypto ON_STACK to declaration_macros | expand

Commit Message

Gilad Ben-Yossef Feb. 18, 2018, 8:13 a.m. UTC
Add the crypto API *_ON_STACK to $declaration_macros.

Resolves the following false warning:

WARNING: Missing a blank line after declarations
+			int err;
+			SHASH_DESC_ON_STACK(desc, ctx_p->shash_tfm);

Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>

---
 scripts/checkpatch.pl | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

-- 
2.7.4

Comments

Joe Perches Feb. 18, 2018, 5:25 p.m. UTC | #1
On Sun, 2018-02-18 at 08:13 +0000, Gilad Ben-Yossef wrote:
> Add the crypto API *_ON_STACK to $declaration_macros.

> 

> Resolves the following false warning:

> 

> WARNING: Missing a blank line after declarations

> +			int err;

> +			SHASH_DESC_ON_STACK(desc, ctx_p->shash_tfm);

> 

> Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

> Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>


Signed-off-by: Joe Perches <joe@perches.com>

> ---

>  scripts/checkpatch.pl | 3 ++-

>  1 file changed, 2 insertions(+), 1 deletion(-)

> 

> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl

> index 3d40403..7d632645 100755

> --- a/scripts/checkpatch.pl

> +++ b/scripts/checkpatch.pl

> @@ -791,7 +791,8 @@ our $FuncArg = qr{$Typecast{0,1}($LvalOrFunc|$Constant|$String)};

>  our $declaration_macros = qr{(?x:

>  	(?:$Storage\s+)?(?:[A-Z_][A-Z0-9]*_){0,2}(?:DEFINE|DECLARE)(?:_[A-Z0-9]+){1,6}\s*\(|

>  	(?:$Storage\s+)?[HLP]?LIST_HEAD\s*\(|

> -	(?:$Storage\s+)?${Type}\s+uninitialized_var\s*\(

> +	(?:$Storage\s+)?${Type}\s+uninitialized_var\s*\(|

> +	(?:SKCIPHER_REQUEST|SHASH_DESC|AHASH_REQUEST)_ON_STACK\s*\(

>  )};

>  

>  sub deparenthesize {
diff mbox series

Patch

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 3d40403..7d632645 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -791,7 +791,8 @@  our $FuncArg = qr{$Typecast{0,1}($LvalOrFunc|$Constant|$String)};
 our $declaration_macros = qr{(?x:
 	(?:$Storage\s+)?(?:[A-Z_][A-Z0-9]*_){0,2}(?:DEFINE|DECLARE)(?:_[A-Z0-9]+){1,6}\s*\(|
 	(?:$Storage\s+)?[HLP]?LIST_HEAD\s*\(|
-	(?:$Storage\s+)?${Type}\s+uninitialized_var\s*\(
+	(?:$Storage\s+)?${Type}\s+uninitialized_var\s*\(|
+	(?:SKCIPHER_REQUEST|SHASH_DESC|AHASH_REQUEST)_ON_STACK\s*\(
 )};
 
 sub deparenthesize {