From patchwork Mon Nov 19 05:48:14 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sachin Kamat X-Patchwork-Id: 12911 Return-Path: X-Original-To: patchwork@peony.canonical.com Delivered-To: patchwork@peony.canonical.com Received: from fiordland.canonical.com (fiordland.canonical.com [91.189.94.145]) by peony.canonical.com (Postfix) with ESMTP id BDA0023FC2 for ; Mon, 19 Nov 2012 05:54:23 +0000 (UTC) Received: from mail-ie0-f180.google.com (mail-ie0-f180.google.com [209.85.223.180]) by fiordland.canonical.com (Postfix) with ESMTP id 49F27A18E09 for ; Mon, 19 Nov 2012 05:54:23 +0000 (UTC) Received: by mail-ie0-f180.google.com with SMTP id e10so5984672iej.11 for ; Sun, 18 Nov 2012 21:54:22 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-forwarded-to:x-forwarded-for:delivered-to:received-spf:from:to:cc :subject:date:message-id:x-mailer:x-gm-message-state; bh=HZX4qcnr1YHEenXkqVPLeDw7mE1bGO6eX0pQeMcrkso=; b=TmGg1hHO8oUWDptspve+8LtbKJHLbhsc1gVrZ7SEQhz0r64FjXxaTkhIgu0aopCFSX fI9EB2oBJ70D3+pcb0EhMG66SHPnzdQxHaEdfR9Nim4bGCuKEnsX5//6rAUbOR1pa2/H UlFwyHM0DxmPCkhWI2tRAVU0F6J8rQPhqbRsnUb9cAjZ+XAFjYw7cFiJ3D68HZVh6NdY 7MpBuoEzmZzOQC7/eK96WOgqX9+3M09TQl1A3c3zfY4FLPfUUgwNwm28f5js579KIQMk tCFd0O9V9XReEYVgaMZ86h6svlgyImdvCpKB3SYiuXBkldApSLR4SXZAgQjoCueh30sL 9d1Q== Received: by 10.50.187.197 with SMTP id fu5mr5576142igc.70.1353304462763; Sun, 18 Nov 2012 21:54:22 -0800 (PST) X-Forwarded-To: linaro-patchwork@canonical.com X-Forwarded-For: patch@linaro.org linaro-patchwork@canonical.com Delivered-To: patches@linaro.org Received: by 10.50.67.148 with SMTP id n20csp118626igt; Sun, 18 Nov 2012 21:54:22 -0800 (PST) Received: by 10.68.138.137 with SMTP id qq9mr36727671pbb.74.1353304462052; Sun, 18 Nov 2012 21:54:22 -0800 (PST) Received: from mail-pa0-f46.google.com (mail-pa0-f46.google.com [209.85.220.46]) by mx.google.com with ESMTPS id bc7si12063640pab.210.2012.11.18.21.54.21 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 18 Nov 2012 21:54:22 -0800 (PST) Received-SPF: neutral (google.com: 209.85.220.46 is neither permitted nor denied by best guess record for domain of sachin.kamat@linaro.org) client-ip=209.85.220.46; Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.220.46 is neither permitted nor denied by best guess record for domain of sachin.kamat@linaro.org) smtp.mail=sachin.kamat@linaro.org Received: by mail-pa0-f46.google.com with SMTP id bh2so189302pad.5 for ; Sun, 18 Nov 2012 21:54:21 -0800 (PST) Received: by 10.68.232.71 with SMTP id tm7mr36277724pbc.118.1353304461615; Sun, 18 Nov 2012 21:54:21 -0800 (PST) Received: from localhost.localdomain ([115.113.119.130]) by mx.google.com with ESMTPS id yi9sm5631034pbc.39.2012.11.18.21.54.18 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 18 Nov 2012 21:54:20 -0800 (PST) From: Sachin Kamat To: alsa-devel@alsa-project.org Cc: broonie@opensource.wolfsonmicro.com, tiwai@suse.de, sachin.kamat@linaro.org, patches@linaro.org Subject: [PATCH 1/1] ASoC: rt5631: Fix return value Date: Mon, 19 Nov 2012 11:18:14 +0530 Message-Id: <1353304094-9115-1-git-send-email-sachin.kamat@linaro.org> X-Mailer: git-send-email 1.7.4.1 X-Gm-Message-State: ALoCoQlSl1PypXPN/7KJpcY0NSUicp2RW2PJj488goP+4lNH2rPQ5mQhlzFjf+WyAg4lFsFaOsLW Return the value obtained from get_coeff() instead of EINVAL. Silences a smatch warning. Signed-off-by: Sachin Kamat --- sound/soc/codecs/rt5631.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/sound/soc/codecs/rt5631.c b/sound/soc/codecs/rt5631.c index 960d0e9..d6ca615 100644 --- a/sound/soc/codecs/rt5631.c +++ b/sound/soc/codecs/rt5631.c @@ -1382,7 +1382,7 @@ static int rt5631_hifi_pcm_params(struct snd_pcm_substream *substream, timesofbclk); if (coeff < 0) { dev_err(codec->dev, "Fail to get coeff\n"); - return -EINVAL; + return coeff; } switch (params_format(params)) {