From patchwork Mon Feb 26 05:09:04 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 129547 Delivered-To: patch@linaro.org Received: by 10.46.66.2 with SMTP id p2csp3230748lja; Sun, 25 Feb 2018 21:10:27 -0800 (PST) X-Google-Smtp-Source: AH8x224QhZuzRmr8JjNXZOzeu0AzZs6SxAU8S89KAWzuzgXR2TD/2QXw13rKobYv5NdkKlow0+VM X-Received: by 10.101.72.198 with SMTP id o6mr7385882pgs.279.1519621827148; Sun, 25 Feb 2018 21:10:27 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519621827; cv=none; d=google.com; s=arc-20160816; b=MourJdFYsFAzRhuCwsPCMYE7vUgbtzUaY3TitretRdDfudeGnN1hKyKmgN/5Q8unMC FBFpqQrWvgqAxbcDXmremiOdhRHbar/7EqyNwAVh9dp60q768Ez8cHmFr9PI6n9YpSdH jG59ypDiWEhekP+EPFVdaEpJbBWa2xx9DmlhoDxRH2BG2xw3lhcaWLT5rbssv2KKqpTc GQoKTnSCQionSCdmd6YLFyAHyFrc9H8MySro2H1Vjh91eN7+CURObgMUFBHcfpoMyHrO XPam6yq/+saj1oXmifC2qbBC/5wcE8aWT3/Cc7P3+YMr9zW4N0qg8NVV110w2ffhH3Yb UAWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:references :in-reply-to:message-id:date:subject:cc:to:from:dkim-signature :arc-authentication-results; bh=R0eRwI4CcGJHlRS6047/cUzrFodzSWOaOGrqDNWDTzA=; b=Feg6j4y1LnCEF6LRBsHmrRuMQvBhD8pxEO9hVZoqGxnUD3jXdwkCm7yD3VXxTcBUbW 0147XI1ZF8dCWoceUQ4A4sP98OQYW2ThAIwtUlN6vbV+Z9HRtKUKxWG+7gmD6JU8KJh7 C9do7j4f8l3KxDV0440yfNDrjcwHlBoQImZZPer4xaFmrAXpFGbU0E9PujhaVK/HZg3y eVvqdnKSnc1uk5Jv9tNsD6UmNwXH9WOvvlRKvtrcCsrkYeK8l/YmKB+sj/YdycK4L9is UWUMNgx0GlSnzZLqVJpl2etyEps9drQjwzW+15JUIn7nBAHDpp/JW6inWczW83H1qz5S xZXg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Us2MLYJo; spf=pass (google.com: best guess record for domain of linux-pm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-pm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h32-v6si6199354pld.217.2018.02.25.21.10.26; Sun, 25 Feb 2018 21:10:27 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-pm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Us2MLYJo; spf=pass (google.com: best guess record for domain of linux-pm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-pm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751981AbeBZFK0 (ORCPT + 11 others); Mon, 26 Feb 2018 00:10:26 -0500 Received: from mail-pl0-f65.google.com ([209.85.160.65]:42166 "EHLO mail-pl0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751968AbeBZFKZ (ORCPT ); Mon, 26 Feb 2018 00:10:25 -0500 Received: by mail-pl0-f65.google.com with SMTP id 31so8649712ple.9 for ; Sun, 25 Feb 2018 21:10:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=R0eRwI4CcGJHlRS6047/cUzrFodzSWOaOGrqDNWDTzA=; b=Us2MLYJocnkrEjSpTJ+w9fb9FHXTe39CU1z4wNQ9gNCeNNZKOtIQyxfh4eVruBtLkR uADx+K0iFQ0rnIsujuqx1hTV1CMb1xbKk6HomE1SrLnxcGrn5Pz+ILq2oyVs4QKbQfAW TSrrRI4SCGngvG/k4Pp605lQJ6nX7kgFNApEg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=R0eRwI4CcGJHlRS6047/cUzrFodzSWOaOGrqDNWDTzA=; b=cFw2vS6WWLXNzRG7gYsgBTDrKe0TtMXjhW0zRSZwDdXWxrrSiJfd6c4TggeJSJfh/v n20A3y5iPuFdfeBrxGiow/NwjWenss6KoZoGts6acvAcvaj7DolCNVh5OhJruUbGess2 bCsilGUoI+J/syBP1cBsnLcF3YTJAVvVop2cn7yg3bfkZtlx5mF+jivYJXo8GrC8iSBS V3lmIP3eZ1OPI6jT/aM/Dx/hVM7ir9NWmhwsSFY8gyfPDsm1cy+VFgYZOo9jdOk2i5D4 hoLB3U8kEG3DJg+TWqCH3R403mTUewkEuUBffR5cffXFzYO2Udsg87Px04xlY1mgewb5 a25g== X-Gm-Message-State: APf1xPAsg2RK1wo6nCYgByKkdnyPTQgYEwIzLySzOr4pOCOFfJRJhXtc to7yOYCQPyHKzICSguKqbS+aZw== X-Received: by 2002:a17:902:9881:: with SMTP id s1-v6mr9304461plp.286.1519621825326; Sun, 25 Feb 2018 21:10:25 -0800 (PST) Received: from localhost ([122.172.92.38]) by smtp.gmail.com with ESMTPSA id b8sm15848848pff.31.2018.02.25.21.10.24 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 25 Feb 2018 21:10:24 -0800 (PST) From: Viresh Kumar To: Rafael Wysocki , Sudeep Holla Cc: Viresh Kumar , linux-pm@vger.kernel.org, Vincent Guittot , linux-arm-kernel@lists.infradead.org Subject: [PATCH 21/27] cpufreq: scpi: Don't validate the frequency table twice Date: Mon, 26 Feb 2018 10:39:04 +0530 Message-Id: <9a5c962bd3a225cfa87d6dcb0f6bb85697991c66.1519620578.git.viresh.kumar@linaro.org> X-Mailer: git-send-email 2.15.0.194.g9af6a3dea062 In-Reply-To: References: In-Reply-To: References: Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org The cpufreq core is already validating the CPU frequency table after calling the ->init() callback of the cpufreq drivers and the drivers don't need to do the same anymore. Though they need to set the policy->freq_table field directly from the ->init() callback now. Stop validating the frequency table from scpi driver. Signed-off-by: Viresh Kumar --- drivers/cpufreq/scpi-cpufreq.c | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) -- 2.15.0.194.g9af6a3dea062 Acked-by: Sudeep Holla Tested-by: Sudeep Holla diff --git a/drivers/cpufreq/scpi-cpufreq.c b/drivers/cpufreq/scpi-cpufreq.c index c32a833e1b00..7b31efe53252 100644 --- a/drivers/cpufreq/scpi-cpufreq.c +++ b/drivers/cpufreq/scpi-cpufreq.c @@ -150,13 +150,7 @@ static int scpi_cpufreq_init(struct cpufreq_policy *policy) } policy->driver_data = priv; - - ret = cpufreq_table_validate_and_show(policy, freq_table); - if (ret) { - dev_err(cpu_dev, "%s: invalid frequency table: %d\n", __func__, - ret); - goto out_put_clk; - } + policy->freq_table = freq_table; /* scpi allows DVFS request for any domain from any CPU */ policy->dvfs_possible_from_any_cpu = true; @@ -170,8 +164,6 @@ static int scpi_cpufreq_init(struct cpufreq_policy *policy) policy->fast_switch_possible = false; return 0; -out_put_clk: - clk_put(priv->clk); out_free_cpufreq_table: dev_pm_opp_free_cpufreq_table(cpu_dev, &freq_table); out_free_priv: