| Message ID | 1353388963-23761-4-git-send-email-sachin.kamat@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
On 11/20/2012 02:22 PM, Sachin Kamat wrote: > Return the value obtained from the function extcon_register_interest > instead of -EINVAL. > > Silences the following warning: > drivers/extcon/extcon-class.c:475 extcon_register_interest() info: > why not propagate 'obj->cable_index' from extcon_find_cable_index() > instead of -22? > > Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> > --- I consolidate following two patches because of similar patch. extcon: Fix return value in extcon-class.c extcon: Redo: Fix return value in extcon_register_interest() Thank you, Chanwoo Choi
On 20 November 2012 13:24, Chanwoo Choi <cw00.choi@samsung.com> wrote: > On 11/20/2012 02:22 PM, Sachin Kamat wrote: >> Return the value obtained from the function extcon_register_interest >> instead of -EINVAL. >> >> Silences the following warning: >> drivers/extcon/extcon-class.c:475 extcon_register_interest() info: >> why not propagate 'obj->cable_index' from extcon_find_cable_index() >> instead of -22? >> >> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> >> --- > > I consolidate following two patches because of similar patch. > > extcon: Fix return value in extcon-class.c > extcon: Redo: Fix return value in extcon_register_interest() You are right. Fair enough. > > Thank you, > Chanwoo Choi
diff --git a/drivers/extcon/extcon-class.c b/drivers/extcon/extcon-class.c index 8e577ed..60adc04 100644 --- a/drivers/extcon/extcon-class.c +++ b/drivers/extcon/extcon-class.c @@ -472,7 +472,7 @@ int extcon_register_interest(struct extcon_specific_cable_nb *obj, obj->cable_index = extcon_find_cable_index(obj->edev, cable_name); if (obj->cable_index < 0) - return -EINVAL; + return obj->cable_index; obj->user_nb = nb;
Return the value obtained from the function extcon_register_interest instead of -EINVAL. Silences the following warning: drivers/extcon/extcon-class.c:475 extcon_register_interest() info: why not propagate 'obj->cable_index' from extcon_find_cable_index() instead of -22? Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> --- drivers/extcon/extcon-class.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)