[CPUFREQ] EXYNOS: Use static for functions used in only this file

Message ID 1353391154-32524-1-git-send-email-tushar.behera@linaro.org
State Accepted
Commit 5542721a337f3fcfa0585c915827dc391f36fd28
Headers show

Commit Message

Tushar Behera Nov. 20, 2012, 5:59 a.m.
Fixes following sparse error.
drivers/cpufreq/exynos-cpufreq.c:34:5: warning: symbol
'exynos_verify_speed' was not declared. Should it be static?
drivers/cpufreq/exynos-cpufreq.c:40:14: warning: symbol
'exynos_getspeed' was not declared. Should it be static?

Signed-off-by: Tushar Behera <tushar.behera@linaro.org>
---
 drivers/cpufreq/exynos-cpufreq.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

Comments

Rafael J. Wysocki Nov. 21, 2012, 11:42 p.m. | #1
On Tuesday, November 20, 2012 11:29:14 AM Tushar Behera wrote:
> Fixes following sparse error.
> drivers/cpufreq/exynos-cpufreq.c:34:5: warning: symbol
> 'exynos_verify_speed' was not declared. Should it be static?
> drivers/cpufreq/exynos-cpufreq.c:40:14: warning: symbol
> 'exynos_getspeed' was not declared. Should it be static?

Applied to linux-pm.git/linux-next as v3.8 material.

Thanks,
Rafael


> Signed-off-by: Tushar Behera <tushar.behera@linaro.org>
> ---
>  drivers/cpufreq/exynos-cpufreq.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/cpufreq/exynos-cpufreq.c b/drivers/cpufreq/exynos-cpufreq.c
> index af2d81e..eb057bf 100644
> --- a/drivers/cpufreq/exynos-cpufreq.c
> +++ b/drivers/cpufreq/exynos-cpufreq.c
> @@ -31,13 +31,13 @@ static unsigned int locking_frequency;
>  static bool frequency_locked;
>  static DEFINE_MUTEX(cpufreq_lock);
>  
> -int exynos_verify_speed(struct cpufreq_policy *policy)
> +static int exynos_verify_speed(struct cpufreq_policy *policy)
>  {
>  	return cpufreq_frequency_table_verify(policy,
>  					      exynos_info->freq_table);
>  }
>  
> -unsigned int exynos_getspeed(unsigned int cpu)
> +static unsigned int exynos_getspeed(unsigned int cpu)
>  {
>  	return clk_get_rate(exynos_info->cpu_clk) / 1000;
>  }
>

Patch

diff --git a/drivers/cpufreq/exynos-cpufreq.c b/drivers/cpufreq/exynos-cpufreq.c
index af2d81e..eb057bf 100644
--- a/drivers/cpufreq/exynos-cpufreq.c
+++ b/drivers/cpufreq/exynos-cpufreq.c
@@ -31,13 +31,13 @@  static unsigned int locking_frequency;
 static bool frequency_locked;
 static DEFINE_MUTEX(cpufreq_lock);
 
-int exynos_verify_speed(struct cpufreq_policy *policy)
+static int exynos_verify_speed(struct cpufreq_policy *policy)
 {
 	return cpufreq_frequency_table_verify(policy,
 					      exynos_info->freq_table);
 }
 
-unsigned int exynos_getspeed(unsigned int cpu)
+static unsigned int exynos_getspeed(unsigned int cpu)
 {
 	return clk_get_rate(exynos_info->cpu_clk) / 1000;
 }