From patchwork Mon Feb 26 21:03:27 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adhemerval Zanella X-Patchwork-Id: 129714 Delivered-To: patch@linaro.org Received: by 10.80.172.228 with SMTP id x91csp4291789edc; Mon, 26 Feb 2018 13:06:13 -0800 (PST) X-Google-Smtp-Source: AH8x226AmrHGrxwBhqJHoEwb1hrViic3c4r2phC+/lnJkjqmDa4LspY5eIzDhR35A12IFudZzsXs X-Received: by 2002:a17:902:5797:: with SMTP id l23-v6mr11680931pli.56.1519679173021; Mon, 26 Feb 2018 13:06:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519679173; cv=none; d=google.com; s=arc-20160816; b=k4sGyOj9anE+gELyxfaeXi4Ih3Ai53nsfBO535q4bmEVKFV9/s+fRJ/dcgna8/fUaz GERZMqQ1EkO+4k1JQI16fr9cwv3cP6lN9OktaokCGH/8iUCWynk+FoLuCF7zZmPnRylV ufOzM/n9Cvwerqnz/kBzF76l9+ay2WxwipA6CIuw8Sjv63Jd/KN7wbs4NleQaqDokbJi P6TRCl/aEnyxUwKOVFPnjM7jfly9gEQvU9cb8AHdYqX+k4vb8SNo8lICq47dhvjeAAEu ZHNSM4GUx2j3e9RXldmpRW+1RN5Hv6z1N4QKHZM5PzK4Ivtd5kDSuuKyMncwT+kDc37A OCpQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=references:in-reply-to:message-id:date:subject:to:from:delivered-to :sender:list-help:list-post:list-archive:list-subscribe :list-unsubscribe:list-id:precedence:mailing-list:dkim-signature :domainkey-signature:arc-authentication-results; bh=VVQell1oQ7MntDbjEHsRILnAWhnsUxWeKxijv+xVJlc=; b=Vr6j3WVK9r9bIfcjUtA+7Cv/3gHrgFJ0iOItBxV5PVVigkIxClFFOVfl3Km8/tu5cP E4VTywYMaDC49nTaC9p3iHo33nsXl40yeAz628IDj7Z/4AXFd6SMkH7MhHK3HEgeU6nP ZdaE0P2e7sFZhHttYi+jPzKFe1CFhiV5SOcnDH/lG7sKhI7dUrmvyNsXDQK6XB9Nk6BH YiJyKXF4qP6zx7sAlyXqBKCkFtUc+PK/pOymyxs5kppiBJwMwnzjCRdIG+utQnpciWXr bo/C9X+ubXssKh3L09YZasOptSoiAf5qvy8Ttzxt/HMmNUtEFdnT79Tkh2uo+/3/oe5B CImw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=Pv3m0eSx; spf=pass (google.com: domain of libc-alpha-return-90629-patch=linaro.org@sourceware.org designates 209.132.180.131 as permitted sender) smtp.mailfrom=libc-alpha-return-90629-patch=linaro.org@sourceware.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from sourceware.org (server1.sourceware.org. [209.132.180.131]) by mx.google.com with ESMTPS id x21-v6si7309511pln.416.2018.02.26.13.06.12 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 26 Feb 2018 13:06:13 -0800 (PST) Received-SPF: pass (google.com: domain of libc-alpha-return-90629-patch=linaro.org@sourceware.org designates 209.132.180.131 as permitted sender) client-ip=209.132.180.131; Authentication-Results: mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=Pv3m0eSx; spf=pass (google.com: domain of libc-alpha-return-90629-patch=linaro.org@sourceware.org designates 209.132.180.131 as permitted sender) smtp.mailfrom=libc-alpha-return-90629-patch=linaro.org@sourceware.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:subject:date:message-id:in-reply-to :references; q=dns; s=default; b=sXWgw7g7A79h6YHPTPoQL3Hsc13CgVq k4dBbN1g7OwkuxFgi7M3N6BTTqVVgNj2SorSdvBNcbk3m6lVqOn5QRNpkCKt0v8T v+MbJgcQ2prQrcHvWRZHx4GXMVFfUnpa6imSYgms1SPCt3RbnNUJsyrV2w4bShjR nZ72Gww5fZgg= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:subject:date:message-id:in-reply-to :references; s=default; bh=oys5eqV9saQ3ChiK8qB1BXbn4es=; b=Pv3m0 eSxpKb64D/ZHhhdPQt6N2cELUyViwZbO1bui1VskXf8nL4V8Kg7tONVYdXVUZL0s 2yOgzLg0FCq8EhYJ/yWoN+dldm4SzYcKenIbZkcgOz4if1xpoW68b6NAR6xZmfNl pjmBb935sLAQXmTbzDO8fvJCGAXAafFBJNahMk= Received: (qmail 77120 invoked by alias); 26 Feb 2018 21:04:09 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 76695 invoked by uid 89); 26 Feb 2018 21:04:06 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.7 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KAM_SHORT, RCVD_IN_DNSWL_LOW, SPF_PASS autolearn=ham version=3.3.2 spammy=cod X-HELO: mail-qt0-f181.google.com X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references; bh=VVQell1oQ7MntDbjEHsRILnAWhnsUxWeKxijv+xVJlc=; b=kWMoUuhaw9bWBrqHBmw8ebPS0lvWPnZtCy8b2qwC7GyQAOvYjiKtW4AZFWzq25OaB0 HiQm2BhOZqZY6QQLx/bTO/rBn+p0DX4+jpJNBoslvLNP481K+jhvOqo0aMYhCsuZ8Ols GEE1s+8VlMkuVbm5n26uCuExlW4XuKzV7k/DhZORqs3CR1GicyRm+gUhc2+qLBQB7Qan YOxPQkm8HPQLkDGBjiv4UJUwsAts1QhgvjbV9B+TV0B8K4Li2xPccBXfDhA01UPr5zfV EvhZtaPyO60fwb7DeZC+gFaHbK+Gw1W5zoXWkPnL2JfcOLzpWbwSF52ZBgDcZWtT2L4L wDww== X-Gm-Message-State: APf1xPAGfX99e42Dudh29PI86jy5GMzSIUUR+Jc3lGFvcMgYcF8AopKW 4YLOIoxWB/yCjWJecPmR23mGVxCOZVc= X-Received: by 10.200.34.209 with SMTP id g17mr18745066qta.93.1519679042634; Mon, 26 Feb 2018 13:04:02 -0800 (PST) From: Adhemerval Zanella To: libc-alpha@sourceware.org Subject: [PATCH v2 12/21] nptl: alpha: Fix Race conditions in pthread cancellation (BZ#12683) Date: Mon, 26 Feb 2018 18:03:27 -0300 Message-Id: <1519679016-12241-13-git-send-email-adhemerval.zanella@linaro.org> In-Reply-To: <1519679016-12241-1-git-send-email-adhemerval.zanella@linaro.org> References: <1519679016-12241-1-git-send-email-adhemerval.zanella@linaro.org> This patch adds the alpha modifications required for the BZ#12683. It basically adds the required ucontext_get_pc function The default syscall_cancel.c should be fine for alpha and GCC 6.1 generates the following cod for syscall_cancel.os: --- 0000000000000000 <__GI___syscall_cancel_arch>: 0: 00 00 bb 27 ldah gp,0(t12) 4: 00 00 bd 23 lda gp,0(gp) 8: f0 ff de 23 lda sp,-16(sp) c: 00 04 f1 47 mov a1,v0 10: 00 00 5e b7 stq ra,0(sp) 0000000000000014 <__syscall_cancel_arch_start>: 14: 00 00 30 a0 ldl t0,0(a0) 18: 01 00 e1 43 sextl t0,t0 1c: 01 90 20 44 and t0,0x4,t0 20: 0f 00 20 f4 bne t0,60 <__syscall_cancel_arch_end+0x20> 24: 10 04 f2 47 mov a2,a0 28: 11 04 f3 47 mov a3,a1 2c: 12 04 f4 47 mov a4,a2 30: 10 00 9e a6 ldq a4,16(sp) 34: 13 04 f5 47 mov a5,a3 38: 18 00 be a6 ldq a5,24(sp) 3c: 83 00 00 00 callsys 0000000000000040 <__syscall_cancel_arch_end>: 40: 21 05 e0 43 negq v0,t0 44: 00 00 5e a7 ldq ra,0(sp) 48: c0 04 61 46 cmovne a3,t0,v0 4c: 10 00 de 23 lda sp,16(sp) 50: 01 80 fa 6b ret 54: 00 00 fe 2f unop 58: 1f 04 ff 47 nop 5c: 00 00 fe 2f unop 60: 00 00 7d a7 ldq t12,0(gp) 64: 00 40 5b 6b jsr ra,(t12),68 <__syscall_cancel_arch_end+0x28> 68: 1f 04 ff 47 nop 6c: 00 00 fe 2f unop --- Checked on alpha-linux-gnu, no regression found. [BZ #12683] * sysdeps/unix/sysv/linux/alpha/sigcontextinfo.h (ucontext_get_pc): New function. --- ChangeLog | 4 ++++ sysdeps/unix/sysv/linux/alpha/sigcontextinfo.h | 13 +++++++++++++ 2 files changed, 17 insertions(+) -- 2.7.4 diff --git a/sysdeps/unix/sysv/linux/alpha/sigcontextinfo.h b/sysdeps/unix/sysv/linux/alpha/sigcontextinfo.h index 23f66d0..f762fff 100644 --- a/sysdeps/unix/sysv/linux/alpha/sigcontextinfo.h +++ b/sysdeps/unix/sysv/linux/alpha/sigcontextinfo.h @@ -15,6 +15,11 @@ License along with the GNU C Library. If not, see . */ +#ifndef _SIGCONTEXTINFO_H +#define _SIGCONTEXTINFO_H + +#include + #define SIGCONTEXT int _code, struct sigcontext * #define SIGCONTEXT_EXTRA_ARGS _code, #define GET_PC(ctx) ((void *) (ctx)->sc_pc) @@ -22,3 +27,11 @@ #define GET_STACK(ctx) ((void *) (ctx)->sc_regs[30]) #define CALL_SIGHANDLER(handler, signo, ctx) \ (handler)((signo), SIGCONTEXT_EXTRA_ARGS (ctx)) + +static inline uintptr_t +ucontext_get_pc (const ucontext_t *uc) +{ + return uc->uc_mcontext.sc_pc; +} + +#endif /* _SIGCONTEXTINFO_H */