From patchwork Tue Feb 27 14:38:30 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 129808 Delivered-To: patch@linaro.org Received: by 10.46.66.2 with SMTP id p2csp1475382lja; Tue, 27 Feb 2018 06:48:49 -0800 (PST) X-Google-Smtp-Source: AG47ELu3TsLjA8Gxg3DhZFEqU6Jfi6nsTQlsNrOR0Kd7SNybnHI/y18xuUX6fJh9nCGIb6q5WsGj X-Received: by 10.129.112.19 with SMTP id l19mr9560095ywc.200.1519742928976; Tue, 27 Feb 2018 06:48:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519742928; cv=none; d=google.com; s=arc-20160816; b=TnTsDwQUJGmsdJFq269HwDZlrZA6XdMWpr6dI27M7GpPzo4FrdegG+A01zRmloP0/i 8jhi6V1XA408SbrRcvEkH3bTfEowVPdnULiWItK01qReFsGJwSpQi7EBngfFuTapgKVV VfOdF6KPTkSAvatQA1cfonx7XYwf52Z/6m3u+2731hLG3hBrk36Vlu3pt5kr9cuhm+Wt /jyA9UAnbLBWDjKsbbW/RgA4PLrAvbcLg/sS6p/Icyq2NHYv8Zl82P3ej6eAA8p9I7zj VctzOXUrJUxg2ihBFSGvubiurk03zTW6uykdNY7W6wdiq3jVVzJWYyzu/EKy0ITxZUh+ 37hQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:to:from:dkim-signature:arc-authentication-results; bh=o5+6wz+aEOUl6k83db9fdFtzMNltkGU6ZiUGBUHl+ho=; b=YaO0/KAXQoXcyuoUmOvQwFTn6+6E1oKgm5DWFFOEWudefKb8UWwH/UL9RW6So0dghf jltFn+lpAZAH8eh0swafH7qH4ZltNlIuBk7XAvbqlqANDpZDMZfz+799+qwAiqt3Vd33 LK3ILNmP/ebfjnIlXeZ15c+OhqYorPF488xXN30SJk96FyfpSeVs/Zy2skaA0rcTkhr6 Jzq/vJCPbOLbDoCcRog7+Yu+KzF5L+MMbARxKEZhv+ERKaZvZxzK7SWTAnxFFgUmr5js nd6p57o1IwXiZG8OJnu8nuMB5QjtCidCNQJDeoobFqF2/s+hvW1oQYOSikvlffu5HCTF rLMQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=AJD9xc4x; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id x127si476951ywf.256.2018.02.27.06.48.48 for (version=TLS1 cipher=AES128-SHA bits=128/128); Tue, 27 Feb 2018 06:48:48 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=AJD9xc4x; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:37726 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eqgYh-0003km-Hn for patch@linaro.org; Tue, 27 Feb 2018 09:48:47 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55898) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eqgPQ-0003jw-0e for qemu-devel@nongnu.org; Tue, 27 Feb 2018 09:39:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eqgPN-00081c-3d for qemu-devel@nongnu.org; Tue, 27 Feb 2018 09:39:11 -0500 Received: from mail-wm0-x242.google.com ([2a00:1450:400c:c09::242]:40640) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eqgPM-00081L-TG for qemu-devel@nongnu.org; Tue, 27 Feb 2018 09:39:09 -0500 Received: by mail-wm0-x242.google.com with SMTP id t6so15916270wmt.5 for ; Tue, 27 Feb 2018 06:39:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=o5+6wz+aEOUl6k83db9fdFtzMNltkGU6ZiUGBUHl+ho=; b=AJD9xc4xOmbNXtMDHY/7Mm9YvZmP8yY+5RBPf61Su8Eq9QD6A07f8/lwVLCnUCTWnH GZS+xU5uLufjcStYJabV4gv8tQuOwFAau1ndHbj706Qs+Ris7jEQwxlmnbO2K6OIk2L/ KB/dap1G987MI9JW5NI3EMZdaAIhLqn23j0bg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=o5+6wz+aEOUl6k83db9fdFtzMNltkGU6ZiUGBUHl+ho=; b=hhibqgrwwaQElMZR1mnxWyN9le4AqvkL/VfNV0aZzhjb39ZqgjsrriAnXSGycpsXlJ 80yOww2ockYDNTdkEWVoSfrfZS+M+yoz6/lrqbM0lnieaq4SFuhYVCEHjuDaYtPhQdsT f2QPf2sir9ObRso2osf6d0w+6NtUEVJrVG/zVZppaEWoOjwrCyg5cbsmiAvGdtrHmh1a +nMnbAM12zfwZ4TbGry8dS15N2JTTG/wBXhvTTYqYD1hG4KhxLQdQQasR+lo2U87fMha vQ8wYo3WWOJTRX+Fmk2rlgRhNk/0srEcmCaZj7jo/P7PD0foOcxf+lQQFDGGkCK370XH tNLw== X-Gm-Message-State: APf1xPAeI0Gj0YusmSv0boqcu+hGZzOQ9WLaFHwwFLuqPNVa9pmTTIxT V3xQVZEeXCX8p7XxdTJaPuD8OA== X-Received: by 10.28.148.130 with SMTP id w124mr11565794wmd.124.1519742347812; Tue, 27 Feb 2018 06:39:07 -0800 (PST) Received: from zen.linaro.local ([81.128.185.34]) by smtp.gmail.com with ESMTPSA id x190sm13300059wme.27.2018.02.27.06.38.56 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 27 Feb 2018 06:38:59 -0800 (PST) Received: from zen.linaroharston (localhost [127.0.0.1]) by zen.linaro.local (Postfix) with ESMTP id 8D4553E099E; Tue, 27 Feb 2018 14:38:53 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-arm@nongnu.org Date: Tue, 27 Feb 2018 14:38:30 +0000 Message-Id: <20180227143852.11175-10-alex.bennee@linaro.org> X-Mailer: git-send-email 2.15.1 In-Reply-To: <20180227143852.11175-1-alex.bennee@linaro.org> References: <20180227143852.11175-1-alex.bennee@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c09::242 Subject: [Qemu-devel] [PATCH v4 09/31] arm/translate-a64: add FP16 FADD/FABD/FSUB/FMUL/FDIV to simd_three_reg_same_fp16 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?utf-8?q?Alex_Benn=C3=A9e?= , richard.henderson@linaro.org, qemu-devel@nongnu.org, Peter Maydell Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" The fprintf is only there for debugging as the skeleton is added to, it will be removed once the skeleton is complete. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson --- v2 - add absh helper - fix checkpatch violation - make abs a bitwise operation --- target/arm/helper-a64.c | 4 ++++ target/arm/helper-a64.h | 4 ++++ target/arm/translate-a64.c | 28 ++++++++++++++++++++++++++++ 3 files changed, 36 insertions(+) -- 2.15.1 diff --git a/target/arm/helper-a64.c b/target/arm/helper-a64.c index fddd5d242b..931a6d3c34 100644 --- a/target/arm/helper-a64.c +++ b/target/arm/helper-a64.c @@ -586,6 +586,10 @@ float16 ADVSIMD_HELPER(name, h)(float16 a, float16 b, void *fpstp) \ return float16_ ## name(a, b, fpst); \ } +ADVSIMD_HALFOP(add) +ADVSIMD_HALFOP(sub) +ADVSIMD_HALFOP(mul) +ADVSIMD_HALFOP(div) ADVSIMD_HALFOP(min) ADVSIMD_HALFOP(max) ADVSIMD_HALFOP(minnum) diff --git a/target/arm/helper-a64.h b/target/arm/helper-a64.h index cb2a73124d..bac9469426 100644 --- a/target/arm/helper-a64.h +++ b/target/arm/helper-a64.h @@ -52,3 +52,7 @@ DEF_HELPER_FLAGS_3(advsimd_maxh, TCG_CALL_NO_RWG, f16, f16, f16, ptr) DEF_HELPER_FLAGS_3(advsimd_minh, TCG_CALL_NO_RWG, f16, f16, f16, ptr) DEF_HELPER_FLAGS_3(advsimd_maxnumh, TCG_CALL_NO_RWG, f16, f16, f16, ptr) DEF_HELPER_FLAGS_3(advsimd_minnumh, TCG_CALL_NO_RWG, f16, f16, f16, ptr) +DEF_HELPER_3(advsimd_addh, f16, f16, f16, ptr) +DEF_HELPER_3(advsimd_subh, f16, f16, f16, ptr) +DEF_HELPER_3(advsimd_mulh, f16, f16, f16, ptr) +DEF_HELPER_3(advsimd_divh, f16, f16, f16, ptr) diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c index 4828457b5b..f8770ee1e9 100644 --- a/target/arm/translate-a64.c +++ b/target/arm/translate-a64.c @@ -10283,6 +10283,34 @@ static void disas_simd_three_reg_same_fp16(DisasContext *s, uint32_t insn) read_vec_element_i32(s, tcg_op2, rm, pass, MO_16); switch (fpopcode) { + case 0x0: /* FMAXNM */ + gen_helper_advsimd_maxnumh(tcg_res, tcg_op1, tcg_op2, fpst); + break; + case 0x2: /* FADD */ + gen_helper_advsimd_addh(tcg_res, tcg_op1, tcg_op2, fpst); + break; + case 0x6: /* FMAX */ + gen_helper_advsimd_maxh(tcg_res, tcg_op1, tcg_op2, fpst); + break; + case 0x8: /* FMINNM */ + gen_helper_advsimd_minnumh(tcg_res, tcg_op1, tcg_op2, fpst); + break; + case 0xa: /* FSUB */ + gen_helper_advsimd_subh(tcg_res, tcg_op1, tcg_op2, fpst); + break; + case 0xe: /* FMIN */ + gen_helper_advsimd_minh(tcg_res, tcg_op1, tcg_op2, fpst); + break; + case 0x13: /* FMUL */ + gen_helper_advsimd_mulh(tcg_res, tcg_op1, tcg_op2, fpst); + break; + case 0x17: /* FDIV */ + gen_helper_advsimd_divh(tcg_res, tcg_op1, tcg_op2, fpst); + break; + case 0x1a: /* FABD */ + gen_helper_advsimd_subh(tcg_res, tcg_op1, tcg_op2, fpst); + tcg_gen_andi_i32(tcg_res, tcg_res, 0x7fff); + break; default: fprintf(stderr, "%s: insn %#04x, fpop %#2x @ %#" PRIx64 "\n", __func__, insn, fpopcode, s->pc);