[v2,3/6] kconfig: remove redundant input_mode test for check_conf() loop

Message ID 1519776926-30459-4-git-send-email-yamada.masahiro@socionext.com
State Accepted
Commit 99f0b6578bab440586befe2cdb6db8e38fec3acd
Headers show
Series
  • kconfig: some clean-ups and rename silentoldconfig
Related show

Commit Message

Masahiro Yamada Feb. 28, 2018, 12:15 a.m.
check_conf() never increments conf_cnt for listnewconfig, so conf_cnt
is always zero.

In other words, conf_cnt is not zero, "input_mode != listnewconfig"
is met.

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>

Reviewed-by: Ulf Magnusson <ulfalizer@gmail.com>

---

Changes in v2: None

 scripts/kconfig/conf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.7.4

Patch

diff --git a/scripts/kconfig/conf.c b/scripts/kconfig/conf.c
index 1faa55f..59656d3 100644
--- a/scripts/kconfig/conf.c
+++ b/scripts/kconfig/conf.c
@@ -669,7 +669,7 @@  int main(int ac, char **av)
 		do {
 			conf_cnt = 0;
 			check_conf(&rootmenu);
-		} while (conf_cnt && input_mode != listnewconfig);
+		} while (conf_cnt);
 		break;
 	case olddefconfig:
 	default: