From patchwork Thu Mar 1 07:33:09 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hemant Agrawal X-Patchwork-Id: 130121 Delivered-To: patch@linaro.org Received: by 10.80.172.228 with SMTP id x91csp2481789edc; Wed, 28 Feb 2018 23:35:24 -0800 (PST) X-Google-Smtp-Source: AG47ELuYg0bwZ52pPXIRUP1LnYpcX1FfW0ci1zfNxstmONw12CjtFbx27QoTIWLJvHAHEKhu6Ryt X-Received: by 10.223.201.142 with SMTP id f14mr807193wrh.40.1519889724445; Wed, 28 Feb 2018 23:35:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519889724; cv=none; d=google.com; s=arc-20160816; b=buwnSSGSez3MftdY/++cPSzq35ndPV+WY3WosYqy6IKHQuZdKYLfaLeC5gwAJ/MSfM KQcOyI5cEKPOJMCFQWN3vapdh0NtuYd0Fwe2DzmlbfMXuCHRW6fQNkdi9MIyR6Zmkk9K eXbnfxw380e6LaTfZ9eICPK5oyWw1A+88Te8eRDEVVGYXZkTeLhsIdyGzF882DrgUigc 3VhvAml/Clu/2QSczgexMRFyC255+OD4FqlY+zZ7c0qbm2T0zEw09g5aaLdPybMzFjob 2eLVp4JWLyaORJbBYHwutPd+1bQ98C7RAimPfKOibaMgY6S6+Uo0MgxIXufI+M10jJRD ykVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:spamdiagnosticmetadata :spamdiagnosticoutput:mime-version:references:in-reply-to:message-id :date:cc:to:from:dkim-signature:arc-authentication-results; bh=WqYn4rS6RmeZ5cbZH80YRy4Fcn2QMoMpXVYJAejhXrU=; b=NWBRN4slBaWh6kJIixOHhMaksRgcweqAoWaC+xn93aW4GGT1AZMRtTsj30OYSQrg9T WrRafDnoJwCg3GJoCYnqsCyBSlqwnDUDxVtcPNXk7XC/WHH6UVJXsbU84A/jKpGwdGWt hlFx6K+JVieORq2Fw9wb+SYMh2p/J5k9Ot4pOaw/wC9pZU6Xf9EUEodBTB0gKx78OPfH WqMY0eDRxLeYVWhlwfIYH1YD9DiTA7vsxWymy8xosswU2lvZmEw+f0rKgXGltlV0h31R Yqgwxhhyv6eQ4tVe2QjsRyaluK0BzeqNe5HjmBSFuHnZpwZxm1cS053gPotNACXmpbGD b9Rg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@nxp.com header.s=selector1 header.b=pZejjftM; spf=pass (google.com: domain of dev-bounces@dpdk.org designates 92.243.14.124 as permitted sender) smtp.mailfrom=dev-bounces@dpdk.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Return-Path: Received: from dpdk.org (dpdk.org. [92.243.14.124]) by mx.google.com with ESMTP id w206si2276176wmd.227.2018.02.28.23.35.24; Wed, 28 Feb 2018 23:35:24 -0800 (PST) Received-SPF: pass (google.com: domain of dev-bounces@dpdk.org designates 92.243.14.124 as permitted sender) client-ip=92.243.14.124; Authentication-Results: mx.google.com; dkim=fail header.i=@nxp.com header.s=selector1 header.b=pZejjftM; spf=pass (google.com: domain of dev-bounces@dpdk.org designates 92.243.14.124 as permitted sender) smtp.mailfrom=dev-bounces@dpdk.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6BD4C5B22; Thu, 1 Mar 2018 08:35:00 +0100 (CET) Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on0071.outbound.protection.outlook.com [104.47.2.71]) by dpdk.org (Postfix) with ESMTP id 4C6D94C9F; Thu, 1 Mar 2018 08:34:59 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=WqYn4rS6RmeZ5cbZH80YRy4Fcn2QMoMpXVYJAejhXrU=; b=pZejjftMGBz2E+/HMNZnzIDTl0uaEFujgJABk4SgOer0+AU7tjSiaAoAo/ChTCDxDCJrL2q+v96hUCKpOAnclSiVjRv5FQUo5KNDDP+ghhPV8c5iWxVFrqEIZKZ15HK7QgVp8XIcJotDiLiOFdBqq84N10sYX9KMbxwWSTUvbtk= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=hemant.agrawal@nxp.com; Received: from bf-netperf1.ap.freescale.net (14.142.187.166) by AM2PR04MB0753.eurprd04.prod.outlook.com (2a01:111:e400:8411::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.527.15; Thu, 1 Mar 2018 07:34:57 +0000 From: Hemant Agrawal To: dev@dpdk.org, bruce.richardson@intel.com Cc: thomas@monjalon.net, stable@dpdk.org Date: Thu, 1 Mar 2018 13:03:09 +0530 Message-Id: <1519889597-5805-3-git-send-email-hemant.agrawal@nxp.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1519889597-5805-1-git-send-email-hemant.agrawal@nxp.com> References: <1519752352-15442-1-git-send-email-hemant.agrawal@nxp.com> <1519889597-5805-1-git-send-email-hemant.agrawal@nxp.com> MIME-Version: 1.0 X-Originating-IP: [14.142.187.166] X-ClientProxiedBy: PN1PR0101CA0043.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c00:c::29) To AM2PR04MB0753.eurprd04.prod.outlook.com (2a01:111:e400:8411::13) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: a019407c-311a-4298-83dc-08d57f46ef4b X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(5600026)(4604075)(2017052603307)(7153060)(7193020); SRVR:AM2PR04MB0753; X-Microsoft-Exchange-Diagnostics: 1; AM2PR04MB0753; 3:NNutxgBet1I8W7Dyjb+8TND/alCYm0EGFwUNm66J5zQO6Mn0PMw4hw2xbYbalrq/nIZubCDqsbWAEyXdOhXoaHb51aCfMDMOxJ0eAOstrUcOMOn28CVXKWGjWElTjdsiMYG4NkFkDlfYwG0IC1QnhYXf1/1EPntDbk4gZb+WSKVmF7pAZepEMak9lQo+tg9vC/8qMICMJkSx8yQ/NPsoGvQwA1w3mIZemIUjdVNcPKFG7QN1AVkek6r9rhxIAznQ; 25:ICxfiSe8goPSV+qNvlJ6A/2/wH9fJIwPq7N57//6R3/n8UCoK0wiJxzDq1507zvLMTjZSJltnf9zBpK9JoCSjOgTEhye2eWfe6st4t35/Q1Pwz3kBLVIhsZFf8XCwxdquWqpbjKoIBfSXbqEFaKvV7KZXq07BXMD/7sGsaiUTJuMGU1z20wa5iqzBZAwKBDgWPcELiUKxioSyTl0YMeinASgsI45+Q4auMfwMC3wzn1xLDXszFXjFFdnNS/6WzjCI6cQk9pNs66IwZArs/uWaB+jwJZm6xsJZr+tvk79+WvRLxb/oOKhmA6WUWA1HQ2tqgczY+iQ2clUZpdldOf2SQ==; 31:SjyP/fsJK7/547dKf9ODfpS5q3R83+4/Rq7I7FwY4DypSAJ/WdggVaVKBFWleHk8NY7gLV5MCYutsySFuihLs/x2JhriL5dlt5pssDbbz8j0NLQGrZULCY2HOJ+55TkblnGurgBIJsW6OADZgQQKRS2lqFYMPW7dq283z0RtafSgtgtL8mj+NtC4QPSE+GZYC9S6e3KD6N/zk/LC+3MK89XIarivO0NHhavrsOkM0A4= X-MS-TrafficTypeDiagnostic: AM2PR04MB0753: X-Microsoft-Exchange-Diagnostics: 1; AM2PR04MB0753; 20:MJFDtEUWjku1kwP0Yxhfdl0hYGpEQbUCHRejrlEAbl+ISQ3PxSjbQeTqpENUd1z4T25DvajwKhooJ+gUX/IH7KSp0OEEIvcNvhn3oIiKyes5EctKVUUYoBLyUaJzlK9H4VCZ31+FYIVVrl8ZGKgmz53RnML3SUp+0z2tWHhTNgNph6ORtzjA9wsCNhzTpCHtcoXgRSucDLpPdCnodmCGoMJjNcL6/yXuztTeGelVgkZ66QOoVk38EsP35+kWqQIlZiuwx/A74fVFtkykC+G56TZCtt1G7BCBL5GG8yKPcRJBb0aCZh5JcmLO619fqng1uK5zVgkkEv7Z2fm0DVJgFju9xs1+kMiIJWLUcza1/2fo1NA404x7sfk79d5dbl5Z9k6B4fSsVcEULQpTUM14PNmiOfj4HPhHnUbV5Jvfbgo5slMaHdBdYvEVxSAx7ixqlYg77w3YzsSENJagEoRvPWc+tLstSZI9LUHIyIkJ0aY5EgWdXcuk7CgkO9CYu2T1; 4:g5sgHbVxY8Yxywb5wEwvOOZpiWHNtNjGmfLSOEA8LGw+MbF20jUmvHgFaYbq6dxgd4hR0q03LS/497eP8Mu2Z5LjeC3E7d0ud+Mnb3R+d50E/n/heGJIc5nXyKQTkwdOYxqNGHsLNEP52cIrtv3Ldoxo7sNU4eN3Wra7ENKer+aPB2lWDUp9gxALiTMr4/h0J3VWGFrct1SBvVUkAFHPZ2yg96Y+f1QJqUk9pJDgFQDEWVLc82ToImy03Q1W29/dKPFd3ro6QlvvC5aCz2g40Ll27IU3Kd4crZVNZAufe+A+0UsZirrmTz61vR6iJqnt X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040501)(2401047)(8121501046)(5005006)(3002001)(3231220)(944501224)(52105095)(93006095)(93001095)(10201501046)(6055026)(6041288)(20161123558120)(20161123560045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(6072148)(201708071742011); SRVR:AM2PR04MB0753; BCL:0; PCL:0; RULEID:; SRVR:AM2PR04MB0753; X-Forefront-PRVS: 05986C03E0 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(376002)(396003)(39380400002)(366004)(346002)(39860400002)(199004)(189003)(7736002)(8676002)(26005)(16526019)(386003)(55236004)(106356001)(81166006)(50226002)(59450400001)(47776003)(81156014)(6506007)(66066001)(8936002)(16586007)(316002)(2906002)(4326008)(25786009)(6116002)(5660300001)(3846002)(186003)(86362001)(305945005)(6512007)(2950100002)(6666003)(97736004)(50466002)(48376002)(478600001)(5009440100003)(52116002)(36756003)(53936002)(68736007)(76176011)(51416003)(6486002)(105586002)(110426004); DIR:OUT; SFP:1101; SCL:1; SRVR:AM2PR04MB0753; H:bf-netperf1.ap.freescale.net; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; AM2PR04MB0753; 23:ZlV96RQeGFqNahJDv9QeIZtYXr3UIXzhLerh9+QA7?= 06D1lkokwB2EM76c3EaQli7IxM5HZ2F8Q3FIm3hzcnmTNmCc3oszvCU2ZUITeSdEgO7XTyksCgc4X3nIJFhraNmm4klWko2B4x1Dd5yRPmHJkaFdU7hD4Wrx2ku4BTv/Wkf7t1w8kFSNOLJMRWY7oNvWzE0/Kq24QdtNgTkb9C9fGVOkRM+crrMC4TKwnB3aDnwahB0BlZ4n9pkdsx0Jk+OqECnWl2HV6atZPyo/qZiY314R/3aX1FyFdqOZqZEX6YYBAKor6P7nuHPSSkMjwVzuuB7lsZGEHkcVfml5atQ/K676wmK8WYI2G9w37DbJtKS9qhoTuNcLCErV+zSkHCF2oCni3iyp1UyvUDEKMaTOP1LZYjbrHwFs3ifxovVKBhsdcdU44u3vllMLfhcRzd2tP8hiM0YMIVtgTZ/AlHCvZWHrYi5bHiybG3ZRPspa5Dk8smAxAVZBexEpIoUM8weE/wt0jltKJFANz9Vv9nFww173jLll78wf5QzhDb9QONfORLH3B+3u4jgiV2tMqyIqYXjh6NsAlxpaAScuVFQiK+6xCtWudEmcfy7Es7hO5I+E0+jEfXVmSOmTJ4DxmZFTksC0eX07uLAgpQNoqZK0GIQLRCo4IJsM8OmmgS47xtaq10hp0EQBpb8x9rx0tbktrfyFpuF/P3BYMO/6WirhAtUPuZbsqb3fH/0/pV+ZMjBlAMEO5o1pUaEBtNA45cstTVa6radOthf0XTTbhqkOCraUTMkHvkWbOZvrjk2rFjXd+SQeoWvGfyqlqDfs5WCqRzmqaqXIgZBQ6TxzwUhAnq7T4Ur/1wbQbVTHAwOu3ZxiW4Zvf77huQDLXKfI8XbXFS3Wc4fVXtHOPKcPxdw0oXaCUHjogXqTSbSaJxrkFBJOxXoiOLzEabQEZ54UkOailKOlkUJCQJ9TnQWYLlfow8rmzAzxVGWdK/jlRm6LU9E3Y1SkimA7fTosp4JTbSVWunG579JLR15MSY2SvOJd5C4t/IljGRigJWQhBU2YUmV0iqvGRqO5engcstULauVxyAqTVEo+5cxo6hl5G03ydbI2y+fOaOkHz6ALh7jGAqpyg7//C52VhlVUQwp28/L7f1+oK0hLLINJrTt7SzgViDrt00Y7xWAsQ4PILTgGW8= X-Microsoft-Exchange-Diagnostics: 1; AM2PR04MB0753; 6:kWh8KW3td3V66bmKoSmuDu/rb4R+aul0748prpW7adyYdwJBi1j/dux00w7IDCZ/XZOaaROgVm4/dpguZPakTbPQPWBFFvB2RLjtVWrYRqkGdnZNsMIVceUYTtK4wjge5aYyhR0DXH/A9F2AI1ppq0Y+SmMo4xU5DkzwZ3JMj7ZtZ3hffqEyVxumZuhyx4P1inI5pHJe6lj0PJg3itTIPbrSEXokikInHnXhyKlwUd6AAxziaHV0PDLsLklIXzHR4+KifTa5iFCjVbLRajQuuiYkxIn3rZg+klGD4sMK+oSXj/RQ4p7r03uqk3b8gJubs6jzGjdBnTK2lAAgGmoAFKKJGTqYdEuzFYYWzE8fcpI=; 5:WA8Pn4x1if1JTQGy84aFhCETWhffZaPkyBrVD3NDj0kQBwJGnWs6aVlSilFjcoUQ1vGIT5SFIresJXH9eKLBKuYEHaoPk3LoWGxHdk+GYsEgpllaJmVNf8MhMlttmoQ+87Is1Ni9ASiRZozGfsThpGf6ESAAocX/kE/Xi+zwmfk=; 24:X8HuH6/trJIwUAlhRu7XmnN1j4btVVuzxbD4GA+6kobQDhpgwp2JUlHJyvR91xTX9Z7rIbeOVuvk2bHIBfK6SW5F3o/QyMP9EFyYEqe2dxM=; 7:lN193KiXl8gRbdyU3jWz/BdtUsZnbG74juLXnx6dWJ1QV5IP7q5EtED6iFRlslro2O3tAd37RbKPkO1xPdmbmEh2UQXAI0uBhCZ8fBN/zuozjL9bda8QsQDpuyixFgj82D7SEi5YH3OUaR5wKm1VmVRzUwwr1xfzF+CSiJPdGGk9xIExbyBVVwbzxHpC5Lojnu6fqZzx8Ye1PdtRFSYImWzKGDr8Rk4nO8tzcWsfbOtKz/ti4ZFcDLFKxpjRh2PU SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Mar 2018 07:34:57.2872 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a019407c-311a-4298-83dc-08d57f46ef4b X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM2PR04MB0753 Subject: [dpdk-dev] [PATCH v2 02/10] bus/dpaa: fix the BE compilation issue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The array pointers were used without index. Fixes: b9083ea5e084 ("net/dpaa: further push mode optimizations") Cc: stable@dpdk.org Signed-off-by: Hemant Agrawal --- drivers/bus/dpaa/base/qbman/qman.c | 5 +++-- drivers/bus/dpaa/base/qbman/qman_driver.c | 5 +---- 2 files changed, 4 insertions(+), 6 deletions(-) -- 2.7.4 Acked-by: Shreyansh Jain diff --git a/drivers/bus/dpaa/base/qbman/qman.c b/drivers/bus/dpaa/base/qbman/qman.c index 2b97671..2810fdd 100644 --- a/drivers/bus/dpaa/base/qbman/qman.c +++ b/drivers/bus/dpaa/base/qbman/qman.c @@ -1087,7 +1087,7 @@ unsigned int qman_portal_poll_rx(unsigned int poll_limit, shadow[rx_number]->fd.opaque = be32_to_cpu(dq[rx_number]->fd.opaque); #else - shadow = dq; + shadow[rx_number] = dq[rx_number]; #endif /* SDQCR: context_b points to the FQ */ @@ -1095,7 +1095,8 @@ unsigned int qman_portal_poll_rx(unsigned int poll_limit, fq[rx_number] = qman_fq_lookup_table[be32_to_cpu( dq[rx_number]->contextB)]; #else - fq[rx_number] = (void *)(uintptr_t)be32_to_cpu(dq->contextB); + fq[rx_number] = (void *)be32_to_cpu( + dq[rx_number]->contextB); #endif fq[rx_number]->cb.dqrr_prepare(shadow[rx_number], &bufs[rx_number]); diff --git a/drivers/bus/dpaa/base/qbman/qman_driver.c b/drivers/bus/dpaa/base/qbman/qman_driver.c index 7cfa8ee..66838d2 100644 --- a/drivers/bus/dpaa/base/qbman/qman_driver.c +++ b/drivers/bus/dpaa/base/qbman/qman_driver.c @@ -246,7 +246,6 @@ int fsl_qman_portal_destroy(struct qman_portal *qp) int qman_global_init(void) { const struct device_node *dt_node; - int ret = 0; size_t lenp; const u32 *chanid; static int ccsr_map_fd; @@ -352,9 +351,7 @@ int qman_global_init(void) qman_clk = be32_to_cpu(*clk); #ifdef CONFIG_FSL_QMAN_FQ_LOOKUP - ret = qman_setup_fq_lookup_table(CONFIG_FSL_QMAN_FQ_LOOKUP_MAX); - if (ret) - return ret; + return qman_setup_fq_lookup_table(CONFIG_FSL_QMAN_FQ_LOOKUP_MAX); #endif return 0; }