[v2,08/10] config: add dpaaX build support in common linuxapp

Message ID 1519889597-5805-9-git-send-email-hemant.agrawal@nxp.com
State New
Headers show
Series
  • meson build support for dpaaX
Related show

Commit Message

Hemant Agrawal March 1, 2018, 7:33 a.m.
Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>

---
 config/common_armv8a_linuxapp | 58 -------------------------------------------
 config/common_linuxapp        | 37 +++++++++++++++++++++++++++
 2 files changed, 37 insertions(+), 58 deletions(-)

-- 
2.7.4

Comments

Thomas Monjalon March 9, 2018, 5:11 p.m. | #1
Hi,

As you know the config options should be declared in common_base
and overwritten in common_linuxapp.

That's why there is no need to add comments in common_linuxapp.
And some of the options should be only in common_base, like
	CONFIG_RTE_LIBRTE_DPAA_HWDEBUG=n

Please try to move all the options in common_base with their comments,
and only overwrite what is needed for Linux compilation.

Thanks


01/03/2018 08:33, Hemant Agrawal:
> --- a/config/common_linuxapp

> +++ b/config/common_linuxapp

> @@ -23,3 +23,40 @@ CONFIG_RTE_LIBRTE_NFP_PMD=y

>  CONFIG_RTE_LIBRTE_POWER=y

>  CONFIG_RTE_VIRTIO_USER=y

>  CONFIG_RTE_PROC_INFO=y

> +#

> +# ARMv8 Specific driver compilation flags

> +#

> +

> +# Compile NXP DPAA Bus

> +CONFIG_RTE_LIBRTE_DPAA_BUS=y

> +CONFIG_RTE_LIBRTE_DPAA_HWDEBUG=n

> +

> +# Compile NXP DPAA Mempool

> +CONFIG_RTE_LIBRTE_DPAA_MEMPOOL=y

> +

> +# Compile bust-oriented NXP DPAA PMD

> +CONFIG_RTE_LIBRTE_DPAA_PMD=y

> +

> +# Compile schedule-oriented NXP DPAA Event Dev PMD

> +CONFIG_RTE_LIBRTE_PMD_DPAA_EVENTDEV=y

> +

> +# Compile NXP DPAA caam - crypto driver

> +CONFIG_RTE_LIBRTE_PMD_DPAA_SEC=y

> +CONFIG_RTE_LIBRTE_DPAA_MAX_CRYPTODEV=4

> +CONFIG_RTE_DPAA_SEC_PMD_MAX_NB_SESSIONS=2048

> +

> +# Compile NXP DPAA2 FSL-MC Bus

> +CONFIG_RTE_LIBRTE_FSLMC_BUS=y

> +

> +# Compile NXP DPAA2 Mempool

> +CONFIG_RTE_LIBRTE_DPAA2_MEMPOOL=y

> +

> +# Compile burst-oriented NXP DPAA2 PMD driver

> +CONFIG_RTE_LIBRTE_DPAA2_PMD=y

> +

> +# Compile schedule-oriented NXP DPAA2 EVENTDEV driver

> +CONFIG_RTE_LIBRTE_PMD_DPAA2_EVENTDEV=y

> +

> +# Compile NXP DPAA2 crypto sec driver for CAAM HW

> +CONFIG_RTE_LIBRTE_PMD_DPAA2_SEC=y

> +CONFIG_RTE_DPAA2_SEC_PMD_MAX_NB_SESSIONS=2048
Hemant Agrawal March 9, 2018, 5:22 p.m. | #2
Hi Thomas,
> 

> As you know the config options should be declared in common_base and

> overwritten in common_linuxapp.

> 

> That's why there is no need to add comments in common_linuxapp.

> And some of the options should be only in common_base, like

> 	CONFIG_RTE_LIBRTE_DPAA_HWDEBUG=n

> 

> Please try to move all the options in common_base with their comments, and

> only overwrite what is needed for Linux compilation.

> 

[Hemant] Thanks for the review.  I will fix these in v3.

Regards,
Hemant 

> Thanks

> 

> 

> 01/03/2018 08:33, Hemant Agrawal:

> > --- a/config/common_linuxapp

> > +++ b/config/common_linuxapp

> > @@ -23,3 +23,40 @@ CONFIG_RTE_LIBRTE_NFP_PMD=y

> > CONFIG_RTE_LIBRTE_POWER=y  CONFIG_RTE_VIRTIO_USER=y

> > CONFIG_RTE_PROC_INFO=y

> > +#

> > +# ARMv8 Specific driver compilation flags #

> > +

> > +# Compile NXP DPAA Bus

> > +CONFIG_RTE_LIBRTE_DPAA_BUS=y

> > +CONFIG_RTE_LIBRTE_DPAA_HWDEBUG=n

> > +

> > +# Compile NXP DPAA Mempool

> > +CONFIG_RTE_LIBRTE_DPAA_MEMPOOL=y

> > +

> > +# Compile bust-oriented NXP DPAA PMD

> > +CONFIG_RTE_LIBRTE_DPAA_PMD=y

> > +

> > +# Compile schedule-oriented NXP DPAA Event Dev PMD

> > +CONFIG_RTE_LIBRTE_PMD_DPAA_EVENTDEV=y

> > +

> > +# Compile NXP DPAA caam - crypto driver

> > +CONFIG_RTE_LIBRTE_PMD_DPAA_SEC=y

> > +CONFIG_RTE_LIBRTE_DPAA_MAX_CRYPTODEV=4

> > +CONFIG_RTE_DPAA_SEC_PMD_MAX_NB_SESSIONS=2048

> > +

> > +# Compile NXP DPAA2 FSL-MC Bus

> > +CONFIG_RTE_LIBRTE_FSLMC_BUS=y

> > +

> > +# Compile NXP DPAA2 Mempool

> > +CONFIG_RTE_LIBRTE_DPAA2_MEMPOOL=y

> > +

> > +# Compile burst-oriented NXP DPAA2 PMD driver

> > +CONFIG_RTE_LIBRTE_DPAA2_PMD=y

> > +

> > +# Compile schedule-oriented NXP DPAA2 EVENTDEV driver

> > +CONFIG_RTE_LIBRTE_PMD_DPAA2_EVENTDEV=y

> > +

> > +# Compile NXP DPAA2 crypto sec driver for CAAM HW

> > +CONFIG_RTE_LIBRTE_PMD_DPAA2_SEC=y

> > +CONFIG_RTE_DPAA2_SEC_PMD_MAX_NB_SESSIONS=2048

> 

> 

>

Patch

diff --git a/config/common_armv8a_linuxapp b/config/common_armv8a_linuxapp
index 507b28a..111c005 100644
--- a/config/common_armv8a_linuxapp
+++ b/config/common_armv8a_linuxapp
@@ -36,61 +36,3 @@  CONFIG_RTE_LIBRTE_SFC_EFX_PMD=n
 CONFIG_RTE_LIBRTE_AVP_PMD=n
 
 CONFIG_RTE_SCHED_VECTOR=n
-
-#
-# ARMv8 Specific driver compilation flags
-#
-
-#
-# Compile NXP DPAA Bus
-#
-CONFIG_RTE_LIBRTE_DPAA_BUS=y
-CONFIG_RTE_LIBRTE_DPAA_HWDEBUG=n
-
-#
-# Compile NXP DPAA2 FSL-MC Bus
-#
-CONFIG_RTE_LIBRTE_FSLMC_BUS=y
-
-#
-# Compile NXP DPAA Mempool
-#
-CONFIG_RTE_LIBRTE_DPAA_MEMPOOL=y
-
-#
-# Compile NXP DPAA2 Mempool
-#
-CONFIG_RTE_LIBRTE_DPAA2_MEMPOOL=y
-
-#
-# Compile bust-oriented NXP DPAA PMD
-#
-CONFIG_RTE_LIBRTE_DPAA_PMD=y
-
-#
-# Compile burst-oriented NXP DPAA2 PMD driver
-#
-CONFIG_RTE_LIBRTE_DPAA2_PMD=y
-
-#
-# Compile schedule-oriented NXP DPAA Event Dev PMD
-#
-CONFIG_RTE_LIBRTE_PMD_DPAA_EVENTDEV=y
-
-#
-# Compile schedule-oriented NXP DPAA2 EVENTDEV driver
-#
-CONFIG_RTE_LIBRTE_PMD_DPAA2_EVENTDEV=y
-
-#
-# Compile NXP DPAA caam - crypto driver
-#
-CONFIG_RTE_LIBRTE_PMD_DPAA_SEC=y
-CONFIG_RTE_LIBRTE_DPAA_MAX_CRYPTODEV=4
-CONFIG_RTE_DPAA_SEC_PMD_MAX_NB_SESSIONS=2048
-
-#
-# Compile NXP DPAA2 crypto sec driver for CAAM HW
-#
-CONFIG_RTE_LIBRTE_PMD_DPAA2_SEC=y
-CONFIG_RTE_DPAA2_SEC_PMD_MAX_NB_SESSIONS=2048
diff --git a/config/common_linuxapp b/config/common_linuxapp
index ff98f23..275c033 100644
--- a/config/common_linuxapp
+++ b/config/common_linuxapp
@@ -23,3 +23,40 @@  CONFIG_RTE_LIBRTE_NFP_PMD=y
 CONFIG_RTE_LIBRTE_POWER=y
 CONFIG_RTE_VIRTIO_USER=y
 CONFIG_RTE_PROC_INFO=y
+#
+# ARMv8 Specific driver compilation flags
+#
+
+# Compile NXP DPAA Bus
+CONFIG_RTE_LIBRTE_DPAA_BUS=y
+CONFIG_RTE_LIBRTE_DPAA_HWDEBUG=n
+
+# Compile NXP DPAA Mempool
+CONFIG_RTE_LIBRTE_DPAA_MEMPOOL=y
+
+# Compile bust-oriented NXP DPAA PMD
+CONFIG_RTE_LIBRTE_DPAA_PMD=y
+
+# Compile schedule-oriented NXP DPAA Event Dev PMD
+CONFIG_RTE_LIBRTE_PMD_DPAA_EVENTDEV=y
+
+# Compile NXP DPAA caam - crypto driver
+CONFIG_RTE_LIBRTE_PMD_DPAA_SEC=y
+CONFIG_RTE_LIBRTE_DPAA_MAX_CRYPTODEV=4
+CONFIG_RTE_DPAA_SEC_PMD_MAX_NB_SESSIONS=2048
+
+# Compile NXP DPAA2 FSL-MC Bus
+CONFIG_RTE_LIBRTE_FSLMC_BUS=y
+
+# Compile NXP DPAA2 Mempool
+CONFIG_RTE_LIBRTE_DPAA2_MEMPOOL=y
+
+# Compile burst-oriented NXP DPAA2 PMD driver
+CONFIG_RTE_LIBRTE_DPAA2_PMD=y
+
+# Compile schedule-oriented NXP DPAA2 EVENTDEV driver
+CONFIG_RTE_LIBRTE_PMD_DPAA2_EVENTDEV=y
+
+# Compile NXP DPAA2 crypto sec driver for CAAM HW
+CONFIG_RTE_LIBRTE_PMD_DPAA2_SEC=y
+CONFIG_RTE_DPAA2_SEC_PMD_MAX_NB_SESSIONS=2048