From patchwork Thu Mar 1 15:27:05 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sasha Levin X-Patchwork-Id: 130269 Delivered-To: patch@linaro.org Received: by 10.80.172.228 with SMTP id x91csp2951585edc; Thu, 1 Mar 2018 07:37:49 -0800 (PST) X-Google-Smtp-Source: AG47ELtOHzmshkr6iVLwAMByCSzCRaSl4U5HGN3oYwfJFVeqobSCvXAHFIOPMPIU3qiT9/MvgnFQ X-Received: by 10.99.6.85 with SMTP id 82mr1842391pgg.181.1519918669358; Thu, 01 Mar 2018 07:37:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519918669; cv=none; d=google.com; s=arc-20160816; b=gWTdrq12VjGjH7VCxD7vu2Gsx4gFCqrOfnEHhQU3O/zd+Gv57ytMDuB5caWpcCG1wF G4rNe4jFLYLmo5YYBB8C5IZ/Uql9kN55C5jAULeLqSzLGEAlOLDKxzgClz6UGddCzVKg qyq3GV0pADJ7NCaca61621XLVk5hW/gSJ1ZZBJyqsBZY8vaThL2PMDvW+CaOfXwv+Rsc a1I5RVWYvXAMzFxwdmMapclRRayot6UzVH/bSTnnLjGhpaqbQvwqt6pUrQNvWCaOrmMg aDaZ2aeWKc43r35XVEnyKZYtbiiMkZSIHWBQpwjvcLlt4fWFKffefMsZlFgL8Em3s2Y3 zSDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :spamdiagnosticmetadata:spamdiagnosticoutput:content-language :accept-language:in-reply-to:references:message-id:date:thread-index :thread-topic:subject:cc:to:from:dkim-signature :arc-authentication-results; bh=9tu4uVPCQ6p9YgdatmArMo098tdxQEUhVA6R+ksaTB0=; b=0nvwN6A5Pr4scyr3+/tQeX7rMv80vLrnupNkTNjGrFkkuaBp4Q9f687OK1BaBSB4BA I3UpCeU63MXuZh6nAMQVUHocE6oCCkcoYp43zZPtyxDpS+/4e5yZi92yZzXLqqiLfDIE rQpKTx4mETalZ9VkbByC9Q6+7+OfygXEcdC9V/AkGE0/ElHIofIbNyzz4UKCSQwuGl16 rj3qlsvWmFSFpIJVOGoTHX+w9Xlinxy//XqoMFxbTq3i0o63p/OnobT4OXAkBmqwdBfV /VwljZKMSDadNrNcmTeo+R6XmPgpvZOamcu8p4tyB5omvlBgpRqZSlLyZ6APyy8U3bCy sUag== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@microsoft.com header.s=selector1 header.b=iT4omIBd; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=microsoft.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g10-v6si2863008plk.730.2018.03.01.07.37.49; Thu, 01 Mar 2018 07:37:49 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@microsoft.com header.s=selector1 header.b=iT4omIBd; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=microsoft.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1032527AbeCAPhr (ORCPT + 10 others); Thu, 1 Mar 2018 10:37:47 -0500 Received: from mail-by2nam03on0132.outbound.protection.outlook.com ([104.47.42.132]:24496 "EHLO NAM03-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1032511AbeCAPhl (ORCPT ); Thu, 1 Mar 2018 10:37:41 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=9tu4uVPCQ6p9YgdatmArMo098tdxQEUhVA6R+ksaTB0=; b=iT4omIBdxPGS5v6mmSpSXWJE6yF1acXGPJ5GEOmT6yex7Fhn67tTTomrLdf46mextnbzqVtMMzQmsyW7eswDQzDeo1hyl9JMTGv+O8Gsq8czVTTjYb2UhoksyplE9H3o/CJfhkILRxZO2Js30Qaqo2zW7Un3tiKaSLC4AQe4pj0= Received: from DM5PR2101MB1032.namprd21.prod.outlook.com (52.132.128.13) by DM5PR2101MB1014.namprd21.prod.outlook.com (52.132.133.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.567.3; Thu, 1 Mar 2018 15:37:38 +0000 Received: from DM5PR2101MB1032.namprd21.prod.outlook.com ([fe80::8063:c68a:b210:7446]) by DM5PR2101MB1032.namprd21.prod.outlook.com ([fe80::8063:c68a:b210:7446%2]) with mapi id 15.20.0567.006; Thu, 1 Mar 2018 15:37:38 +0000 From: Sasha Levin To: "stable@vger.kernel.org" , "stable-commits@vger.kernel.org" CC: Arnd Bergmann , "David S . Miller" , Sasha Levin Subject: [added to the 4.1 stable tree] vmxnet3: prevent building with 64K pages Thread-Topic: [added to the 4.1 stable tree] vmxnet3: prevent building with 64K pages Thread-Index: AQHTsXHB2oNOw9R5A0CLiRi2KyLWTw== Date: Thu, 1 Mar 2018 15:27:05 +0000 Message-ID: <20180301152116.1486-429-alexander.levin@microsoft.com> References: <20180301152116.1486-1-alexander.levin@microsoft.com> In-Reply-To: <20180301152116.1486-1-alexander.levin@microsoft.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [52.168.54.252] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DM5PR2101MB1014; 7:XktIMAQdsb8yeBGFAPvdnr5zdDug5poDWVKn0uW7DnxiZ/K3tUaDZzCPVgcMAqszY02XzSTBG7iuhTrmrJJYhn7uks0x3ohtdj8MAxJhIUovS9QXF2mN8myxsnuAuTBHVVtfm8DbXrTGj0zvTiPI954aORCf4BVorEEViljUisJMgNC3f0dYgC/80rCf7cKnH6GBP2fcVNsteEp8K2pPzhgClH/UiS9svYrrBW4IB7ptGKFGnF8JZQX9KZFdxW7o x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: b19013a6-ad2a-4bfc-001c-08d57f8a5cb9 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(48565401081)(5600026)(4604075)(3008032)(2017052603307)(7193020); SRVR:DM5PR2101MB1014; x-ms-traffictypediagnostic: DM5PR2101MB1014: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(28532068793085)(89211679590171); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(61425038)(6040501)(2401047)(8121501046)(5005006)(3231220)(944501228)(52105095)(3002001)(10201501046)(93006095)(93001095)(6055026)(61426038)(61427038)(6041288)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123564045)(20161123558120)(6072148)(201708071742011); SRVR:DM5PR2101MB1014; BCL:0; PCL:0; RULEID:; SRVR:DM5PR2101MB1014; x-forefront-prvs: 05986C03E0 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(366004)(39380400002)(346002)(39860400002)(376002)(396003)(199004)(189003)(53936002)(2906002)(3280700002)(6436002)(6486002)(3846002)(6512007)(2900100001)(6116002)(2950100002)(107886003)(6666003)(72206003)(5660300001)(36756003)(10090500001)(3660700001)(14454004)(7736002)(305945005)(97736004)(1076002)(22452003)(26005)(6506007)(105586002)(86362001)(575784001)(59450400001)(478600001)(68736007)(102836004)(4326008)(6346003)(54906003)(110136005)(81156014)(81166006)(86612001)(8936002)(186003)(10290500003)(8676002)(76176011)(316002)(2501003)(66066001)(25786009)(5250100002)(106356001)(99286004)(22906009); DIR:OUT; SFP:1102; SCL:1; SRVR:DM5PR2101MB1014; H:DM5PR2101MB1032.namprd21.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; received-spf: None (protection.outlook.com: microsoft.com does not designate permitted sender hosts) authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alexander.Levin@microsoft.com; x-microsoft-antispam-message-info: aHKHVhnwgIpVMvRcADy/b819mfG4H3rcg0hZm6ckg78bL7PD94AtKnY4Y0WqCViFAwl5ALxAz0UocDMAZCnQgSi2lTMvnEh9iP4YUYRYPHx9lC2/GTHERge40A7EwO42sHCFcn4R/+Fq9ao5R/n7MP41yiiO8J22GIx9Ivfvxy0= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: b19013a6-ad2a-4bfc-001c-08d57f8a5cb9 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Mar 2018 15:27:05.4647 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR2101MB1014 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Arnd Bergmann This patch has been added to the 4.1 stable tree. If you have any objections, please let us know. -- 2.14.1 =============== [ Upstream commit fbdf0e28d061708cf18ba0f8e0db5360dc9a15b9 ] I got a warning about broken code on ARM64 with 64K pages: drivers/net/vmxnet3/vmxnet3_drv.c: In function 'vmxnet3_rq_init': drivers/net/vmxnet3/vmxnet3_drv.c:1679:29: error: large integer implicitly truncated to unsigned type [-Werror=overflow] rq->buf_info[0][i].len = PAGE_SIZE; 'len' here is a 16-bit integer, so this clearly won't work. I don't think this driver is used much on anything other than x86, so there is no need to fix this properly and we can work around it with a Kconfig dependency to forbid known-broken configurations. qemu in theory supports it on other architectures too, but presumably only for compatibility with x86 guests that also run on vmware. CONFIG_PAGE_SIZE_64KB is used on hexagon, mips, sh and tile, the other symbols are architecture-specific names for the same thing. Signed-off-by: Arnd Bergmann Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/Kconfig | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig index df51d6025a90..0eeb248a287e 100644 --- a/drivers/net/Kconfig +++ b/drivers/net/Kconfig @@ -374,6 +374,9 @@ config XEN_NETDEV_BACKEND config VMXNET3 tristate "VMware VMXNET3 ethernet driver" depends on PCI && INET + depends on !(PAGE_SIZE_64KB || ARM64_64K_PAGES || \ + IA64_PAGE_SIZE_64KB || MICROBLAZE_64K_PAGES || \ + PARISC_PAGE_SIZE_64KB || PPC_64K_PAGES) help This driver supports VMware's vmxnet3 virtual ethernet NIC. To compile this driver as a module, choose M here: the