From patchwork Thu Mar 1 15:27:29 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sasha Levin X-Patchwork-Id: 130294 Delivered-To: patch@linaro.org Received: by 10.80.172.228 with SMTP id x91csp2952812edc; Thu, 1 Mar 2018 07:38:51 -0800 (PST) X-Google-Smtp-Source: AG47ELs0G2OT51vWSA7BXL0YzFM5GcKrpR69LN9CxgYEi/D1hHF6PkAjSFBB527Wuai4aRowJSyv X-Received: by 10.98.89.85 with SMTP id n82mr2309769pfb.233.1519918731104; Thu, 01 Mar 2018 07:38:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519918731; cv=none; d=google.com; s=arc-20160816; b=C0dRzSzjJzZhLYUSzz+eaXGgrptSNhpvxUm2VgMI/vKtTzAxyjo8iz02L38gFTQ9yM 547PaAzcB2waFjzrmZU5+avUGCHFTDwJCnimP1ov2OAM4EXOKzDYxQwSPMZH223UBYfu B1kMUWWOjx2pFMPWlmuc8k5rCSX3KzIkyZ5SjFyonFDizs1J15XJL9RlXD3FyzWSW3Ux xTwyO0gdhhC/06jMw7p1AfnF4Q1PZoziFyuxWy/98+juKNU4qeZcnb5/r5zRCgam3ruC uOmhRCQzfBImu3AJ1UC8sWeXqPMqgdoQH8z+yihY6X4wLwHGIzfzfgIJbRx56qFdNzEv ItpQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :spamdiagnosticmetadata:spamdiagnosticoutput:content-language :accept-language:in-reply-to:references:message-id:date:thread-index :thread-topic:subject:cc:to:from:dkim-signature :arc-authentication-results; bh=Ib35VtEuJSvPK6YzcRZ81YfXTXni1wOhNdIpCGbbr+8=; b=AZXAXVTsEHNOACxVR0wz4cvFxDnGzD9naS/2CFZa6HHlyUX/XmFo2/jZ3ta3oldSXr jlW8M80yukIWG90sDmdS6XWUGk+hWeHFvp3G/g2qBsJNuFOtM/uJhL5OM54aa/MGvQpN ANnDRi/+Cq/DyfSqUUc/lyMujkk1MS1W9pYKvPwcp+D1PArcWsLx9mLHsVXvDuhQo5ny 1hdeFrbefzM1IYNXjfoCzz7wX5GM4L0MLDCCKoWRut636ZUrA72c+egvVJvDztdef/jY fX6UuVzHFZxdGmuaqzts0KiV5FfAmWiJFsDvAxBU2bDey0Z3UHo+xatNBNloQHGCwN5s M9Fg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@microsoft.com header.s=selector1 header.b=aBpu5ovp; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=microsoft.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b15si2586092pgs.318.2018.03.01.07.38.50; Thu, 01 Mar 2018 07:38:51 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@microsoft.com header.s=selector1 header.b=aBpu5ovp; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=microsoft.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1032560AbeCAPis (ORCPT + 10 others); Thu, 1 Mar 2018 10:38:48 -0500 Received: from mail-sn1nam02on0103.outbound.protection.outlook.com ([104.47.36.103]:11220 "EHLO NAM02-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1032568AbeCAPig (ORCPT ); Thu, 1 Mar 2018 10:38:36 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=Ib35VtEuJSvPK6YzcRZ81YfXTXni1wOhNdIpCGbbr+8=; b=aBpu5ovpp6QCl0cge13+rGz7FpJyBuTFkLk/M33qyX68ISZDfDNT8txeRxDzeOZoo+qJNKZLZE0oKwI68aqPMyrqrOfdRAQYdfhD8YQFmQmnIork0ev2zfCNags1yVqfJmQbfgh8OHaXpkVHz/rkW4viN0B0veMF5nkcADwAHgA= Received: from DM5PR2101MB1032.namprd21.prod.outlook.com (52.132.128.13) by DM5PR2101MB1016.namprd21.prod.outlook.com (52.132.133.38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.567.2; Thu, 1 Mar 2018 15:38:30 +0000 Received: from DM5PR2101MB1032.namprd21.prod.outlook.com ([fe80::8063:c68a:b210:7446]) by DM5PR2101MB1032.namprd21.prod.outlook.com ([fe80::8063:c68a:b210:7446%2]) with mapi id 15.20.0567.006; Thu, 1 Mar 2018 15:38:30 +0000 From: Sasha Levin To: "stable@vger.kernel.org" , "stable-commits@vger.kernel.org" CC: Arnd Bergmann , Tomi Valkeinen , Sasha Levin Subject: [added to the 4.1 stable tree] fbdev: s6e8ax0: avoid unused function warnings Thread-Topic: [added to the 4.1 stable tree] fbdev: s6e8ax0: avoid unused function warnings Thread-Index: AQHTsXHP/3gosb2PGE2PDH4yd0BAhw== Date: Thu, 1 Mar 2018 15:27:29 +0000 Message-ID: <20180301152116.1486-466-alexander.levin@microsoft.com> References: <20180301152116.1486-1-alexander.levin@microsoft.com> In-Reply-To: <20180301152116.1486-1-alexander.levin@microsoft.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [52.168.54.252] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DM5PR2101MB1016; 7:LwpGZ6heU2nBlpMK6NSgTLxsW1EmSH9jI5imeWd5rtyY47NQ6cAtX0u5z/7qQFGBlK5WBmWsx6W+9LlqfJv5XfWvrjFWr1P+DMDTjGLFFkPmoO4hc84xQSS6XOpaIByGV/ltJclfDKfmM+ofUFifeHvK8Fcw1Ai6ekDYJ7/j2kGjsJUin4lVs45kLeYwjSmCD9KtZ40CrbQWx73IFySVp1sXX8PH5fVbhXOCPRQY0BT6xSuvxPwykoyNuwrQ1t0E x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: f49e299f-026e-4439-4f23-08d57f8a7bb7 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(48565401081)(5600026)(4604075)(3008032)(2017052603307)(7193020); SRVR:DM5PR2101MB1016; x-ms-traffictypediagnostic: DM5PR2101MB1016: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(28532068793085)(31051911155226)(89211679590171)(7411616537696)(17755550239193); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(61425038)(6040501)(2401047)(5005006)(8121501046)(3002001)(93006095)(93001095)(10201501046)(3231220)(944501229)(52105095)(6055026)(61426038)(61427038)(6041288)(20161123560045)(20161123558120)(20161123564045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011); SRVR:DM5PR2101MB1016; BCL:0; PCL:0; RULEID:; SRVR:DM5PR2101MB1016; x-forefront-prvs: 05986C03E0 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(346002)(366004)(39860400002)(39380400002)(376002)(396003)(189003)(199004)(22452003)(6436002)(8676002)(81156014)(81166006)(53936002)(68736007)(6486002)(6512007)(97736004)(5660300001)(86362001)(59450400001)(6506007)(102836004)(6346003)(2906002)(26005)(186003)(4326008)(10290500003)(8936002)(76176011)(478600001)(105586002)(3280700002)(14454004)(54906003)(110136005)(3660700001)(2950100002)(305945005)(7736002)(6116002)(72206003)(1076002)(3846002)(316002)(2900100001)(25786009)(36756003)(2501003)(66066001)(107886003)(106356001)(5250100002)(86612001)(99286004)(10090500001)(22906009); DIR:OUT; SFP:1102; SCL:1; SRVR:DM5PR2101MB1016; H:DM5PR2101MB1032.namprd21.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; received-spf: None (protection.outlook.com: microsoft.com does not designate permitted sender hosts) authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alexander.Levin@microsoft.com; x-microsoft-antispam-message-info: SG8HDxGddUspJtKigJy/ODAT2Mk5fUaBS7lUGKQvpGB5zRPunbnAx+QQwN3GoLPUHehJUx1hMq6zhsa+U8ZIfDeqYv3EvdAizR7P/wv4MGf3MzPmxnTypTsuxX9y1BZdf1yiKevjDiQ+ezU7BuWjvyUs5qF9BqBSGVvhEt+Qnos= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: f49e299f-026e-4439-4f23-08d57f8a7bb7 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Mar 2018 15:27:29.2264 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR2101MB1016 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Arnd Bergmann This patch has been added to the 4.1 stable tree. If you have any objections, please let us know. -- 2.14.1 =============== [ Upstream commit b54729b6cea7d1f46b1ed70cb7065c6bdefaa780 ] The s6e8ax0 suspend/resume functions are hidden inside of an #ifdef when CONFIG_PM is set to avoid unused function warnings, but they call some other functions that nothing else calls, and we get warnings about those: drivers/video/fbdev/exynos/s6e8ax0.c:449:13: error: 's6e8ax0_sleep_in' defined but not used [-Werror=unused-function] drivers/video/fbdev/exynos/s6e8ax0.c:485:13: error: 's6e8ax0_display_off' defined but not used [-Werror=unused-function] This marks the PM functions as __maybe_unused so the compiler can silently drop them when they are not referenced. Signed-off-by: Arnd Bergmann Reviewed-by: Krzysztof Kozlowski Signed-off-by: Tomi Valkeinen Signed-off-by: Sasha Levin --- drivers/video/fbdev/exynos/s6e8ax0.c | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/drivers/video/fbdev/exynos/s6e8ax0.c b/drivers/video/fbdev/exynos/s6e8ax0.c index 95873f26e39c..de2f3e793786 100644 --- a/drivers/video/fbdev/exynos/s6e8ax0.c +++ b/drivers/video/fbdev/exynos/s6e8ax0.c @@ -829,8 +829,7 @@ static int s6e8ax0_probe(struct mipi_dsim_lcd_device *dsim_dev) return 0; } -#ifdef CONFIG_PM -static int s6e8ax0_suspend(struct mipi_dsim_lcd_device *dsim_dev) +static int __maybe_unused s6e8ax0_suspend(struct mipi_dsim_lcd_device *dsim_dev) { struct s6e8ax0 *lcd = dev_get_drvdata(&dsim_dev->dev); @@ -843,7 +842,7 @@ static int s6e8ax0_suspend(struct mipi_dsim_lcd_device *dsim_dev) return 0; } -static int s6e8ax0_resume(struct mipi_dsim_lcd_device *dsim_dev) +static int __maybe_unused s6e8ax0_resume(struct mipi_dsim_lcd_device *dsim_dev) { struct s6e8ax0 *lcd = dev_get_drvdata(&dsim_dev->dev); @@ -855,10 +854,6 @@ static int s6e8ax0_resume(struct mipi_dsim_lcd_device *dsim_dev) return 0; } -#else -#define s6e8ax0_suspend NULL -#define s6e8ax0_resume NULL -#endif static struct mipi_dsim_lcd_driver s6e8ax0_dsim_ddi_driver = { .name = "s6e8ax0", @@ -867,8 +862,8 @@ static struct mipi_dsim_lcd_driver s6e8ax0_dsim_ddi_driver = { .power_on = s6e8ax0_power_on, .set_sequence = s6e8ax0_set_sequence, .probe = s6e8ax0_probe, - .suspend = s6e8ax0_suspend, - .resume = s6e8ax0_resume, + .suspend = IS_ENABLED(CONFIG_PM) ? s6e8ax0_suspend : NULL, + .resume = IS_ENABLED(CONFIG_PM) ? s6e8ax0_resume : NULL, }; static int s6e8ax0_init(void)