Applied "ASoC: rt5651: Use standard component set_jack callback" to the asoc tree

Message ID E1erSbS-0005qA-HS@debutante
State Accepted
Commit 6f0b819ae2b36614a514824c622ac0e02650b718
Headers show
  • Applied "ASoC: rt5651: Use standard component set_jack callback" to the asoc tree
Related show

Commit Message

Mark Brown March 1, 2018, 6:06 p.m.
The patch

   ASoC: rt5651: Use standard component set_jack callback

has been applied to the asoc tree at 

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.  

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.


From 6f0b819ae2b36614a514824c622ac0e02650b718 Mon Sep 17 00:00:00 2001
From: Hans de Goede <>

Date: Sun, 25 Feb 2018 11:46:45 +0100
Subject: [PATCH] ASoC: rt5651: Use standard component set_jack callback

Use the standard component set_jack callback instead of defining a codec
private API for this.

Tested-by: Carlo Caione <>

Signed-off-by: Hans de Goede <>

Signed-off-by: Mark Brown <>

 sound/soc/codecs/rt5651.c             | 6 +++---
 sound/soc/codecs/rt5651.h             | 2 --
 sound/soc/intel/boards/bytcr_rt5651.c | 2 +-
 3 files changed, 4 insertions(+), 6 deletions(-)


Alsa-devel mailing list


diff --git a/sound/soc/codecs/rt5651.c b/sound/soc/codecs/rt5651.c
index c9698229fc33..030889143249 100644
--- a/sound/soc/codecs/rt5651.c
+++ b/sound/soc/codecs/rt5651.c
@@ -1593,8 +1593,8 @@  static irqreturn_t rt5651_irq(int irq, void *data)
 	return IRQ_HANDLED;
-int rt5651_set_jack_detect(struct snd_soc_component *component,
-			   struct snd_soc_jack *hp_jack)
+static int rt5651_set_jack(struct snd_soc_component *component,
+			   struct snd_soc_jack *hp_jack, void *data)
 	struct snd_soc_dapm_context *dapm = snd_soc_component_get_dapm(component);
 	struct rt5651_priv *rt5651 = snd_soc_component_get_drvdata(component);
@@ -1658,7 +1658,6 @@  int rt5651_set_jack_detect(struct snd_soc_component *component,
 	return 0;
 static int rt5651_probe(struct snd_soc_component *component)
@@ -1762,6 +1761,7 @@  static const struct snd_soc_component_driver soc_component_dev_rt5651 = {
 	.suspend		= rt5651_suspend,
 	.resume			= rt5651_resume,
 	.set_bias_level		= rt5651_set_bias_level,
+	.set_jack		= rt5651_set_jack,
 	.controls		= rt5651_snd_controls,
 	.num_controls		= ARRAY_SIZE(rt5651_snd_controls),
 	.dapm_widgets		= rt5651_dapm_widgets,
diff --git a/sound/soc/codecs/rt5651.h b/sound/soc/codecs/rt5651.h
index 8f128d057ff0..f3158488fc89 100644
--- a/sound/soc/codecs/rt5651.h
+++ b/sound/soc/codecs/rt5651.h
@@ -2080,6 +2080,4 @@  struct rt5651_priv {
 	bool hp_mute;
-int rt5651_set_jack_detect(struct snd_soc_component *component,
-			   struct snd_soc_jack *hp_jack);
 #endif /* __RT5651_H__ */
diff --git a/sound/soc/intel/boards/bytcr_rt5651.c b/sound/soc/intel/boards/bytcr_rt5651.c
index b6bf92191b9a..afb27e5e6756 100644
--- a/sound/soc/intel/boards/bytcr_rt5651.c
+++ b/sound/soc/intel/boards/bytcr_rt5651.c
@@ -370,7 +370,7 @@  static int byt_rt5651_init(struct snd_soc_pcm_runtime *runtime)
 		return ret;
-	rt5651_set_jack_detect(codec, &priv->jack);
+	snd_soc_component_set_jack(codec, &priv->jack, NULL);
 	return ret;