[v3] drm/panel: simple: Add TVC S9700RTWV43TR-01B 800x480 panel support

Message ID 1519940954-32703-1-git-send-email-jsarha@ti.com
State New
Headers show
Series
  • [v3] drm/panel: simple: Add TVC S9700RTWV43TR-01B 800x480 panel support
Related show

Commit Message

Jyri Sarha March 1, 2018, 9:49 p.m.
Add support for TVC S9700RTWV43TR-01B 800x480 panel found on TI's
AM335X-EVM.

Signed-off-by: Jyri Sarha <jsarha@ti.com>
Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
cc: Thierry Reding <thierry.reding@gmail.com>
---
 drivers/gpu/drm/panel/panel-simple.c | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

Comments

Thierry Reding March 12, 2018, 8:07 a.m. | #1
On Thu, Mar 01, 2018 at 11:49:14PM +0200, Jyri Sarha wrote:
> Add support for TVC S9700RTWV43TR-01B 800x480 panel found on TI's

> AM335X-EVM.

> 

> Signed-off-by: Jyri Sarha <jsarha@ti.com>

> Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ti.com>

> cc: Thierry Reding <thierry.reding@gmail.com>

> ---

>  drivers/gpu/drm/panel/panel-simple.c | 26 ++++++++++++++++++++++++++

>  1 file changed, 26 insertions(+)


I can't find the corresponding device tree bindings patch. Am I missing
something? Or did you forget? Also, there's no vendor prefix defined for
TVC.

Thierry
Jyri Sarha March 12, 2018, 8:26 a.m. | #2
On 12/03/18 10:07, Thierry Reding wrote:
> On Thu, Mar 01, 2018 at 11:49:14PM +0200, Jyri Sarha wrote:
>> Add support for TVC S9700RTWV43TR-01B 800x480 panel found on TI's
>> AM335X-EVM.
>>
>> Signed-off-by: Jyri Sarha <jsarha@ti.com>
>> Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
>> cc: Thierry Reding <thierry.reding@gmail.com>
>> ---
>>  drivers/gpu/drm/panel/panel-simple.c | 26 ++++++++++++++++++++++++++
>>  1 file changed, 26 insertions(+)
> 
> I can't find the corresponding device tree bindings patch. Am I missing
> something? Or did you forget? Also, there's no vendor prefix defined for
> TVC.
> 

Oh, I did not realize that there is a separate file of each panel-simple
compatible device. I'll add one for TVC S9700RTWV43TR-01B.

BR,
Jyri
Jyri Sarha March 12, 2018, 10:41 a.m. | #3
On 12/03/18 10:07, Thierry Reding wrote:
> On Thu, Mar 01, 2018 at 11:49:14PM +0200, Jyri Sarha wrote:
>> Add support for TVC S9700RTWV43TR-01B 800x480 panel found on TI's
>> AM335X-EVM.
>>
>> Signed-off-by: Jyri Sarha <jsarha@ti.com>
>> Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
>> cc: Thierry Reding <thierry.reding@gmail.com>
>> ---
>>  drivers/gpu/drm/panel/panel-simple.c | 26 ++++++++++++++++++++++++++
>>  1 file changed, 26 insertions(+)
> 
> I can't find the corresponding device tree bindings patch. Am I missing
> something? Or did you forget? Also, there's no vendor prefix defined for
> TVC.
> 

After extensive googling I think the TVC is a typo in the EVMs component
listing. It should probably be TFC. The is no such display as
TFC-S9700RTWV43TR-01 available or documented anywhere in web anymore,
but reading the Three Five Displays product listing[1] it appears to
agree with their model numbering scheme. I'll update the patch and add
the binding document.

BR,
Jyri

[1] http://threefivedisplays.com/products/tft-products/

Patch

diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
index 5591984..63ccf3d 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -1962,6 +1962,29 @@  static const struct panel_desc tpk_f10a_0102 = {
 	},
 };
 
+static const struct drm_display_mode tvc_s9700rtwv43tr_01b_mode = {
+	.clock = 30000,
+	.hdisplay = 800,
+	.hsync_start = 800 + 39,
+	.hsync_end = 800 + 39 + 47,
+	.htotal = 800 + 39 + 47 + 39,
+	.vdisplay = 480,
+	.vsync_start = 480 + 13,
+	.vsync_end = 480 + 13 + 2,
+	.vtotal = 480 + 13 + 2 + 29,
+	.vrefresh = 62,
+};
+
+static const struct panel_desc tvc_s9700rtwv43tr_01b = {
+	.modes = &tvc_s9700rtwv43tr_01b_mode,
+	.num_modes = 1,
+	.bpc = 8,
+	.size = {
+		.width = 155,
+		.height = 90,
+	},
+};
+
 static const struct display_timing urt_umsh_8596md_timing = {
 	.pixelclock = { 33260000, 33260000, 33260000 },
 	.hactive = { 800, 800, 800 },
@@ -2214,6 +2237,9 @@  static const struct of_device_id platform_of_match[] = {
 		.compatible = "tpk,f10a-0102",
 		.data = &tpk_f10a_0102,
 	}, {
+		.compatible = "tvc,s9700rtwv43tr-01b",
+		.data = &tvc_s9700rtwv43tr_01b,
+	}, {
 		.compatible = "urt,umsh-8596md-t",
 		.data = &urt_umsh_8596md_parallel,
 	}, {