[1/3] drm/bridge: analogix_dp: Don't power bridge in analogix_dp_bind

Message ID 20180305085741.18896-2-m.szyprowski@samsung.com
State New
Headers show
Series
  • Analogix DP fixes for Chromebook2 Peach-Pit (Exynos5420)
Related show

Commit Message

Marek Szyprowski March 5, 2018, 8:57 a.m.
From: zain wang <wzz@rock-chips.com>


The bridge does not need to be powered in analogix_dp_bind(), so
remove the calls to pm_runtime_get()/phy_power_on()/analogix_dp_init_dp()
as well as their power-off counterparts.

Cc: Stéphane Marchesin <marcheu@chromium.org>
Signed-off-by: zain wang <wzz@rock-chips.com>

Signed-off-by: Caesar Wang <wxt@rock-chips.com>

[the patch originally just removed the power_on portion, seanpaul removed
the power off code as well as improved the commit message]
Signed-off-by: Sean Paul <seanpaul@chromium.org>

Signed-off-by: Thierry Escande <thierry.escande@collabora.com>

Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>

---
 drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 10 ----------
 1 file changed, 10 deletions(-)

-- 
2.15.0

--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Heiko Stübner March 5, 2018, 12:39 p.m. | #1
Am Montag, 5. März 2018, 09:57:39 CET schrieb Marek Szyprowski:
> From: zain wang <wzz@rock-chips.com>

> 

> The bridge does not need to be powered in analogix_dp_bind(), so

> remove the calls to pm_runtime_get()/phy_power_on()/analogix_dp_init_dp()

> as well as their power-off counterparts.

> 

> Cc: Stéphane Marchesin <marcheu@chromium.org>

> Signed-off-by: zain wang <wzz@rock-chips.com>

> Signed-off-by: Caesar Wang <wxt@rock-chips.com>

> [the patch originally just removed the power_on portion, seanpaul removed

> the power off code as well as improved the commit message]

> Signed-off-by: Sean Paul <seanpaul@chromium.org>

> Signed-off-by: Thierry Escande <thierry.escande@collabora.com>

> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>


on top of current drm-misc-next on rk3288 and rk3399
Tested-by: Heiko Stuebner <heiko@sntech.de>


and the actual change also looks sane of course, so
Reviewed-by: Heiko Stuebner <heiko@sntech.de>

--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
index 3f7a796b27e4..8475749baae5 100644
--- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
+++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
@@ -1378,11 +1378,6 @@  analogix_dp_bind(struct device *dev, struct drm_device *drm_dev,
 
 	pm_runtime_enable(dev);
 
-	pm_runtime_get_sync(dev);
-	phy_power_on(dp->phy);
-
-	analogix_dp_init_dp(dp);
-
 	ret = devm_request_threaded_irq(&pdev->dev, dp->irq,
 					analogix_dp_hardirq,
 					analogix_dp_irq_thread,
@@ -1410,15 +1405,10 @@  analogix_dp_bind(struct device *dev, struct drm_device *drm_dev,
 		goto err_disable_pm_runtime;
 	}
 
-	phy_power_off(dp->phy);
-	pm_runtime_put(dev);
-
 	return dp;
 
 err_disable_pm_runtime:
 
-	phy_power_off(dp->phy);
-	pm_runtime_put(dev);
 	pm_runtime_disable(dev);
 
 	return ERR_PTR(ret);