[v2,1/2] systemtap: supports mips starting with version 3.1

Message ID 1520286611-27418-1-git-send-email-kamensky@cisco.com
State Accepted
Commit 3e098ef3424e1126aa4b0ecc29e1941efba687b7
Headers show
Series
  • [v2,1/2] systemtap: supports mips starting with version 3.1
Related show

Commit Message

Victor Kamensky March 5, 2018, 9:50 p.m.
Signed-off-by: Victor Kamensky <kamensky@cisco.com>

---
 meta/recipes-kernel/systemtap/systemtap_git.inc | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

-- 
2.7.4

-- 
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Comments

Khem Raj March 6, 2018, 3:17 a.m. | #1
On Mon, Mar 5, 2018 at 1:50 PM, Victor Kamensky <kamensky@cisco.com> wrote:
> Signed-off-by: Victor Kamensky <kamensky@cisco.com>

> ---

>  meta/recipes-kernel/systemtap/systemtap_git.inc | 3 +--

>  1 file changed, 1 insertion(+), 2 deletions(-)

>

> diff --git a/meta/recipes-kernel/systemtap/systemtap_git.inc b/meta/recipes-kernel/systemtap/systemtap_git.inc

> index c938760..d122359 100644

> --- a/meta/recipes-kernel/systemtap/systemtap_git.inc

> +++ b/meta/recipes-kernel/systemtap/systemtap_git.inc

> @@ -15,8 +15,7 @@ SRC_URI = "git://sourceware.org/git/systemtap.git \

>             file://0001-staprun-stapbpf-don-t-support-installing-a-non-root.patch \

>             "

>

> -# systemtap doesn't support mips

> -COMPATIBLE_HOST = '(x86_64|i.86|powerpc|arm|aarch64|microblazeel).*-linux'

> +COMPATIBLE_HOST = '(x86_64|i.86|powerpc|arm|aarch64|microblazeel|mips).*-linux'

>


Looks ok. Can we enable mipsel as well ?

>  S = "${WORKDIR}/git"

>

> --

> 2.7.4

>

> --

> _______________________________________________

> Openembedded-core mailing list

> Openembedded-core@lists.openembedded.org

> http://lists.openembedded.org/mailman/listinfo/openembedded-core

-- 
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
Victor Kamensky March 6, 2018, 6:47 a.m. | #2
Hi Khem,

On Mon, 5 Mar 2018, Khem Raj wrote:

> On Mon, Mar 5, 2018 at 1:50 PM, Victor Kamensky <kamensky@cisco.com> wrote:

>> Signed-off-by: Victor Kamensky <kamensky@cisco.com>

>> ---

>>  meta/recipes-kernel/systemtap/systemtap_git.inc | 3 +--

>>  1 file changed, 1 insertion(+), 2 deletions(-)

>>

>> diff --git a/meta/recipes-kernel/systemtap/systemtap_git.inc b/meta/recipes-kernel/systemtap/systemtap_git.inc

>> index c938760..d122359 100644

>> --- a/meta/recipes-kernel/systemtap/systemtap_git.inc

>> +++ b/meta/recipes-kernel/systemtap/systemtap_git.inc

>> @@ -15,8 +15,7 @@ SRC_URI = "git://sourceware.org/git/systemtap.git \

>>             file://0001-staprun-stapbpf-don-t-support-installing-a-non-root.patch \

>>             "

>>

>> -# systemtap doesn't support mips

>> -COMPATIBLE_HOST = '(x86_64|i.86|powerpc|arm|aarch64|microblazeel).*-linux'

>> +COMPATIBLE_HOST = '(x86_64|i.86|powerpc|arm|aarch64|microblazeel|mips).*-linux'

>>

>

> Looks ok. Can we enable mipsel as well ?


Above expression, effectively 'mips.*-linux', does match 'mipsel' as well, 
does not it? It matches mips64.

I did test basic systemtap operations on qemumips, and
qemumips64 machines, worked ok to me. I noticed some small quirks 
but they were similar to one that arm machine has. I am not saying
that MIPS support in systemtap is perfect, it is new architecture
for systemtap after all, there could be some bugs. But I believe
it is good enough to be enabled in OE.

I don't see any easy virtual mipsel based machine so I cannot test
it right away. But I don't see a reson why it would not work in LE
mode.

Thanks,
Victor

>>  S = "${WORKDIR}/git"

>>

>> --

>> 2.7.4

>>

>> --

>> _______________________________________________

>> Openembedded-core mailing list

>> Openembedded-core@lists.openembedded.org

>> http://lists.openembedded.org/mailman/listinfo/openembedded-core

>

-- 
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
Khem Raj March 6, 2018, 6:51 a.m. | #3
On Mon, Mar 5, 2018 at 10:47 PM, Victor Kamensky <kamensky@cisco.com> wrote:
> Hi Khem,

>

> On Mon, 5 Mar 2018, Khem Raj wrote:

>

>> On Mon, Mar 5, 2018 at 1:50 PM, Victor Kamensky <kamensky@cisco.com>

>> wrote:

>>>

>>> Signed-off-by: Victor Kamensky <kamensky@cisco.com>

>>> ---

>>>  meta/recipes-kernel/systemtap/systemtap_git.inc | 3 +--

>>>  1 file changed, 1 insertion(+), 2 deletions(-)

>>>

>>> diff --git a/meta/recipes-kernel/systemtap/systemtap_git.inc

>>> b/meta/recipes-kernel/systemtap/systemtap_git.inc

>>> index c938760..d122359 100644

>>> --- a/meta/recipes-kernel/systemtap/systemtap_git.inc

>>> +++ b/meta/recipes-kernel/systemtap/systemtap_git.inc

>>> @@ -15,8 +15,7 @@ SRC_URI = "git://sourceware.org/git/systemtap.git \

>>>

>>> file://0001-staprun-stapbpf-don-t-support-installing-a-non-root.patch \

>>>             "

>>>

>>> -# systemtap doesn't support mips

>>> -COMPATIBLE_HOST =

>>> '(x86_64|i.86|powerpc|arm|aarch64|microblazeel).*-linux'

>>> +COMPATIBLE_HOST =

>>> '(x86_64|i.86|powerpc|arm|aarch64|microblazeel|mips).*-linux'

>>>

>>

>> Looks ok. Can we enable mipsel as well ?

>

>

> Above expression, effectively 'mips.*-linux', does match 'mipsel' as well,

> does not it? It matches mips64.

>

> I did test basic systemtap operations on qemumips, and

> qemumips64 machines, worked ok to me. I noticed some small quirks but they

> were similar to one that arm machine has. I am not saying

> that MIPS support in systemtap is perfect, it is new architecture

> for systemtap after all, there could be some bugs. But I believe

> it is good enough to be enabled in OE.

>

> I don't see any easy virtual mipsel based machine so I cannot test

> it right away. But I don't see a reson why it would not work in LE

> mode.


ok thanks for clarifying. I wanted to ask if it works on mipsel
or not, not about the regexp, but I see I could have framed it better
-- 
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Patch

diff --git a/meta/recipes-kernel/systemtap/systemtap_git.inc b/meta/recipes-kernel/systemtap/systemtap_git.inc
index c938760..d122359 100644
--- a/meta/recipes-kernel/systemtap/systemtap_git.inc
+++ b/meta/recipes-kernel/systemtap/systemtap_git.inc
@@ -15,8 +15,7 @@  SRC_URI = "git://sourceware.org/git/systemtap.git \
            file://0001-staprun-stapbpf-don-t-support-installing-a-non-root.patch \
            "
 
-# systemtap doesn't support mips
-COMPATIBLE_HOST = '(x86_64|i.86|powerpc|arm|aarch64|microblazeel).*-linux'
+COMPATIBLE_HOST = '(x86_64|i.86|powerpc|arm|aarch64|microblazeel|mips).*-linux'
 
 S = "${WORKDIR}/git"