| Message ID | 1520334911-9752-1-git-send-email-yamada.masahiro@socionext.com |
|---|---|
| State | Accepted |
| Commit | 8fa566206efdef4d3ec7f13bed36302f9969f2ef |
| Headers | show |
| Series | reset: imx7: add 'depends on HAS_IOMEM' to fix unmet dependency | expand |
Hi Masahiro, On Tue, 2018-03-06 at 20:15 +0900, Masahiro Yamada wrote: > This config select's MFD_SYSCON, but does not depend on HAS_IOMEM. > > Compile testing on architecture without HAS_IOMEM causes "unmet > direct dependencies" in Kconfig phase. > > Detected by "make ARCH=score allyesconfig". > > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> Thank you, applied to reset/next. > > --- > > Arnd Bergmann and I discussed how to fix unmet dependency of MFD_SYSCON. > https://lkml.org/lkml/2018/2/27/284 > > We agreed to add 'depends on HAS_IOMEM' to drivers causing > unmet dependency. Agreed, RESET_TI_SYSCON already does the same. Thanks for the context. regards Philipp
diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig index 7fc7769..b1008b9 100644 --- a/drivers/reset/Kconfig +++ b/drivers/reset/Kconfig @@ -49,6 +49,7 @@ config RESET_HSDK config RESET_IMX7 bool "i.MX7 Reset Driver" if COMPILE_TEST + depends on HAS_IOMEM default SOC_IMX7D select MFD_SYSCON help
This config select's MFD_SYSCON, but does not depend on HAS_IOMEM. Compile testing on architecture without HAS_IOMEM causes "unmet direct dependencies" in Kconfig phase. Detected by "make ARCH=score allyesconfig". Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> --- Arnd Bergmann and I discussed how to fix unmet dependency of MFD_SYSCON. https://lkml.org/lkml/2018/2/27/284 We agreed to add 'depends on HAS_IOMEM' to drivers causing unmet dependency. drivers/reset/Kconfig | 1 + 1 file changed, 1 insertion(+) -- 2.7.4