From patchwork Thu Mar 8 18:17:42 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexander Kanavin X-Patchwork-Id: 131053 Delivered-To: patch@linaro.org Received: by 10.46.66.2 with SMTP id p2csp52783lja; Thu, 8 Mar 2018 10:27:31 -0800 (PST) X-Google-Smtp-Source: AG47ELsiBhboCsjWeqIZc69Nl2RRyBn7RtiPctSL8o/QsLSAv8ISCD2YAM1w0jji4YRCpK898Esm X-Received: by 10.101.82.10 with SMTP id o10mr10770441pgp.271.1520533651426; Thu, 08 Mar 2018 10:27:31 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1520533651; cv=none; d=google.com; s=arc-20160816; b=nWVp1cs44k+2y89rHzmrJJCtkot2gj/fOyVR7FNOWYzdQZoh/9AcuSWOTKMyRauP2v TEoG92OYy3qFpvJm7ul9etIMDy7X/UQocy4ZpLQ25wEIlxkVOIux9q+gVGLc+ChRvLMI cy2pVjVxIT7BBX8XjE2w5dTKOqE0n+xRI3uVhHG0LHSf7LSIBrv3A2rgQTDrl7UjibLW 7GQNiUYj5h7Dsai3Oe8+cs8a6aie8YcFF+qW4fUNwXopeQNuHwREi6Xnq0vEAlH9LZJc EvGFABrxwyIa/o6aPG0UIFcRmDr8Yy5ZO4xyWW9K2x6mDUTri/ooK/ltFp2ypunvVSjl TbXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:sender:content-transfer-encoding:mime-version :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:references:in-reply-to:message-id:date :to:from:delivered-to:arc-authentication-results; bh=3pIli8HVoHldsgxlIv1wlH+67GBN/RMtA2efssd7hJo=; b=eF5IaZV+TilJ9AHxgfLeU1SX2Do7okZp4QUENpF67FyYZoYeHUTpmew3gB9jD9uwFS vdx6YDrUXIgBB/J1OOhP1metmLLXhfLpyS27KoAdGFOXAsGcxtdgvUAK76UwAhjbCanU HbbUlyFNH+KpiU0SO+EWjcDm3utziQhrIW8UH+hDRbEmxcAKkzPItsSHLy0I2fgyB5cf aWOLkRH80HJMbS3d0ARBSuULki0JklmdV6NDA6Qq0KdBAnyqQ6fZrYZB+dGJ+fijZ9rE qjsDWriu9RuQ0rse6JtrKpvJqtAdQg4+7GI6jrU0xqNXuGd9OtFGTb/XIlBAr/UA3eSj QVGw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of openembedded-core-bounces@lists.openembedded.org designates 140.211.169.62 as permitted sender) smtp.mailfrom=openembedded-core-bounces@lists.openembedded.org Return-Path: Received: from mail.openembedded.org (mail.openembedded.org. [140.211.169.62]) by mx.google.com with ESMTP id 3-v6si15023597plr.440.2018.03.08.10.27.31; Thu, 08 Mar 2018 10:27:31 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of openembedded-core-bounces@lists.openembedded.org designates 140.211.169.62 as permitted sender) client-ip=140.211.169.62; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of openembedded-core-bounces@lists.openembedded.org designates 140.211.169.62 as permitted sender) smtp.mailfrom=openembedded-core-bounces@lists.openembedded.org Received: from layers.openembedded.org (localhost [127.0.0.1]) by mail.openembedded.org (Postfix) with ESMTP id 0AE4E78A05; Thu, 8 Mar 2018 18:25:30 +0000 (UTC) X-Original-To: openembedded-core@lists.openembedded.org Delivered-To: openembedded-core@lists.openembedded.org Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mail.openembedded.org (Postfix) with ESMTP id 681A3789B4 for ; Thu, 8 Mar 2018 18:25:12 +0000 (UTC) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Mar 2018 10:25:14 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.47,441,1515484800"; d="scan'208";a="24053914" Received: from kanavin-desktop.fi.intel.com ([10.237.68.161]) by orsmga006.jf.intel.com with ESMTP; 08 Mar 2018 10:25:12 -0800 From: Alexander Kanavin To: openembedded-core@lists.openembedded.org Date: Thu, 8 Mar 2018 20:17:42 +0200 Message-Id: <20180308181804.31261-20-alexander.kanavin@linux.intel.com> X-Mailer: git-send-email 2.16.1 In-Reply-To: <20180308181804.31261-1-alexander.kanavin@linux.intel.com> References: <20180308181804.31261-1-alexander.kanavin@linux.intel.com> Subject: [OE-core] [PATCH 20/42] bash: refresh patches X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: openembedded-core-bounces@lists.openembedded.org Errors-To: openembedded-core-bounces@lists.openembedded.org From: Ross Burton The patch tool will apply patches by default with "fuzz", which is where if the hunk context isn't present but what is there is close enough, it will force the patch in. Whilst this is useful when there's just whitespace changes, when applied to source it is possible for a patch applied with fuzz to produce broken code which still compiles (see #10450). This is obviously bad. We'd like to eventually have do_patch() rejecting any fuzz on these grounds. For that to be realistic the existing patches with fuzz need to be rebased and reviewed. Signed-off-by: Ross Burton Signed-off-by: Alexander Kanavin --- meta/recipes-extended/bash/bash/execute_cmd.patch | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) -- 2.16.1 -- _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core diff --git a/meta/recipes-extended/bash/bash/execute_cmd.patch b/meta/recipes-extended/bash/bash/execute_cmd.patch index 81f8f0a9cd5..9970b4d8f93 100644 --- a/meta/recipes-extended/bash/bash/execute_cmd.patch +++ b/meta/recipes-extended/bash/bash/execute_cmd.patch @@ -1,8 +1,10 @@ Upstream-Status: Inappropriate [embedded specific] ---- execute_cmd.c.orig Fri Jun 3 13:34:42 2011 -+++ execute_cmd.c Fri Jun 3 13:36:41 2011 -@@ -2202,7 +2202,11 @@ +Index: execute_cmd.c +=================================================================== +--- execute_cmd.c.orig ++++ execute_cmd.c +@@ -2459,7 +2459,11 @@ execute_pipeline (command, asynchronous, /* If the `lastpipe' option is set with shopt, and job control is not enabled, execute the last element of non-async pipelines in the current shell environment. */ @@ -13,5 +15,5 @@ Upstream-Status: Inappropriate [embedded specific] +#endif + asynchronous == 0 && pipe_out == NO_PIPE && prev > 0) { - lstdin = move_to_high_fd (0, 0, 255); + lstdin = move_to_high_fd (0, 1, -1); if (lstdin > 0)