From patchwork Fri Mar 9 09:07:20 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alex Shi X-Patchwork-Id: 131092 Delivered-To: patch@linaro.org Received: by 10.46.66.2 with SMTP id p2csp749812lja; Fri, 9 Mar 2018 01:12:32 -0800 (PST) X-Google-Smtp-Source: AG47ELv8Ezep+qnvq6eSPwPFbI2weqgkMMLBW7doe7fzTgKEDagyIQv0DIBHMycdmLY8VPbA4FnT X-Received: by 10.101.72.69 with SMTP id i5mr22869720pgs.78.1520586752639; Fri, 09 Mar 2018 01:12:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1520586752; cv=none; d=google.com; s=arc-20160816; b=gQA5WTSIU9itg8QdGSlYeawqvMvp/02RfKKTAPxXT+ZbcJng9UsmkTrt77+YO3uwV6 tczpG/fhyVTzYsBENBN4bPt7C5lYFlVPxk1GNEPkqnagxHwi4Knbbdznxe4IeOH2MJtz dAsxae1IssP7Jv4KStDeB0MUqZPCHo2zu7NSUDhk/Kynuz6AIP2wKDh/ea2ouPkw4+Ua D4Fp+K4kjFlKgKHCgwfm4DhZc3X0zZtAQ1JFFE7Kmd1WJMoIaxcYs8Ph4Dl1zFHBn6vA tajhDPvWVDiygb1yr4UIUthCOSevpCMrqzBwxuK2Ch9qwTSBw4WOY9OzEtHSieZ6djai HPQA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=lnOIPJhNibngwtNhM1LFwTHZX3s8yCuRtOtFqUyLiT0=; b=EduwB3WDDxBSOaBY/D/GNwXobUPsm3vX9o/+NFYPG8BO9sfFAgxSORZGz6wjiJee0n OQIQJv7kr8IFktI6Hbbkm68OJQbVFDRoNAt2xdVqzYbGg3X5xHAP6JHJwX6bj0CPyVjG urqao/tBCyn4oFuWY1rmB4QKekWKLd0UuKszFMxNiYEGZ9FsXOO/A3YvcLa9gYT7qjXe aMh9JfEvUGqiEOf9/0TN0Q4/wcI2+OPNW9KqZRMMAloWL+1u7bOY/9s7aGUfa9ExINnC UrW/41K6EVfPBeS7IJuVjmP4Z5uR8T/ARW7cggqijUVesTsuq8ZSgTO6+P/zweMG8K+Q VXCA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=QoHvMeqW; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m8-v6si558162pll.229.2018.03.09.01.12.32; Fri, 09 Mar 2018 01:12:32 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=QoHvMeqW; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751026AbeCIJM2 (ORCPT + 10 others); Fri, 9 Mar 2018 04:12:28 -0500 Received: from mail-pl0-f65.google.com ([209.85.160.65]:44590 "EHLO mail-pl0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751045AbeCIJM1 (ORCPT ); Fri, 9 Mar 2018 04:12:27 -0500 Received: by mail-pl0-f65.google.com with SMTP id 9-v6so4931447ple.11 for ; Fri, 09 Mar 2018 01:12:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=lnOIPJhNibngwtNhM1LFwTHZX3s8yCuRtOtFqUyLiT0=; b=QoHvMeqWA6g9S9iav3ytV7N0PSWvC8uIN1hXlwBS8pblozDmOSX6Ik4Ywy6HGkjwTw AP6vym0PtYbuzNr4ptHEfoXmobYNlGoXcdjvLMwDVRRwR+CXoOrLefqA/5g16Y2A99Wz jPa7nnY0FLhJrER54n10jquTTjrfj/P30FuU0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=lnOIPJhNibngwtNhM1LFwTHZX3s8yCuRtOtFqUyLiT0=; b=a6Ek1VD2i0C9RHfoe5mUoBp5TPS+KKN2xhsPkSpPkBNVvhhGMBk3DwlnUXUM7hcAOU hmnIfWOCVza6YYFj6liivLg3AuO+YurQU1g+eSfGM9Yh4MJPyHlBhZxPG9ttSb3ULkow C/dbVMg9uknmvhMjEXvoNI/kGoOK3lLAHMgGVli8z0hysXtc9pxdXz9ehCCq54CObtyu h+AMOs040/85Qi+BxeJ/gQzmX1MIU6H9YBOKPOwW3PEqL5Vayr3uv4w9AZ19Ho3DfVt7 cbbHT4TJb4pU/Ak2LF5vbZjzcCuwNhF+667p0Dbs0bOIoXzmpXYzN3XeODWwkRP0HH+S T03w== X-Gm-Message-State: APf1xPApXHK4raHKcGsg7yIidzqj04z2QFIq2l0fQKNsTy8h/CsTj3Xm UHTlKgJO2QJvo67j99xw0K2Ohw== X-Received: by 2002:a17:902:3383:: with SMTP id b3-v6mr27458401plc.224.1520586747214; Fri, 09 Mar 2018 01:12:27 -0800 (PST) Received: from localhost.localdomain (176.122.172.82.16clouds.com. [176.122.172.82]) by smtp.gmail.com with ESMTPSA id c7sm1961752pfg.36.2018.03.09.01.12.19 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 09 Mar 2018 01:12:26 -0800 (PST) From: Alex Shi To: Marc Zyngier , Will Deacon , Ard Biesheuvel , Catalin Marinas , broonie@linaro.org, linux-arm-kernel@lists.infradead.org Cc: stable@vger.kernel.org, Alex Shi Subject: [PATCH 37/39] arm/arm64: smccc: Make function identifiers an unsigned quantity Date: Fri, 9 Mar 2018 17:07:20 +0800 Message-Id: <20180309090722.26279-38-alex.shi@linaro.org> X-Mailer: git-send-email 2.16.2.440.gc6284da In-Reply-To: <20180309090722.26279-1-alex.shi@linaro.org> References: <20180309090722.26279-1-alex.shi@linaro.org> Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Marc Zyngier commit ded4c39e93f3 upstream. Function identifiers are a 32bit, unsigned quantity. But we never tell so to the compiler, resulting in the following: 4ac: b26187e0 mov x0, #0xffffffff80000001 We thus rely on the firmware narrowing it for us, which is not always a reasonable expectation. Cc: stable@vger.kernel.org Reported-by: Ard Biesheuvel Acked-by: Ard Biesheuvel Reviewed-by: Robin Murphy Tested-by: Ard Biesheuvel Signed-off-by: Marc Zyngier Signed-off-by: Catalin Marinas Signed-off-by: Will Deacon Signed-off-by: Alex Shi --- include/linux/arm-smccc.h | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) -- 2.16.2.440.gc6284da diff --git a/include/linux/arm-smccc.h b/include/linux/arm-smccc.h index e7a439454950..e857670a8e01 100644 --- a/include/linux/arm-smccc.h +++ b/include/linux/arm-smccc.h @@ -14,14 +14,16 @@ #ifndef __LINUX_ARM_SMCCC_H #define __LINUX_ARM_SMCCC_H +#include + /* * This file provides common defines for ARM SMC Calling Convention as * specified in * http://infocenter.arm.com/help/topic/com.arm.doc.den0028a/index.html */ -#define ARM_SMCCC_STD_CALL 0 -#define ARM_SMCCC_FAST_CALL 1 +#define ARM_SMCCC_STD_CALL _AC(0,U) +#define ARM_SMCCC_FAST_CALL _AC(1,U) #define ARM_SMCCC_TYPE_SHIFT 31 #define ARM_SMCCC_SMC_32 0