[v4] drm/panel: simple: Add TFC S9700RTWV43TR-01B 800x480 panel support

Message ID 1520890425-9929-1-git-send-email-jsarha@ti.com
State New
Headers show
Series
  • [v4] drm/panel: simple: Add TFC S9700RTWV43TR-01B 800x480 panel support
Related show

Commit Message

Jyri Sarha March 12, 2018, 9:33 p.m.
Add support for Three Five displays TFC S9700RTWV43TR-01B 800x480
panel with resistive touch found on TI's AM335X-EVM.

Signed-off-by: Jyri Sarha <jsarha@ti.com>
Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
cc: Thierry Reding <thierry.reding@gmail.com>
---
 .../display/panel/tfc,s9700rtwv43tr-01b.txt        | 10 +++++++++
 drivers/gpu/drm/panel/panel-simple.c               | 26 ++++++++++++++++++++++
 2 files changed, 36 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/display/panel/tfc,s9700rtwv43tr-01b.txt

Comments

Thierry Reding April 26, 2018, 2:14 p.m. | #1
On Mon, Mar 12, 2018 at 11:33:45PM +0200, Jyri Sarha wrote:
> Add support for Three Five displays TFC S9700RTWV43TR-01B 800x480

> panel with resistive touch found on TI's AM335X-EVM.

> 

> Signed-off-by: Jyri Sarha <jsarha@ti.com>

> Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ti.com>

> cc: Thierry Reding <thierry.reding@gmail.com>

> ---

>  .../display/panel/tfc,s9700rtwv43tr-01b.txt        | 10 +++++++++

>  drivers/gpu/drm/panel/panel-simple.c               | 26 ++++++++++++++++++++++

>  2 files changed, 36 insertions(+)

>  create mode 100644 Documentation/devicetree/bindings/display/panel/tfc,s9700rtwv43tr-01b.txt


Documentation/devicetree/bindings/vendor-prefixes.txt does not contain
an entry for "tfc". Please send a patch for that.

Other than that this look good to me.

Thierry
Thierry Reding April 26, 2018, 2:15 p.m. | #2
On Mon, Mar 12, 2018 at 11:33:45PM +0200, Jyri Sarha wrote:
> Add support for Three Five displays TFC S9700RTWV43TR-01B 800x480

> panel with resistive touch found on TI's AM335X-EVM.

> 

> Signed-off-by: Jyri Sarha <jsarha@ti.com>

> Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ti.com>

> cc: Thierry Reding <thierry.reding@gmail.com>

> ---

>  .../display/panel/tfc,s9700rtwv43tr-01b.txt        | 10 +++++++++

>  drivers/gpu/drm/panel/panel-simple.c               | 26 ++++++++++++++++++++++

>  2 files changed, 36 insertions(+)

>  create mode 100644 Documentation/devicetree/bindings/display/panel/tfc,s9700rtwv43tr-01b.txt


Oh, you might want to Cc this to devicetree@vger.kernel.org and Rob
Herring (or any of the other bindings reviewers) for an Acked-by on
the DT bindings.

Thierry

Patch

diff --git a/Documentation/devicetree/bindings/display/panel/tfc,s9700rtwv43tr-01b.txt b/Documentation/devicetree/bindings/display/panel/tfc,s9700rtwv43tr-01b.txt
new file mode 100644
index 0000000..0b1cc71
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/panel/tfc,s9700rtwv43tr-01b.txt
@@ -0,0 +1,10 @@ 
+TFC S9700RTWV43TR-01B 7" Three Five Corp 800x480 LCD panel with
+resistive touch
+
+The panel is found on TI AM335x-evm.
+
+Required properties:
+- compatible: should be "tfc,S9700RTWV43tr-01b"
+
+This binding is compatible with the simple-panel binding, which is specified
+in simple-panel.txt in this directory.
diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
index 5591984..d4298da 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -1845,6 +1845,29 @@  static const struct panel_desc starry_kr122ea0sra = {
 	},
 };
 
+static const struct drm_display_mode tfc_s9700rtwv43tr_01b_mode = {
+	.clock = 30000,
+	.hdisplay = 800,
+	.hsync_start = 800 + 39,
+	.hsync_end = 800 + 39 + 47,
+	.htotal = 800 + 39 + 47 + 39,
+	.vdisplay = 480,
+	.vsync_start = 480 + 13,
+	.vsync_end = 480 + 13 + 2,
+	.vtotal = 480 + 13 + 2 + 29,
+	.vrefresh = 62,
+};
+
+static const struct panel_desc tfc_s9700rtwv43tr_01b = {
+	.modes = &tfc_s9700rtwv43tr_01b_mode,
+	.num_modes = 1,
+	.bpc = 8,
+	.size = {
+		.width = 155,
+		.height = 90,
+	},
+};
+
 static const struct display_timing tianma_tm070jdhg30_timing = {
 	.pixelclock = { 62600000, 68200000, 78100000 },
 	.hactive = { 1280, 1280, 1280 },
@@ -2199,6 +2222,9 @@  static const struct of_device_id platform_of_match[] = {
 		.compatible = "starry,kr122ea0sra",
 		.data = &starry_kr122ea0sra,
 	}, {
+		.compatible = "tfc,s9700rtwv43tr-01b",
+		.data = &tfc_s9700rtwv43tr_01b,
+	}, {
 		.compatible = "tianma,tm070jdhg30",
 		.data = &tianma_tm070jdhg30,
 	}, {