| Message ID | 20180315141020.11581-1-agraf@suse.de |
|---|---|
| State | Accepted |
| Commit | f24534307e983d983cc573390f75c76977d57ec6 |
| Headers | show |
| Series | lan7xxx: Require phylib | expand |
On Thu, Mar 15, 2018 at 9:10 AM, Alexander Graf <agraf@suse.de> wrote: > The lan75xx and lan78xx drivers need to drive their phy via the generic > phylib framework. Let's reflect that dependency in Kconfig, so that we > don't get build errors when phylib does not get selected. > > Signed-off-by: Alexander Graf <agraf@suse.de> Acked-by: Joe Hershberger <joe.hershberger@ni.com>
Hi, On Thu, 15 Mar 2018 15:10:20 +0100 Alexander Graf <agraf@suse.de> wrote: > The lan75xx and lan78xx drivers need to drive their phy via the generic > phylib framework. Let's reflect that dependency in Kconfig, so that we > don't get build errors when phylib does not get selected. > > Signed-off-by: Alexander Graf <agraf@suse.de> > --- > drivers/usb/eth/Kconfig | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/usb/eth/Kconfig b/drivers/usb/eth/Kconfig > index 496a6d1933..2f6bfa8e71 100644 > --- a/drivers/usb/eth/Kconfig > +++ b/drivers/usb/eth/Kconfig > @@ -23,6 +23,7 @@ config USB_ETHER_ASIX88179 > config USB_ETHER_LAN75XX > bool "Microchip LAN75XX support" > depends on USB_HOST_ETHER > + depends on PHYLIB 'select PHYLIB' seems more appropriate here (and there are already 17 drivers selecting it and none using 'depends on'.)
On Thu, Mar 15, 2018 at 10:16 PM, Tuomas Tynkkynen <tuomas@tuxera.com> wrote: > Hi, > > On Thu, 15 Mar 2018 15:10:20 +0100 > Alexander Graf <agraf@suse.de> wrote: > >> The lan75xx and lan78xx drivers need to drive their phy via the generic >> phylib framework. Let's reflect that dependency in Kconfig, so that we >> don't get build errors when phylib does not get selected. >> >> Signed-off-by: Alexander Graf <agraf@suse.de> >> --- >> drivers/usb/eth/Kconfig | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/drivers/usb/eth/Kconfig b/drivers/usb/eth/Kconfig >> index 496a6d1933..2f6bfa8e71 100644 >> --- a/drivers/usb/eth/Kconfig >> +++ b/drivers/usb/eth/Kconfig >> @@ -23,6 +23,7 @@ config USB_ETHER_ASIX88179 >> config USB_ETHER_LAN75XX >> bool "Microchip LAN75XX support" >> depends on USB_HOST_ETHER >> + depends on PHYLIB > > 'select PHYLIB' seems more appropriate here (and there are already 17 > drivers selecting it and none using 'depends on'.) Yeah, good point. Please change this. Thanks, -Joe
Hi Alexander, https://patchwork.ozlabs.org/patch/886258/ was applied to http://git.denx.de/?p=u-boot/u-boot-net.git Thanks! -Joe
diff --git a/drivers/usb/eth/Kconfig b/drivers/usb/eth/Kconfig index 496a6d1933..2f6bfa8e71 100644 --- a/drivers/usb/eth/Kconfig +++ b/drivers/usb/eth/Kconfig @@ -23,6 +23,7 @@ config USB_ETHER_ASIX88179 config USB_ETHER_LAN75XX bool "Microchip LAN75XX support" depends on USB_HOST_ETHER + depends on PHYLIB ---help--- Say Y here if you would like to support Microchip LAN75XX Hi-Speed USB 2.0 to 10/100/1000 Gigabit Ethernet controller. @@ -32,6 +33,7 @@ config USB_ETHER_LAN75XX config USB_ETHER_LAN78XX bool "Microchip LAN78XX support" depends on USB_HOST_ETHER + depends on PHYLIB ---help--- Say Y here if you would like to support Microchip LAN78XX USB 3.1 Gen 1 to 10/100/1000 Gigabit Ethernet controller.
The lan75xx and lan78xx drivers need to drive their phy via the generic phylib framework. Let's reflect that dependency in Kconfig, so that we don't get build errors when phylib does not get selected. Signed-off-by: Alexander Graf <agraf@suse.de> --- drivers/usb/eth/Kconfig | 2 ++ 1 file changed, 2 insertions(+)