| Message ID | 19ff9542e08c7df5898cc811f65200050ecf02d5.1521257828.git.raj.khem@gmail.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | RISC-V Build fixes | expand |
On 17 March 2018 at 03:40, Khem Raj <raj.khem@gmail.com> wrote: > It is not using autoconf completely, therefore there > is no autoreconf happening, so when we depend on latest > gnu-config changes e.g. new architectures like riscv > the build does not see them and fails. > > Installing these files from native sysroot helps > > Signed-off-by: Khem Raj <raj.khem@gmail.com> > --- > meta/recipes-multimedia/x264/x264_git.bb | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/meta/recipes-multimedia/x264/x264_git.bb > b/meta/recipes-multimedia/x264/x264_git.bb > index a669295044..c445d15e69 100644 > --- a/meta/recipes-multimedia/x264/x264_git.bb > +++ b/meta/recipes-multimedia/x264/x264_git.bb > @@ -43,6 +43,8 @@ EXTRA_OECONF = '--prefix=${prefix} \ > ' > > do_configure() { > + install -m 0755 ${STAGING_DATADIR_NATIVE}/gnu-config/config.guess > ${S} > + install -m 0755 ${STAGING_DATADIR_NATIVE}/gnu-config/config.sub ${S} > ./configure ${EXTRA_OECONF} A neater way is to call gnu-configize --force ${S}. Ross <div dir="ltr">On 17 March 2018 at 03:40, Khem Raj <span dir="ltr"><<a href="mailto:raj.khem@gmail.com" target="_blank">raj.khem@gmail.com</a>></span> wrote:<br><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">It is not using autoconf completely, therefore there<br> is no autoreconf happening, so when we depend on latest<br> gnu-config changes e.g. new architectures like riscv<br> the build does not see them and fails.<br> <br> Installing these files from native sysroot helps<br> <br> Signed-off-by: Khem Raj <<a href="mailto:raj.khem@gmail.com">raj.khem@gmail.com</a>><br> ---<br> meta/recipes-multimedia/x264/<a href="http://x264_git.bb" rel="noreferrer" target="_blank">x<wbr>264_git.bb</a> | 2 ++<br> 1 file changed, 2 insertions(+)<br> <br> diff --git a/meta/recipes-multimedia/<wbr>x264/<a href="http://x264_git.bb" rel="noreferrer" target="_blank">x264_git.bb</a> b/meta/recipes-multimedia/<wbr>x264/<a href="http://x264_git.bb" rel="noreferrer" target="_blank">x264_git.bb</a><br> index a669295044..c445d15e69 100644<br> --- a/meta/recipes-multimedia/<wbr>x264/<a href="http://x264_git.bb" rel="noreferrer" target="_blank">x264_git.bb</a><br> +++ b/meta/recipes-multimedia/<wbr>x264/<a href="http://x264_git.bb" rel="noreferrer" target="_blank">x264_git.bb</a><br> @@ -43,6 +43,8 @@ EXTRA_OECONF = '--prefix=${prefix} \<br> '<br> <br> do_configure() {<br> + install -m 0755 ${STAGING_DATADIR_NATIVE}/gnu-<wbr>config/config.guess ${S}<br> + install -m 0755 ${STAGING_DATADIR_NATIVE}/gnu-<wbr>config/config.sub ${S}<br> ./configure ${EXTRA_OECONF}</blockquote><div><br></div><div>A neater way is to call gnu-configize --force ${S}.</div><div><br></div><div>Ross</div></div></div></div> -- _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
Thanks for the tip! On Mon, Mar 19, 2018 at 4:37 AM Burton, Ross <ross.burton@intel.com> wrote: > On 17 March 2018 at 03:40, Khem Raj <raj.khem@gmail.com> wrote: > >> It is not using autoconf completely, therefore there >> is no autoreconf happening, so when we depend on latest >> gnu-config changes e.g. new architectures like riscv >> the build does not see them and fails. >> >> Installing these files from native sysroot helps >> >> Signed-off-by: Khem Raj <raj.khem@gmail.com> >> --- >> meta/recipes-multimedia/x264/x264_git.bb | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/meta/recipes-multimedia/x264/x264_git.bb >> b/meta/recipes-multimedia/x264/x264_git.bb >> index a669295044..c445d15e69 100644 >> --- a/meta/recipes-multimedia/x264/x264_git.bb >> +++ b/meta/recipes-multimedia/x264/x264_git.bb >> @@ -43,6 +43,8 @@ EXTRA_OECONF = '--prefix=${prefix} \ >> ' >> >> do_configure() { >> + install -m 0755 ${STAGING_DATADIR_NATIVE}/gnu-config/config.guess >> ${S} >> + install -m 0755 ${STAGING_DATADIR_NATIVE}/gnu-config/config.sub ${S} >> ./configure ${EXTRA_OECONF} > > > A neater way is to call gnu-configize --force ${S}. > > Ross > <div>Thanks for the tip!</div><div><br><div class="gmail_quote"><div>On Mon, Mar 19, 2018 at 4:37 AM Burton, Ross <<a href="mailto:ross.burton@intel.com">ross.burton@intel.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div>On 17 March 2018 at 03:40, Khem Raj <span><<a href="mailto:raj.khem@gmail.com" target="_blank">raj.khem@gmail.com</a>></span> wrote:<br></div><div><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">It is not using autoconf completely, therefore there<br> is no autoreconf happening, so when we depend on latest<br> gnu-config changes e.g. new architectures like riscv<br> the build does not see them and fails.<br> <br> Installing these files from native sysroot helps<br> <br> Signed-off-by: Khem Raj <<a href="mailto:raj.khem@gmail.com" target="_blank">raj.khem@gmail.com</a>><br> ---<br> meta/recipes-multimedia/x264/<a href="http://x264_git.bb" rel="noreferrer" target="_blank">x264_git.bb</a> | 2 ++<br> 1 file changed, 2 insertions(+)<br> <br> diff --git a/meta/recipes-multimedia/x264/<a href="http://x264_git.bb" rel="noreferrer" target="_blank">x264_git.bb</a> b/meta/recipes-multimedia/x264/<a href="http://x264_git.bb" rel="noreferrer" target="_blank">x264_git.bb</a><br> index a669295044..c445d15e69 100644<br> --- a/meta/recipes-multimedia/x264/<a href="http://x264_git.bb" rel="noreferrer" target="_blank">x264_git.bb</a><br> +++ b/meta/recipes-multimedia/x264/<a href="http://x264_git.bb" rel="noreferrer" target="_blank">x264_git.bb</a><br> @@ -43,6 +43,8 @@ EXTRA_OECONF = '--prefix=${prefix} \<br> '<br> <br> do_configure() {<br> + install -m 0755 ${STAGING_DATADIR_NATIVE}/gnu-config/config.guess ${S}<br> + install -m 0755 ${STAGING_DATADIR_NATIVE}/gnu-config/config.sub ${S}<br> ./configure ${EXTRA_OECONF}</blockquote><div><br></div></div></div></div><div><div class="gmail_extra"><div class="gmail_quote"><div>A neater way is to call gnu-configize --force ${S}.</div></div></div></div><div><div class="gmail_extra"><div class="gmail_quote"><div><br></div><div>Ross</div></div></div></div></blockquote></div></div> -- _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
On Mon, Mar 19, 2018 at 4:36 AM, Burton, Ross <ross.burton@intel.com> wrote: > On 17 March 2018 at 03:40, Khem Raj <raj.khem@gmail.com> wrote: >> >> It is not using autoconf completely, therefore there >> is no autoreconf happening, so when we depend on latest >> gnu-config changes e.g. new architectures like riscv >> the build does not see them and fails. >> >> Installing these files from native sysroot helps >> >> Signed-off-by: Khem Raj <raj.khem@gmail.com> >> --- >> meta/recipes-multimedia/x264/x264_git.bb | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/meta/recipes-multimedia/x264/x264_git.bb >> b/meta/recipes-multimedia/x264/x264_git.bb >> index a669295044..c445d15e69 100644 >> --- a/meta/recipes-multimedia/x264/x264_git.bb >> +++ b/meta/recipes-multimedia/x264/x264_git.bb >> @@ -43,6 +43,8 @@ EXTRA_OECONF = '--prefix=${prefix} \ >> ' >> >> do_configure() { >> + install -m 0755 ${STAGING_DATADIR_NATIVE}/gnu-config/config.guess >> ${S} >> + install -m 0755 ${STAGING_DATADIR_NATIVE}/gnu-config/config.sub ${S} >> ./configure ${EXTRA_OECONF} > > > A neater way is to call gnu-configize --force ${S}. > this only works if the system uses autotools in full respect. x264 has a hand woven configure but rely on other parts of autotools. So we have to stay with proposed solution. > Ross -- _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
On 19 March 2018 at 16:54, Khem Raj <raj.khem@gmail.com> wrote: > this only works if the system uses autotools > in full respect. x264 has a hand woven configure > but rely on other parts of autotools. So we have to > stay with proposed solution. > gnu-configize should be sufficiently dumb that it should work in non-autotools trees, did it give you an error message? Ross <div dir="ltr">On 19 March 2018 at 16:54, Khem Raj <span dir="ltr"><<a href="mailto:raj.khem@gmail.com" target="_blank">raj.khem@gmail.com</a>></span> wrote:<br><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">this only works if the system uses autotools<br> in full respect. x264 has a hand woven configure<br> but rely on other parts of autotools. So we have to<br> stay with proposed solution.<br></blockquote><div><br></div><div>gnu-configize should be sufficiently dumb that it should work in non-autotools trees, did it give you an error message?</div><div><br></div><div>Ross </div></div></div></div> -- _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
On Mon, Mar 19, 2018 at 10:23 AM, Burton, Ross <ross.burton@intel.com> wrote: > On 19 March 2018 at 16:54, Khem Raj <raj.khem@gmail.com> wrote: >> >> this only works if the system uses autotools >> in full respect. x264 has a hand woven configure >> but rely on other parts of autotools. So we have to >> stay with proposed solution. > > > gnu-configize should be sufficiently dumb that it should work in > non-autotools trees, did it give you an error message? > its looking for configure.in or configure.ac > Ross -- _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
Huh, I was hoping that passing a path would just force it. Maybe we should stop the script being so "clever". Ross On 19 March 2018 at 17:48, Khem Raj <raj.khem@gmail.com> wrote: > On Mon, Mar 19, 2018 at 10:23 AM, Burton, Ross <ross.burton@intel.com> > wrote: > > On 19 March 2018 at 16:54, Khem Raj <raj.khem@gmail.com> wrote: > >> > >> this only works if the system uses autotools > >> in full respect. x264 has a hand woven configure > >> but rely on other parts of autotools. So we have to > >> stay with proposed solution. > > > > > > gnu-configize should be sufficiently dumb that it should work in > > non-autotools trees, did it give you an error message? > > > > its looking for configure.in or configure.ac > > > Ross > <div dir="ltr">Huh, I was hoping that passing a path would just force it.<div><br></div><div>Maybe we should stop the script being so "clever".</div><div><br></div><div>Ross</div></div><div class="gmail_extra"><br><div class="gmail_quote">On 19 March 2018 at 17:48, Khem Raj <span dir="ltr"><<a href="mailto:raj.khem@gmail.com" target="_blank">raj.khem@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On Mon, Mar 19, 2018 at 10:23 AM, Burton, Ross <<a href="mailto:ross.burton@intel.com">ross.burton@intel.com</a>> wrote:<br> > On 19 March 2018 at 16:54, Khem Raj <<a href="mailto:raj.khem@gmail.com">raj.khem@gmail.com</a>> wrote:<br> >><br> >> this only works if the system uses autotools<br> >> in full respect. x264 has a hand woven configure<br> >> but rely on other parts of autotools. So we have to<br> >> stay with proposed solution.<br> ><br> ><br> > gnu-configize should be sufficiently dumb that it should work in<br> > non-autotools trees, did it give you an error message?<br> ><br> <br> </span>its looking for <a href="http://configure.in" rel="noreferrer" target="_blank">configure.in</a> or <a href="http://configure.ac" rel="noreferrer" target="_blank">configure.ac</a><br> <br> > Ross<br> </blockquote></div><br></div> -- _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
diff --git a/meta/recipes-multimedia/x264/x264_git.bb b/meta/recipes-multimedia/x264/x264_git.bb index a669295044..c445d15e69 100644 --- a/meta/recipes-multimedia/x264/x264_git.bb +++ b/meta/recipes-multimedia/x264/x264_git.bb @@ -43,6 +43,8 @@ EXTRA_OECONF = '--prefix=${prefix} \ ' do_configure() { + install -m 0755 ${STAGING_DATADIR_NATIVE}/gnu-config/config.guess ${S} + install -m 0755 ${STAGING_DATADIR_NATIVE}/gnu-config/config.sub ${S} ./configure ${EXTRA_OECONF} }
It is not using autoconf completely, therefore there is no autoreconf happening, so when we depend on latest gnu-config changes e.g. new architectures like riscv the build does not see them and fails. Installing these files from native sysroot helps Signed-off-by: Khem Raj <raj.khem@gmail.com> --- meta/recipes-multimedia/x264/x264_git.bb | 2 ++ 1 file changed, 2 insertions(+) -- 2.16.2 -- _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core