[V2] site/risc-v: Cache common variables to build libIDL

Message ID 20180320041253.24537-1-raj.khem@gmail.com
State New
Headers show
Series
  • [V2] site/risc-v: Cache common variables to build libIDL
Related show

Commit Message

Khem Raj March 20, 2018, 4:12 a.m.
These variables force runtime tests during configure
they are already cached for other architectures

Signed-off-by: Khem Raj <raj.khem@gmail.com>

---
Changes from v1 -> v2:
- Drop libIDL specific setting since they need to be in meta-gnome

 meta/site/riscv32-linux | 10 ++++++++++
 meta/site/riscv64-linux |  5 +++++
 2 files changed, 15 insertions(+)

-- 
2.16.2

-- 
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Comments

Ross Burton March 20, 2018, 9:02 a.m. | #1
Are the sizeof values actually needed, or are they copy/pasted from another
site?  autoconf hasn't need to run code to do sizeof for a *long* time.

Ross

On 20 March 2018 at 04:12, Khem Raj <raj.khem@gmail.com> wrote:

> These variables force runtime tests during configure

> they are already cached for other architectures

>

> Signed-off-by: Khem Raj <raj.khem@gmail.com>

> ---

> Changes from v1 -> v2:

> - Drop libIDL specific setting since they need to be in meta-gnome

>

>  meta/site/riscv32-linux | 10 ++++++++++

>  meta/site/riscv64-linux |  5 +++++

>  2 files changed, 15 insertions(+)

>

> diff --git a/meta/site/riscv32-linux b/meta/site/riscv32-linux

> index 138aeb0a11..fc5b99d147 100644

> --- a/meta/site/riscv32-linux

> +++ b/meta/site/riscv32-linux

> @@ -1,6 +1,16 @@

> +# general

> +ac_cv_alignof_guint32=4

> +ac_cv_alignof_guint64=8

> +ac_cv_alignof_unsigned_long=4

> +

>  # glib-2.0

>  glib_cv_stack_grows=${glib_cv_stack_grows=no}

>  glib_cv_uscore=${glib_cv_uscore=no}

> +glib_cv_sizeof_gmutex=${glib_cv_sizeof_gmutex=24}

> +glib_cv_sizeof_intmax_t=${glib_cv_sizeof_intmax_t=8}

> +glib_cv_sizeof_ptrdiff_t=${glib_cv_sizeof_ptrdiff_t=4}

> +glib_cv_sizeof_size_t=${glib_cv_sizeof_size_t=4}

> +glib_cv_sizeof_system_thread=${glib_cv_sizeof_system_thread=4}

>

>  # startup-notification

>  lf_cv_sane_realloc=${lf_cv_sane_realloc=yes}

> diff --git a/meta/site/riscv64-linux b/meta/site/riscv64-linux

> index 138aeb0a11..38bc5f044d 100644

> --- a/meta/site/riscv64-linux

> +++ b/meta/site/riscv64-linux

> @@ -1,3 +1,8 @@

> +# general

> +ac_cv_alignof_guint32=4

> +ac_cv_alignof_guint64=8

> +ac_cv_alignof_unsigned_long=8

> +

>  # glib-2.0

>  glib_cv_stack_grows=${glib_cv_stack_grows=no}

>  glib_cv_uscore=${glib_cv_uscore=no}

> --

> 2.16.2

>

> --

> _______________________________________________

> Openembedded-core mailing list

> Openembedded-core@lists.openembedded.org

> http://lists.openembedded.org/mailman/listinfo/openembedded-core

>
<div dir="ltr">Are the sizeof values actually needed, or are they copy/pasted from another site?  autoconf hasn&#39;t need to run code to do sizeof for a *long* time.<div><br></div><div>Ross</div></div><div class="gmail_extra"><br><div class="gmail_quote">On 20 March 2018 at 04:12, Khem Raj <span dir="ltr">&lt;<a href="mailto:raj.khem@gmail.com" target="_blank">raj.khem@gmail.com</a>&gt;</span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">These variables force runtime tests during configure<br>
they are already cached for other architectures<br>
<br>
Signed-off-by: Khem Raj &lt;<a href="mailto:raj.khem@gmail.com">raj.khem@gmail.com</a>&gt;<br>

---<br>
Changes from v1 -&gt; v2:<br>
- Drop libIDL specific setting since they need to be in meta-gnome<br>
<br>
 meta/site/riscv32-linux | 10 ++++++++++<br>
 meta/site/riscv64-linux |  5 +++++<br>
 2 files changed, 15 insertions(+)<br>
<br>
diff --git a/meta/site/riscv32-linux b/meta/site/riscv32-linux<br>
index 138aeb0a11..fc5b99d147 100644<br>
--- a/meta/site/riscv32-linux<br>
+++ b/meta/site/riscv32-linux<br>
@@ -1,6 +1,16 @@<br>
+# general<br>
+ac_cv_alignof_guint32=4<br>
+ac_cv_alignof_guint64=8<br>
+ac_cv_alignof_unsigned_long=4<br>
+<br>
 # glib-2.0<br>
 glib_cv_stack_grows=${glib_cv_<wbr>stack_grows=no}<br>
 glib_cv_uscore=${glib_cv_<wbr>uscore=no}<br>
+glib_cv_sizeof_gmutex=${glib_<wbr>cv_sizeof_gmutex=24}<br>
+glib_cv_sizeof_intmax_t=${<wbr>glib_cv_sizeof_intmax_t=8}<br>
+glib_cv_sizeof_ptrdiff_t=${<wbr>glib_cv_sizeof_ptrdiff_t=4}<br>
+glib_cv_sizeof_size_t=${glib_<wbr>cv_sizeof_size_t=4}<br>
+glib_cv_sizeof_system_thread=<wbr>${glib_cv_sizeof_system_<wbr>thread=4}<br>
<br>
 # startup-notification<br>
 lf_cv_sane_realloc=${lf_cv_<wbr>sane_realloc=yes}<br>
diff --git a/meta/site/riscv64-linux b/meta/site/riscv64-linux<br>
index 138aeb0a11..38bc5f044d 100644<br>
--- a/meta/site/riscv64-linux<br>
+++ b/meta/site/riscv64-linux<br>
@@ -1,3 +1,8 @@<br>
+# general<br>
+ac_cv_alignof_guint32=4<br>
+ac_cv_alignof_guint64=8<br>
+ac_cv_alignof_unsigned_long=8<br>
+<br>
 # glib-2.0<br>
 glib_cv_stack_grows=${glib_cv_<wbr>stack_grows=no}<br>
 glib_cv_uscore=${glib_cv_<wbr>uscore=no}<br>
<span class="HOEnZb"><font color="#888888">--<br>
2.16.2<br>
<br>
--<br>
______________________________<wbr>_________________<br>
Openembedded-core mailing list<br>
<a href="mailto:Openembedded-core@lists.openembedded.org">Openembedded-core@lists.<wbr>openembedded.org</a><br>
<a href="http://lists.openembedded.org/mailman/listinfo/openembedded-core" rel="noreferrer" target="_blank">http://lists.openembedded.org/<wbr>mailman/listinfo/openembedded-<wbr>core</a><br>
</font></span></blockquote></div><br></div>
-- 
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
Khem Raj March 20, 2018, 4:48 p.m. | #2
On Tue, Mar 20, 2018 at 2:02 AM, Burton, Ross <ross.burton@intel.com> wrote:
> Are the sizeof values actually needed, or are they copy/pasted from another

> site?  autoconf hasn't need to run code to do sizeof for a *long* time.

>


actually let me delete it and we will readd them when we bring up rv32

> Ross

>

> On 20 March 2018 at 04:12, Khem Raj <raj.khem@gmail.com> wrote:

>>

>> These variables force runtime tests during configure

>> they are already cached for other architectures

>>

>> Signed-off-by: Khem Raj <raj.khem@gmail.com>

>> ---

>> Changes from v1 -> v2:

>> - Drop libIDL specific setting since they need to be in meta-gnome

>>

>>  meta/site/riscv32-linux | 10 ++++++++++

>>  meta/site/riscv64-linux |  5 +++++

>>  2 files changed, 15 insertions(+)

>>

>> diff --git a/meta/site/riscv32-linux b/meta/site/riscv32-linux

>> index 138aeb0a11..fc5b99d147 100644

>> --- a/meta/site/riscv32-linux

>> +++ b/meta/site/riscv32-linux

>> @@ -1,6 +1,16 @@

>> +# general

>> +ac_cv_alignof_guint32=4

>> +ac_cv_alignof_guint64=8

>> +ac_cv_alignof_unsigned_long=4

>> +

>>  # glib-2.0

>>  glib_cv_stack_grows=${glib_cv_stack_grows=no}

>>  glib_cv_uscore=${glib_cv_uscore=no}

>> +glib_cv_sizeof_gmutex=${glib_cv_sizeof_gmutex=24}

>> +glib_cv_sizeof_intmax_t=${glib_cv_sizeof_intmax_t=8}

>> +glib_cv_sizeof_ptrdiff_t=${glib_cv_sizeof_ptrdiff_t=4}

>> +glib_cv_sizeof_size_t=${glib_cv_sizeof_size_t=4}

>> +glib_cv_sizeof_system_thread=${glib_cv_sizeof_system_thread=4}

>>

>>  # startup-notification

>>  lf_cv_sane_realloc=${lf_cv_sane_realloc=yes}

>> diff --git a/meta/site/riscv64-linux b/meta/site/riscv64-linux

>> index 138aeb0a11..38bc5f044d 100644

>> --- a/meta/site/riscv64-linux

>> +++ b/meta/site/riscv64-linux

>> @@ -1,3 +1,8 @@

>> +# general

>> +ac_cv_alignof_guint32=4

>> +ac_cv_alignof_guint64=8

>> +ac_cv_alignof_unsigned_long=8

>> +

>>  # glib-2.0

>>  glib_cv_stack_grows=${glib_cv_stack_grows=no}

>>  glib_cv_uscore=${glib_cv_uscore=no}

>> --

>> 2.16.2

>>

>> --

>> _______________________________________________

>> Openembedded-core mailing list

>> Openembedded-core@lists.openembedded.org

>> http://lists.openembedded.org/mailman/listinfo/openembedded-core

>

>

-- 
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Patch

diff --git a/meta/site/riscv32-linux b/meta/site/riscv32-linux
index 138aeb0a11..fc5b99d147 100644
--- a/meta/site/riscv32-linux
+++ b/meta/site/riscv32-linux
@@ -1,6 +1,16 @@ 
+# general
+ac_cv_alignof_guint32=4
+ac_cv_alignof_guint64=8
+ac_cv_alignof_unsigned_long=4
+
 # glib-2.0
 glib_cv_stack_grows=${glib_cv_stack_grows=no}
 glib_cv_uscore=${glib_cv_uscore=no}
+glib_cv_sizeof_gmutex=${glib_cv_sizeof_gmutex=24}
+glib_cv_sizeof_intmax_t=${glib_cv_sizeof_intmax_t=8}
+glib_cv_sizeof_ptrdiff_t=${glib_cv_sizeof_ptrdiff_t=4}
+glib_cv_sizeof_size_t=${glib_cv_sizeof_size_t=4}
+glib_cv_sizeof_system_thread=${glib_cv_sizeof_system_thread=4}
 
 # startup-notification
 lf_cv_sane_realloc=${lf_cv_sane_realloc=yes}
diff --git a/meta/site/riscv64-linux b/meta/site/riscv64-linux
index 138aeb0a11..38bc5f044d 100644
--- a/meta/site/riscv64-linux
+++ b/meta/site/riscv64-linux
@@ -1,3 +1,8 @@ 
+# general
+ac_cv_alignof_guint32=4
+ac_cv_alignof_guint64=8
+ac_cv_alignof_unsigned_long=8
+
 # glib-2.0
 glib_cv_stack_grows=${glib_cv_stack_grows=no}
 glib_cv_uscore=${glib_cv_uscore=no}