[oe,meta-qt5,1/2] qtwebkit: Fix build on armv7ve (rpi)

Message ID 20180325230452.40908-1-raj.khem@gmail.com
State New
Headers show
Series
  • [oe,meta-qt5,1/2] qtwebkit: Fix build on armv7ve (rpi)
Related show

Commit Message

Khem Raj March 25, 2018, 11:04 p.m.
Signed-off-by: Khem Raj <raj.khem@gmail.com>

---
 recipes-qt/qt5/qtwebkit_git.bb | 13 +++++++++++++
 1 file changed, 13 insertions(+)

-- 
2.16.2

-- 
_______________________________________________
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Comments

Andreas Müller March 26, 2018, 6:50 a.m. | #1
On Mon, Mar 26, 2018 at 1:04 AM, Khem Raj <raj.khem@gmail.com> wrote:
> Signed-off-by: Khem Raj <raj.khem@gmail.com>

> ---

>  recipes-qt/qt5/qtwebkit_git.bb | 13 +++++++++++++

>  1 file changed, 13 insertions(+)

>

> diff --git a/recipes-qt/qt5/qtwebkit_git.bb b/recipes-qt/qt5/qtwebkit_git.bb

> index b23d4d6..0f5cbbc 100644

> --- a/recipes-qt/qt5/qtwebkit_git.bb

> +++ b/recipes-qt/qt5/qtwebkit_git.bb

> @@ -18,6 +18,19 @@ DEPENDS += "qtbase qtdeclarative icu ruby-native sqlite3 glib-2.0 libxslt gperf-

>  ARM_INSTRUCTION_SET_armv4 = "arm"

>  ARM_INSTRUCTION_SET_armv5 = "arm"

>

> +# https://bugzilla.yoctoproject.org/show_bug.cgi?id=9474

> +# https://bugs.webkit.org/show_bug.cgi?id=159880

> +# JSC JIT can build on ARMv7 with -marm, but doesn't work on runtime.

> +# Upstream only tests regularly the JSC JIT on ARMv7 with Thumb2 (-mthumb).

> +ARM_INSTRUCTION_SET_armv7a = "thumb"

> +ARM_INSTRUCTION_SET_armv7r = "thumb"

> +ARM_INSTRUCTION_SET_armv7ve = "thumb"

> +

> +# qemu: uncaught target signal 11 (Segmentation fault) - core dumped

> +# Segmentation fault

> +GI_DATA_ENABLED_armv7a = "False"

> +GI_DATA_ENABLED_armv7ve = "False"

> +

>  # Patches from https://github.com/meta-qt5/qtwebkit/commits/b5.10

>  # 5.10.meta-qt5.1

>  SRC_URI += "\

> --

> 2.16.2

>

Hmm strange - my builds for Rpi are fine. Are you sure that this is
not caused by musl in particular gi part?

Andreas
-- 
_______________________________________________
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Khem Raj March 26, 2018, 2:08 p.m. | #2
On Sun, Mar 25, 2018 at 11:50 PM Andreas Müller <schnitzeltony@gmail.com>
wrote:

> On Mon, Mar 26, 2018 at 1:04 AM, Khem Raj <raj.khem@gmail.com> wrote:
> > Signed-off-by: Khem Raj <raj.khem@gmail.com>
> > ---
> >  recipes-qt/qt5/qtwebkit_git.bb | 13 +++++++++++++
> >  1 file changed, 13 insertions(+)
> >
> > diff --git a/recipes-qt/qt5/qtwebkit_git.bb b/recipes-qt/qt5/
> qtwebkit_git.bb
> > index b23d4d6..0f5cbbc 100644
> > --- a/recipes-qt/qt5/qtwebkit_git.bb
> > +++ b/recipes-qt/qt5/qtwebkit_git.bb
> > @@ -18,6 +18,19 @@ DEPENDS += "qtbase qtdeclarative icu ruby-native
> sqlite3 glib-2.0 libxslt gperf-
> >  ARM_INSTRUCTION_SET_armv4 = "arm"
> >  ARM_INSTRUCTION_SET_armv5 = "arm"
> >
> > +# https://bugzilla.yoctoproject.org/show_bug.cgi?id=9474
> > +# https://bugs.webkit.org/show_bug.cgi?id=159880
> > +# JSC JIT can build on ARMv7 with -marm, but doesn't work on runtime.
> > +# Upstream only tests regularly the JSC JIT on ARMv7 with Thumb2
> (-mthumb).
> > +ARM_INSTRUCTION_SET_armv7a = "thumb"
> > +ARM_INSTRUCTION_SET_armv7r = "thumb"
> > +ARM_INSTRUCTION_SET_armv7ve = "thumb"
> > +
> > +# qemu: uncaught target signal 11 (Segmentation fault) - core dumped
> > +# Segmentation fault
> > +GI_DATA_ENABLED_armv7a = "False"
> > +GI_DATA_ENABLED_armv7ve = "False"
> > +
> >  # Patches from https://github.com/meta-qt5/qtwebkit/commits/b5.10
> >  # 5.10.meta-qt5.1
> >  SRC_URI += "\
> > --
> > 2.16.2
> >
> Hmm strange - my builds for Rpi are fine. Are you sure that this is
> not caused by musl in particular gi part?


I transplanted it from oe core the thumb instruction set it what I was
needing I have to test a build without it and you might be right about musl
I should check that too

>
>
> Andreas
>
Andreas Müller March 26, 2018, 2:16 p.m. | #3
On Mon, Mar 26, 2018 at 4:08 PM, Khem Raj <raj.khem@gmail.com> wrote:
>
> On Sun, Mar 25, 2018 at 11:50 PM Andreas Müller <schnitzeltony@gmail.com>
> wrote:
>>
>> On Mon, Mar 26, 2018 at 1:04 AM, Khem Raj <raj.khem@gmail.com> wrote:
>> > Signed-off-by: Khem Raj <raj.khem@gmail.com>
>> > ---
>> >  recipes-qt/qt5/qtwebkit_git.bb | 13 +++++++++++++
>> >  1 file changed, 13 insertions(+)
>> >
>> > diff --git a/recipes-qt/qt5/qtwebkit_git.bb
>> > b/recipes-qt/qt5/qtwebkit_git.bb
>> > index b23d4d6..0f5cbbc 100644
>> > --- a/recipes-qt/qt5/qtwebkit_git.bb
>> > +++ b/recipes-qt/qt5/qtwebkit_git.bb
>> > @@ -18,6 +18,19 @@ DEPENDS += "qtbase qtdeclarative icu ruby-native
>> > sqlite3 glib-2.0 libxslt gperf-
>> >  ARM_INSTRUCTION_SET_armv4 = "arm"
>> >  ARM_INSTRUCTION_SET_armv5 = "arm"
>> >
>> > +# https://bugzilla.yoctoproject.org/show_bug.cgi?id=9474
>> > +# https://bugs.webkit.org/show_bug.cgi?id=159880
>> > +# JSC JIT can build on ARMv7 with -marm, but doesn't work on runtime.
>> > +# Upstream only tests regularly the JSC JIT on ARMv7 with Thumb2
>> > (-mthumb).
>> > +ARM_INSTRUCTION_SET_armv7a = "thumb"
>> > +ARM_INSTRUCTION_SET_armv7r = "thumb"
>> > +ARM_INSTRUCTION_SET_armv7ve = "thumb"
>> > +
>> > +# qemu: uncaught target signal 11 (Segmentation fault) - core dumped
>> > +# Segmentation fault
>> > +GI_DATA_ENABLED_armv7a = "False"
>> > +GI_DATA_ENABLED_armv7ve = "False"
>> > +
>> >  # Patches from https://github.com/meta-qt5/qtwebkit/commits/b5.10
>> >  # 5.10.meta-qt5.1
>> >  SRC_URI += "\
>> > --
>> > 2.16.2
>> >
>> Hmm strange - my builds for Rpi are fine. Are you sure that this is
>> not caused by musl in particular gi part?
>
>
> I transplanted it from oe core the thumb instruction set it what I was
> needing I have to test a build without it and you might be right about musl
> I should check that too
>>
I have checked this further for the GI_DATA_ENABLED part:
qemu/gobject-introspection at qtwebkit?? I found it at webkitgtk.
Seems your copying was a bit over enthuisastic :)

Andreas

Patch

diff --git a/recipes-qt/qt5/qtwebkit_git.bb b/recipes-qt/qt5/qtwebkit_git.bb
index b23d4d6..0f5cbbc 100644
--- a/recipes-qt/qt5/qtwebkit_git.bb
+++ b/recipes-qt/qt5/qtwebkit_git.bb
@@ -18,6 +18,19 @@  DEPENDS += "qtbase qtdeclarative icu ruby-native sqlite3 glib-2.0 libxslt gperf-
 ARM_INSTRUCTION_SET_armv4 = "arm"
 ARM_INSTRUCTION_SET_armv5 = "arm"
 
+# https://bugzilla.yoctoproject.org/show_bug.cgi?id=9474
+# https://bugs.webkit.org/show_bug.cgi?id=159880
+# JSC JIT can build on ARMv7 with -marm, but doesn't work on runtime.
+# Upstream only tests regularly the JSC JIT on ARMv7 with Thumb2 (-mthumb).
+ARM_INSTRUCTION_SET_armv7a = "thumb"
+ARM_INSTRUCTION_SET_armv7r = "thumb"
+ARM_INSTRUCTION_SET_armv7ve = "thumb"
+
+# qemu: uncaught target signal 11 (Segmentation fault) - core dumped
+# Segmentation fault
+GI_DATA_ENABLED_armv7a = "False"
+GI_DATA_ENABLED_armv7ve = "False"
+
 # Patches from https://github.com/meta-qt5/qtwebkit/commits/b5.10
 # 5.10.meta-qt5.1
 SRC_URI += "\