From patchwork Tue Mar 27 05:29:30 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 132446 Delivered-To: patch@linaro.org Received: by 10.46.84.29 with SMTP id i29csp4654751ljb; Mon, 26 Mar 2018 22:34:09 -0700 (PDT) X-Google-Smtp-Source: AG47ELt3yY8flxfB7ekY5/SfLkSb/NgwN7ChoPfnvDm19jcEWQWlfgsA6NuK97qe/62GU9+JDm0l X-Received: by 10.99.119.195 with SMTP id s186mr30991360pgc.453.1522128849372; Mon, 26 Mar 2018 22:34:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1522128849; cv=none; d=google.com; s=arc-20160816; b=Bo1BGEHJk8m0XicMYPXbpvVCX32VkU0D5vks1Mrf9JYFcM5AuJ8rzwVyRZLubNIP76 STqYlJMNH3hLFnLlCrq/RTklBiqgciUni1x4Wjv6bb6+GPAic16TZElk3FSotplagZLT fs7XM5WiVAnAWfI9GtgZ0h4Vp+3iePxZuXH6GFmVQs+pw2+urcrVfSljRlYxcANI2rdh mxoH32GknQdFzr1gfwdmUf3N4Gnyyz0kvdkaessEBvvTASeu5P1miClAd4CGpKMfxH3s KpZoBsW6qjMXi5QQ8j6/c2CrcuLMuMzFMVYh1DlUWlKgW6fKaygGAR9oh+7+C5imN2sN T4Jg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:dkim-filter :arc-authentication-results; bh=4pG48S2UlrsOT3ejNrzGZWeQQuZhLyLMFh52VdRj5G0=; b=fFGvIKBBH3gxYPa9+ifJ6G4mCvGQD5JGZclRdM6KzXVEmWmv5gLkL3mX/3ol6Qwj8h h1av5vVluCSc13LMGEXY5wza4SQSax8cn2tHkmdNLxvNAXDm+n/gQ7yosmH3XAfTmolf zsZ9l0mNAKmBQVavhxTyFRYTTE/GHR+l/ZH1JEdvJUG2grMXtVv646TrDEcpUYUptZKy Auyqnx3Rv7E8Uh0chqIriBIoFFkyLVYhCuIs3h1QRVBqegNSodY6tDcmXF7eOz1GNFDI qEfwdChxkhLCvOjN3wAQX992hoeKoYgmjfu66DqmakaRcj4u1FOufPn4dqgFQMMys5xS gehA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=rcvuR9M/; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o1-v6si533308pld.130.2018.03.26.22.34.09; Mon, 26 Mar 2018 22:34:09 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=rcvuR9M/; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752538AbeC0FeF (ORCPT + 28 others); Tue, 27 Mar 2018 01:34:05 -0400 Received: from conuserg-09.nifty.com ([210.131.2.76]:44829 "EHLO conuserg-09.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752090AbeC0FcF (ORCPT ); Tue, 27 Mar 2018 01:32:05 -0400 Received: from pug.e01.socionext.com (p14092-ipngnfx01kyoto.kyoto.ocn.ne.jp [153.142.97.92]) (authenticated) by conuserg-09.nifty.com with ESMTP id w2R5TaM1011947; Tue, 27 Mar 2018 14:29:57 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-09.nifty.com w2R5TaM1011947 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1522128598; bh=4pG48S2UlrsOT3ejNrzGZWeQQuZhLyLMFh52VdRj5G0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=rcvuR9M/2isRNn+pgd2S8Nyq/HA0MTEO/S6q2kZIUEikiHac3q8rQtDha37zT/Knt b/3WRzHX9y2cRAcMrAdrbF10i4tACg14IS9ZqaEj1sEK1+VyyQEjY/yocF0pS3Z0Hu ENWxHx0yapLgyBPJ1Bvx19q6ppg6q8BXPYokWmvp36UeRwxQJS8eEmdIfou33J780J nrWjHiq6rWDQsYGTSdRE8E747OzxW1CnlY10U9j9rGQCdvM6BN6C2MJsBus3q7oxF6 kQv1BNLIKc1ou52JtFLiQkJ5HRZ3IBYM/jrrfbFbkTHX9rv9NlQcodF2p9XIJ1JNw9 2+mgsjwXmNNUA== X-Nifty-SrcIP: [153.142.97.92] From: Masahiro Yamada To: linux-kbuild@vger.kernel.org Cc: Sam Ravnborg , Linus Torvalds , Arnd Bergmann , Ulf Magnusson , Kees Cook , Thomas Gleixner , Greg Kroah-Hartman , Randy Dunlap , "Luis R . Rodriguez" , Nicolas Pitre , Masahiro Yamada , linux-kernel@vger.kernel.org Subject: [PATCH v2 16/21] kcov: imply GCC_PLUGINS and GCC_PLUGIN_SANCOV instead of select'ing them Date: Tue, 27 Mar 2018 14:29:30 +0900 Message-Id: <1522128575-5326-17-git-send-email-yamada.masahiro@socionext.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1522128575-5326-1-git-send-email-yamada.masahiro@socionext.com> References: <1522128575-5326-1-git-send-email-yamada.masahiro@socionext.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org As Documentation/kbuild/kconfig-language.txt notes, 'select' should be used with care - it forces a lower limit of another symbol, ignoring the dependency. In this case, KCOV can select GCC_PLUGINS even if 'depends on HAVE_GCC_PLUGINS' is unmet. 'imply' is modest enough to observe the dependency, and this makes sense. If you enable KCOV, you will probably want to enable GCC_PLUGIN_SANCOV, but it should not break the dependency. I also remove unneeded code, I just happened to notice. Signed-off-by: Masahiro Yamada - Drop depends on GCC_VERSION --- Changes in v2: None lib/Kconfig.debug | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) -- 2.7.4 Reviewed-by: Kees Cook diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug index 5be22e4..8243c9d 100644 --- a/lib/Kconfig.debug +++ b/lib/Kconfig.debug @@ -743,8 +743,8 @@ config KCOV bool "Code coverage for fuzzing" depends on ARCH_HAS_KCOV select DEBUG_FS - select GCC_PLUGINS if !COMPILE_TEST - select GCC_PLUGIN_SANCOV if !COMPILE_TEST + imply GCC_PLUGINS + imply GCC_PLUGIN_SANCOV help KCOV exposes kernel code coverage information in a form suitable for coverage-guided fuzzing (randomized testing). @@ -758,7 +758,6 @@ config KCOV config KCOV_ENABLE_COMPARISONS bool "Enable comparison operands collection by KCOV" depends on KCOV - default n help KCOV also exposes operands of every comparison in the instrumented code along with operand sizes and PCs of the comparison instructions. @@ -768,7 +767,7 @@ config KCOV_ENABLE_COMPARISONS config KCOV_INSTRUMENT_ALL bool "Instrument all code by default" depends on KCOV - default y if KCOV + default y help If you are doing generic system call fuzzing (like e.g. syzkaller), then you will want to instrument the whole kernel and you should