From patchwork Thu Mar 29 06:07:56 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 132552 Delivered-To: patch@linaro.org Received: by 10.46.84.29 with SMTP id i29csp1345467ljb; Wed, 28 Mar 2018 23:09:06 -0700 (PDT) X-Google-Smtp-Source: AIpwx48PZJt7QORgCPayjQcV5vLQ32qPMY2pxedvznMW07mcWMkwwMcASC7HsO1F+qri75aFMKiY X-Received: by 10.99.123.86 with SMTP id k22mr4617509pgn.228.1522303746709; Wed, 28 Mar 2018 23:09:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1522303746; cv=none; d=google.com; s=arc-20160816; b=TQVK1ywL1Cszuf0oZpljEumYSchgZsL1uYVauxoC+A9T1SYC9zjGBqmO3c2gQ1IDL5 sOIx30EEV1RUvhXbPhgv+sLHhVprumZR1bId570caGNrltj5UsWsD++8fZjYSe5uEJc0 zPe6f/CxOtm0zZwwN+4qdeII2yY1Jsax2NmJrBkrDGgJGtRIzl01QN8qEqtrLufYGwOf DINtoS7y8mS2LXdIAHsNp6SeD52nQ6j2prkQj0AMklFuAULdzFDNqF0qiEyXzFMIn70t KyKsmHskNSDzhnlCePw/95AJ1OtPzSyRbCC76aVQeQgfKB9EH2cFIRymeiAAXVLiwloV r7lw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature:dkim-filter:arc-authentication-results; bh=0LhE2BfNEdX/8EOgcnmZNGvPxy8SFXvRsbMJznFkGy8=; b=IffDEdIkFHwKRhM8AC9B7dY/WS+8uf9oBgMn1Lht/749b4C/bDeNvDn5A7+bMeYLpO uPZz5+KxRQK+NMTP07uhJTlkHffpNp9ZfkO5b5J0vqx19izYH/X6KwxZQIIXJ8++KHJM fla9sAaBL/A+Svpg0E42VTbWDWCyycoFkTD7CN24qHy9tDPtZZLa+YnY04t9jGFHac0v DQTbkq0nBfn99EPVb6R1wI3453fPL4fRFrWXW2k+yjjjIYIaeBr1XWuHIAleYQOaJ/7i ruRSz+JuFiuBaU7bEvxbwrGUXzHV4mB6jJL/ElDr5znkoP63r7GTzJWdlJh3D85mCFK1 ZMUA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=tnDSBDqd; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u23-v6si5823715plk.516.2018.03.28.23.09.06; Wed, 28 Mar 2018 23:09:06 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=tnDSBDqd; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751008AbeC2GI4 (ORCPT + 28 others); Thu, 29 Mar 2018 02:08:56 -0400 Received: from conuserg-10.nifty.com ([210.131.2.77]:30847 "EHLO conuserg-10.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750707AbeC2GIz (ORCPT ); Thu, 29 Mar 2018 02:08:55 -0400 Received: from pug.e01.socionext.com (p14092-ipngnfx01kyoto.kyoto.ocn.ne.jp [153.142.97.92]) (authenticated) by conuserg-10.nifty.com with ESMTP id w2T6882v017946; Thu, 29 Mar 2018 15:08:08 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-10.nifty.com w2T6882v017946 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1522303689; bh=0LhE2BfNEdX/8EOgcnmZNGvPxy8SFXvRsbMJznFkGy8=; h=From:To:Cc:Subject:Date:From; b=tnDSBDqdsVakeB60EqPau4f3+rPrKbyJ96Vf13Li6WAyClDWnz9l96j74boYoqvjT 2oQwnH8Ek+gtsiQb6kXg4wk2Rt4kn3RrTE17Ca4XjaD6TN7GXlIfe7wcuvYrTbNrRe fwBVc2zH61HfQHSbPEYVTnxJvCeJF/21k0ViBXh+EGxrrSxiB7uxU4cGZ5A4arI9JY Dd7n2QsUFexsVKvciDf4fxMN7BzR6leqgu80m0w5Yy6ZE0/hAvM3+63KdGoJZaRlRH CUxNnlICcVq/vG3Z/lAS6mna31M/tyZYCdBdONjXdQcOCsVSWKXteAvu30/gqU62pS EMXLJUk2Imkbg== X-Nifty-SrcIP: [153.142.97.92] From: Masahiro Yamada To: Felipe Balbi , linux-usb@vger.kernel.org Cc: Philipp Zabel , Vivek Gautam , Masahiro Yamada , Greg Kroah-Hartman , Felipe Balbi , linux-kernel@vger.kernel.org Subject: [PATCH] usb: dwc3: of-simple: use managed and shared reset control Date: Thu, 29 Mar 2018 15:07:56 +0900 Message-Id: <1522303676-7035-1-git-send-email-yamada.masahiro@socionext.com> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This driver handles the reset control in a common manner; deassert resets before use, assert them after use. There is no good reason why it should be exclusive. Also, use devm_ for clean-up. Signed-off-by: Masahiro Yamada --- CCing Philipp Zabel. I see his sob in commit 06c47e6286d5. drivers/usb/dwc3/dwc3-of-simple.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) -- 2.7.4 diff --git a/drivers/usb/dwc3/dwc3-of-simple.c b/drivers/usb/dwc3/dwc3-of-simple.c index e54c362..bd6ab65 100644 --- a/drivers/usb/dwc3/dwc3-of-simple.c +++ b/drivers/usb/dwc3/dwc3-of-simple.c @@ -91,7 +91,7 @@ static int dwc3_of_simple_probe(struct platform_device *pdev) platform_set_drvdata(pdev, simple); simple->dev = dev; - simple->resets = of_reset_control_array_get_optional_exclusive(np); + simple->resets = devm_reset_control_array_get_optional_shared(dev); if (IS_ERR(simple->resets)) { ret = PTR_ERR(simple->resets); dev_err(dev, "failed to get device resets, err=%d\n", ret); @@ -100,7 +100,7 @@ static int dwc3_of_simple_probe(struct platform_device *pdev) ret = reset_control_deassert(simple->resets); if (ret) - goto err_resetc_put; + return ret; ret = dwc3_of_simple_clk_init(simple, of_count_phandle_with_args(np, "clocks", "#clock-cells")); @@ -126,8 +126,6 @@ static int dwc3_of_simple_probe(struct platform_device *pdev) err_resetc_assert: reset_control_assert(simple->resets); -err_resetc_put: - reset_control_put(simple->resets); return ret; } @@ -146,7 +144,6 @@ static int dwc3_of_simple_remove(struct platform_device *pdev) simple->num_clocks = 0; reset_control_assert(simple->resets); - reset_control_put(simple->resets); pm_runtime_put_sync(dev); pm_runtime_disable(dev);