[v2,1/2] cpufreq: ti-cpufreq: Fix an incorrect error return value

Message ID 20180402164958.20057-2-s-anna@ti.com
State New
Headers show
Series
  • [v2,1/2] cpufreq: ti-cpufreq: Fix an incorrect error return value
Related show

Commit Message

Suman Anna April 2, 2018, 4:49 p.m.
Commit 05829d9431df ("cpufreq: ti-cpufreq: kfree opp_data when
failure") has fixed a memory leak in the failure path, however
the patch returned a positive value on get_cpu_device() failure
instead of the previous negative value. Fix this incorrect error
return value properly.

Fixes: 05829d9431df ("cpufreq: ti-cpufreq: kfree opp_data when failure")
Cc: Zumeng Chen <zumeng.chen@gmail.com>
Cc: stable@vger.kernel.org
Signed-off-by: Suman Anna <s-anna@ti.com>

---
 drivers/cpufreq/ti-cpufreq.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.16.2

Comments

Viresh Kumar April 3, 2018, 4:20 a.m. | #1
On 02-04-18, 11:49, Suman Anna wrote:
> Commit 05829d9431df ("cpufreq: ti-cpufreq: kfree opp_data when

> failure") has fixed a memory leak in the failure path, however

> the patch returned a positive value on get_cpu_device() failure

> instead of the previous negative value. Fix this incorrect error

> return value properly.

> 

> Fixes: 05829d9431df ("cpufreq: ti-cpufreq: kfree opp_data when failure")

> Cc: Zumeng Chen <zumeng.chen@gmail.com>

> Cc: stable@vger.kernel.org


You also need to mention which version of the stable kernel this patch
should be applied to, like this:

Cc: 3.15+ <stable@vger.kernel.org> # v3.15+

Rafael would probably fix this while applying, so no need to resend
again for now.

> Signed-off-by: Suman Anna <s-anna@ti.com>

> ---

>  drivers/cpufreq/ti-cpufreq.c | 2 +-

>  1 file changed, 1 insertion(+), 1 deletion(-)

> 

> diff --git a/drivers/cpufreq/ti-cpufreq.c b/drivers/cpufreq/ti-cpufreq.c

> index a099b7bf74cd..46d1ab2dea87 100644

> --- a/drivers/cpufreq/ti-cpufreq.c

> +++ b/drivers/cpufreq/ti-cpufreq.c

> @@ -226,7 +226,7 @@ static int ti_cpufreq_probe(struct platform_device *pdev)

>  	opp_data->cpu_dev = get_cpu_device(0);

>  	if (!opp_data->cpu_dev) {

>  		pr_err("%s: Failed to get device for CPU0\n", __func__);

> -		ret = ENODEV;

> +		ret = -ENODEV;

>  		goto free_opp_data;

>  	}


Acked-by: Viresh Kumar <viresh.kumar@linaro.org>


-- 
viresh
Sasha Levin April 6, 2018, 8:05 p.m. | #2
Hi,

[This is an automated email]

This commit has been processed because it contains a "Fixes:" tag,
fixing commit: 05829d9431df cpufreq: ti-cpufreq: kfree opp_data when failure.

The bot has also determined it's probably a bug fixing patch. (score: 98.5065)

The bot has tested the following trees: v4.16, v4.15.15.

v4.16: Build OK!
v4.15.15: Build OK!

--
Thanks,
Sasha

Patch

diff --git a/drivers/cpufreq/ti-cpufreq.c b/drivers/cpufreq/ti-cpufreq.c
index a099b7bf74cd..46d1ab2dea87 100644
--- a/drivers/cpufreq/ti-cpufreq.c
+++ b/drivers/cpufreq/ti-cpufreq.c
@@ -226,7 +226,7 @@  static int ti_cpufreq_probe(struct platform_device *pdev)
 	opp_data->cpu_dev = get_cpu_device(0);
 	if (!opp_data->cpu_dev) {
 		pr_err("%s: Failed to get device for CPU0\n", __func__);
-		ret = ENODEV;
+		ret = -ENODEV;
 		goto free_opp_data;
 	}