wcn36xx: Add missing fall through comment in smd.c

Message ID 1522929109-23271-1-git-send-email-loic.poulain@linaro.org
State New
Headers show
Series
  • wcn36xx: Add missing fall through comment in smd.c
Related show

Commit Message

Loic Poulain April 5, 2018, 11:51 a.m.
This prevents GCC warning.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Loic Poulain <loic.poulain@linaro.org>

---
 drivers/net/wireless/ath/wcn36xx/smd.c | 1 +
 1 file changed, 1 insertion(+)

-- 
2.7.4

Comments

Bjorn Andersson April 5, 2018, 8:53 p.m. | #1
On Thu 05 Apr 04:51 PDT 2018, Loic Poulain wrote:

> This prevents GCC warning.

> 


Acked-by: Bjorn Andersson <bjorn.andersson@linaro.org>


Regards,
Bjorn

> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

> Signed-off-by: Loic Poulain <loic.poulain@linaro.org>

> ---

>  drivers/net/wireless/ath/wcn36xx/smd.c | 1 +

>  1 file changed, 1 insertion(+)

> 

> diff --git a/drivers/net/wireless/ath/wcn36xx/smd.c b/drivers/net/wireless/ath/wcn36xx/smd.c

> index 7cc2928..7b79e0b 100644

> --- a/drivers/net/wireless/ath/wcn36xx/smd.c

> +++ b/drivers/net/wireless/ath/wcn36xx/smd.c

> @@ -2135,6 +2135,7 @@ static int wcn36xx_smd_hw_scan_ind(struct wcn36xx *wcn, void *buf, size_t len)

>  	switch (rsp->type) {

>  	case WCN36XX_HAL_SCAN_IND_FAILED:

>  		scan_info.aborted = true;

> +		/* fall through */

>  	case WCN36XX_HAL_SCAN_IND_COMPLETED:

>  		mutex_lock(&wcn->scan_lock);

>  		wcn->scan_req = NULL;

> -- 

> 2.7.4

> 

> 

> _______________________________________________

> wcn36xx mailing list

> wcn36xx@lists.infradead.org

> http://lists.infradead.org/mailman/listinfo/wcn36xx
Kalle Valo April 10, 2018, 2:39 p.m. | #2
Loic Poulain <loic.poulain@linaro.org> wrote:

> This prevents GCC warning.

> 

> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

> Signed-off-by: Loic Poulain <loic.poulain@linaro.org>

> Acked-by: Bjorn Andersson <bjorn.andersson@linaro.org>

> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>


Patch applied to ath-next branch of ath.git, thanks.

1391cce7daf6 wcn36xx: Add missing fall through comment in smd.c

-- 
https://patchwork.kernel.org/patch/10324469/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Kalle Valo April 10, 2018, 2:39 p.m. | #3
Loic Poulain <loic.poulain@linaro.org> wrote:

> This prevents GCC warning.

> 

> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

> Signed-off-by: Loic Poulain <loic.poulain@linaro.org>

> Acked-by: Bjorn Andersson <bjorn.andersson@linaro.org>

> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>


Patch applied to ath-next branch of ath.git, thanks.

1391cce7daf6 wcn36xx: Add missing fall through comment in smd.c

-- 
https://patchwork.kernel.org/patch/10324469/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches


_______________________________________________
wcn36xx mailing list
wcn36xx@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/wcn36xx

Patch

diff --git a/drivers/net/wireless/ath/wcn36xx/smd.c b/drivers/net/wireless/ath/wcn36xx/smd.c
index 7cc2928..7b79e0b 100644
--- a/drivers/net/wireless/ath/wcn36xx/smd.c
+++ b/drivers/net/wireless/ath/wcn36xx/smd.c
@@ -2135,6 +2135,7 @@  static int wcn36xx_smd_hw_scan_ind(struct wcn36xx *wcn, void *buf, size_t len)
 	switch (rsp->type) {
 	case WCN36XX_HAL_SCAN_IND_FAILED:
 		scan_info.aborted = true;
+		/* fall through */
 	case WCN36XX_HAL_SCAN_IND_COMPLETED:
 		mutex_lock(&wcn->scan_lock);
 		wcn->scan_req = NULL;