From patchwork Mon Apr 9 00:29:50 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sasha Levin X-Patchwork-Id: 132965 Delivered-To: patch@linaro.org Received: by 10.46.84.29 with SMTP id i29csp666052ljb; Sun, 8 Apr 2018 18:06:45 -0700 (PDT) X-Google-Smtp-Source: AIpwx4+9TanVwkY0D9U4uzYKzG6LhGXQtTn5isNwyXYYWSQloqOCGFIhPw6+reft+w4xoHCz8Rvg X-Received: by 10.99.164.82 with SMTP id c18mr4967602pgp.101.1523236005553; Sun, 08 Apr 2018 18:06:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1523236005; cv=none; d=google.com; s=arc-20160816; b=sUyhQNRyyqMGEaBiAZdIBe9aQ9PsYfGU9UJXBewtJBHqni9dq6jKenigQZgb+5XtdK ibbwtx7sfl8keixrMLitFtY2c0ISJQUq9mV7YBAbd5mNiLdbY+MWZQ0+1hEkT+rA6vKp NPQvp9/7kDGBfH/h2PykVA3/wKQyoaXxIJx8nTN9bKZu8Jl/Ggw2IcfBHw5JCmLMNMiN mpTaDV0LZL+D7EWFfV+1hO1KmBS/vUBtqRmAikQej+Jep1u7cMkPfkeBKq+uWdjHhhh8 E/pSYZ5dwLHpbyCo2W3Ngc2lKJIq27khpNJ7t4edblWQT3Wgt1n4TnIlJCInhq+t57eV kLpA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :spamdiagnosticmetadata:spamdiagnosticoutput:content-language :accept-language:in-reply-to:references:message-id:date:thread-index :thread-topic:subject:cc:to:from:dkim-signature :arc-authentication-results; bh=G50suyWCq4jrPJwrGRblhAqNnwoaTEAf5gIOmutCFlA=; b=KMYRdAIcVCRnIJa31u+g/PScR7KHRPiND3PI7jf8johyAXRTR10yAuvmQLEVTJkiCl uhi6dO6sXdYrR3eR7hSLJf9oadJbLUnW5886BKgt8TNmFAqy7aHt1MGIpkE4kMyajHMc FV3vX+32KQMj0Sh6e9GaAD36IRJQD7efu03wwI8+YD9GDfFQkdUZAioV2CX0XOE71wRl ky2pOE3ygo36Lx3K/pDPbmg7yf1v2Aly1whmvoZn6MwwmJow2p27DdDFj9SX5bkRvIGe 28CZ5HBzRtVLXrOwAnBPBumYVUck0ZzIbgzRY9i/6jNxXsYrDtPdqxnZsi6lKclBDPlm cBNg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@microsoft.com header.s=selector1 header.b=mcIg8nOg; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=microsoft.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z18si9620139pgc.207.2018.04.08.18.06.45; Sun, 08 Apr 2018 18:06:45 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@microsoft.com header.s=selector1 header.b=mcIg8nOg; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=microsoft.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756730AbeDIBGm (ORCPT + 11 others); Sun, 8 Apr 2018 21:06:42 -0400 Received: from mail-co1nam03on0104.outbound.protection.outlook.com ([104.47.40.104]:37663 "EHLO NAM03-CO1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932263AbeDIAjW (ORCPT ); Sun, 8 Apr 2018 20:39:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=G50suyWCq4jrPJwrGRblhAqNnwoaTEAf5gIOmutCFlA=; b=mcIg8nOgyvDhFq17acoYQTagUbhQtS2/B/7Yshw2piG35S243d4Yzo2/yRQV1E412zJjXRdpUpV+Ixztto+emZDqdBFmWntPQ8qWQE0m81XMmPcDbYnYpqvdZ6F49KRK22nG39fn/asv5OPWhn7aXCBw89jhZPqHPiHAGMWHTj0= Received: from DM5PR2101MB1032.namprd21.prod.outlook.com (52.132.128.13) by DM5PR2101MB1125.namprd21.prod.outlook.com (52.132.130.150) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.696.0; Mon, 9 Apr 2018 00:39:19 +0000 Received: from DM5PR2101MB1032.namprd21.prod.outlook.com ([fe80::8109:aef0:a777:7059]) by DM5PR2101MB1032.namprd21.prod.outlook.com ([fe80::8109:aef0:a777:7059%2]) with mapi id 15.20.0696.003; Mon, 9 Apr 2018 00:39:19 +0000 From: Sasha Levin To: "stable@vger.kernel.org" , "linux-kernel@vger.kernel.org" CC: Arnd Bergmann , Steve French , Sasha Levin Subject: [PATCH AUTOSEL for 4.4 154/162] cifs: silence compiler warnings showing up with gcc-8.0.0 Thread-Topic: [PATCH AUTOSEL for 4.4 154/162] cifs: silence compiler warnings showing up with gcc-8.0.0 Thread-Index: AQHTz5nf1BbOJSfLDkaVAZGgk0RNFQ== Date: Mon, 9 Apr 2018 00:29:50 +0000 Message-ID: <20180409002738.163941-154-alexander.levin@microsoft.com> References: <20180409002738.163941-1-alexander.levin@microsoft.com> In-Reply-To: <20180409002738.163941-1-alexander.levin@microsoft.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [52.168.54.252] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DM5PR2101MB1125; 7:hhAw2Un+YuRgkfYz8yBvrRhygxR5qsIIDUVKKmjerLJAk7RspWM/pKIUOgSwPmRcYN6QtsJtgvLVgz0ajftvAQB/nmuI42jcVBaN4b6Z5OxQEyrxyM8Ehf5bt+CxQyv6H/JLRuAVEGji72M57sRy311L47LSJULAQD9vi/OdB8H34x7gsosZoqGJD5L7iDU3pQpeg5ZXxzJ7qmnBAeW1XPUMmptgt2gY30dYaaO4ypP+8ZLMfMZ44I39n7KcJJII; 20:IVduZpkp7PU+4zpt9uR5OrfljT6zdUTLh8hUTD++J+b4md2UhWrbiIoi+tIJ8RHXTB4u7uZQsmcnX8h3qAvNJ2a2bmMipVeOrrAk5NQuVgKi+kgoBhwR7a1envTkD0mKnG5Xt7RTAp+WbYg+/gHtZs/qXapoESqD2c4Pa4kjaPw= X-MS-Office365-Filtering-Correlation-Id: b8b37dbe-8fd5-4433-b68f-08d59db254d7 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(5600026)(4604075)(3008032)(48565401081)(2017052603328)(7193020); SRVR:DM5PR2101MB1125; x-ms-traffictypediagnostic: DM5PR2101MB1125: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alexander.Levin@microsoft.com; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(28532068793085)(89211679590171)(85827821059158); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(61425038)(6040522)(2401047)(8121501046)(5005006)(3231221)(944501327)(52105095)(3002001)(93006095)(93001095)(10201501046)(6055026)(61426038)(61427038)(6041310)(20161123560045)(20161123564045)(20161123558120)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011); SRVR:DM5PR2101MB1125; BCL:0; PCL:0; RULEID:; SRVR:DM5PR2101MB1125; x-forefront-prvs: 0637FCE711 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(346002)(39860400002)(39380400002)(366004)(376002)(396003)(189003)(199004)(2906002)(25786009)(6512007)(10090500001)(3280700002)(10290500003)(6666003)(3660700001)(316002)(110136005)(54906003)(11346002)(107886003)(39060400002)(2616005)(476003)(446003)(36756003)(99286004)(86612001)(53936002)(4326008)(486006)(6436002)(3846002)(81156014)(305945005)(5250100002)(1076002)(102836004)(14454004)(66066001)(7736002)(105586002)(81166006)(106356001)(8676002)(97736004)(6116002)(6506007)(6486002)(5660300001)(186003)(76176011)(22452003)(72206003)(478600001)(2501003)(2900100001)(26005)(86362001)(8936002)(68736007)(22906009)(217873001); DIR:OUT; SFP:1102; SCL:1; SRVR:DM5PR2101MB1125; H:DM5PR2101MB1032.namprd21.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: microsoft.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: 4sfC7dAVR8hqJgKU70OVNg+mpwYCmxHL1ndWTiOV9RtC/emygY6gyuoEZj5SDDKndhoPRftoUTcnQKWsNmxfupe9G9z9bwBI1zA/p6gamK/ikoVYdUXfKzguGLg2/945ltiQvL4tKbFHFFFaqqW+JzjXa+pPtuStdXfef/kuN9MTYVaW5l4KmkIZ+KZGTMbqpM0xjpVjrHTQhx/xKnmCdHiPnFIlBXD4Tyqux/EWJ9RZVx+HdCDk0rG0yeeUvaXF63JC1PJ0h4mShfyXKmvxvltiq8CSGfwAo+WEQknfJjvyzxHJhAX9YOgMWcZMEnSa8a953L2p2HxZb5tXNtxLz8ru5lj9SdXBYC5z5cAF0APfS4uozXSV0QhgarZiUrrfBjF0s6/GTqmVyxbkevgBZAs98b/zvipnhTqp405tVVU= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: b8b37dbe-8fd5-4433-b68f-08d59db254d7 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Apr 2018 00:29:50.3027 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR2101MB1125 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Arnd Bergmann [ Upstream commit ade7db991b47ab3016a414468164f4966bd08202 ] This bug was fixed before, but came up again with the latest compiler in another function: fs/cifs/cifssmb.c: In function 'CIFSSMBSetEA': fs/cifs/cifssmb.c:6362:3: error: 'strncpy' offset 8 is out of the bounds [0, 4] [-Werror=array-bounds] strncpy(parm_data->list[0].name, ea_name, name_len); Let's apply the same fix that was used for the other instances. Fixes: b2a3ad9ca502 ("cifs: silence compiler warnings showing up with gcc-4.7.0") Signed-off-by: Arnd Bergmann Signed-off-by: Steve French Signed-off-by: Sasha Levin --- fs/cifs/cifssmb.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) -- 2.15.1 diff --git a/fs/cifs/cifssmb.c b/fs/cifs/cifssmb.c index 0c92af11f4f4..8632380d2b94 100644 --- a/fs/cifs/cifssmb.c +++ b/fs/cifs/cifssmb.c @@ -6421,9 +6421,7 @@ SetEARetry: pSMB->InformationLevel = cpu_to_le16(SMB_SET_FILE_EA); - parm_data = - (struct fealist *) (((char *) &pSMB->hdr.Protocol) + - offset); + parm_data = (void *)pSMB + offsetof(struct smb_hdr, Protocol) + offset; pSMB->ParameterOffset = cpu_to_le16(param_offset); pSMB->DataOffset = cpu_to_le16(offset); pSMB->SetupCount = 1;