diff mbox series

[V2,01/11] PM / OPP: dt-bindings: Rename "required-opp" as "required-opps"

Message ID 85cec966b995393b403d7273ec3abf6f0b0a60d5.1523273291.git.viresh.kumar@linaro.org
State Accepted
Commit f05fededbb486cb1fa468ca024c05bb219284001
Headers show
Series PM / genpd & OPP: Parse performance state from DT | expand

Commit Message

Viresh Kumar April 9, 2018, 11:43 a.m. UTC
This property can contain more than one phandle and it must be named
"required-opps" instead.

Cc: Rob Herring <robh@kernel.org>
Suggested-by: Stephen Boyd <sboyd@kernel.org>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>

---
 Documentation/devicetree/bindings/opp/opp.txt            | 2 +-
 Documentation/devicetree/bindings/power/power_domain.txt | 6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)

-- 
2.15.0.194.g9af6a3dea062

Comments

Ulf Hansson April 9, 2018, 3:22 p.m. UTC | #1
On 9 April 2018 at 13:43, Viresh Kumar <viresh.kumar@linaro.org> wrote:
> This property can contain more than one phandle and it must be named

> "required-opps" instead.

>

> Cc: Rob Herring <robh@kernel.org>

> Suggested-by: Stephen Boyd <sboyd@kernel.org>

> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>


Reviewed-by: Ulf Hansson <ulf.hansson@linaro.org>


Kind regards
Uffe

> ---

>  Documentation/devicetree/bindings/opp/opp.txt            | 2 +-

>  Documentation/devicetree/bindings/power/power_domain.txt | 6 +++---

>  2 files changed, 4 insertions(+), 4 deletions(-)

>

> diff --git a/Documentation/devicetree/bindings/opp/opp.txt b/Documentation/devicetree/bindings/opp/opp.txt

> index 4e4f30288c8b..788052d66c9d 100644

> --- a/Documentation/devicetree/bindings/opp/opp.txt

> +++ b/Documentation/devicetree/bindings/opp/opp.txt

> @@ -159,7 +159,7 @@ properties.

>

>  - status: Marks the node enabled/disabled.

>

> -- required-opp: This contains phandle to an OPP node in another device's OPP

> +- required-opps: This contains phandle to an OPP node in another device's OPP

>    table. It may contain an array of phandles, where each phandle points to an

>    OPP of a different device. It should not contain multiple phandles to the OPP

>    nodes in the same OPP table. This specifies the minimum required OPP of the

> diff --git a/Documentation/devicetree/bindings/power/power_domain.txt b/Documentation/devicetree/bindings/power/power_domain.txt

> index f3355313c020..4733f76cbe48 100644

> --- a/Documentation/devicetree/bindings/power/power_domain.txt

> +++ b/Documentation/devicetree/bindings/power/power_domain.txt

> @@ -127,7 +127,7 @@ inside a PM domain with index 0 of a power controller represented by a node

>  with the label "power".

>

>  Optional properties:

> -- required-opp: This contains phandle to an OPP node in another device's OPP

> +- required-opps: This contains phandle to an OPP node in another device's OPP

>    table. It may contain an array of phandles, where each phandle points to an

>    OPP of a different device. It should not contain multiple phandles to the OPP

>    nodes in the same OPP table. This specifies the minimum required OPP of the

> @@ -175,14 +175,14 @@ with the label "power".

>                 compatible = "foo,i-leak-current";

>                 reg = <0x12350000 0x1000>;

>                 power-domains = <&power 0>;

> -               required-opp = <&domain0_opp_0>;

> +               required-opps = <&domain0_opp_0>;

>         };

>

>         leaky-device1@12350000 {

>                 compatible = "foo,i-leak-current";

>                 reg = <0x12350000 0x1000>;

>                 power-domains = <&power 1>;

> -               required-opp = <&domain1_opp_1>;

> +               required-opps = <&domain1_opp_1>;

>         };

>

>  [1]. Documentation/devicetree/bindings/power/domain-idle-state.txt

> --

> 2.15.0.194.g9af6a3dea062

>
Rob Herring April 27, 2018, 6:50 p.m. UTC | #2
On Mon, Apr 9, 2018 at 6:43 AM, Viresh Kumar <viresh.kumar@linaro.org> wrote:
> This property can contain more than one phandle and it must be named

> "required-opps" instead.

>

> Cc: Rob Herring <robh@kernel.org>

> Suggested-by: Stephen Boyd <sboyd@kernel.org>

> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>

> ---

>  Documentation/devicetree/bindings/opp/opp.txt            | 2 +-

>  Documentation/devicetree/bindings/power/power_domain.txt | 6 +++---

>  2 files changed, 4 insertions(+), 4 deletions(-)


Reviewed-by: Rob Herring <robh@kernel.org>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/opp/opp.txt b/Documentation/devicetree/bindings/opp/opp.txt
index 4e4f30288c8b..788052d66c9d 100644
--- a/Documentation/devicetree/bindings/opp/opp.txt
+++ b/Documentation/devicetree/bindings/opp/opp.txt
@@ -159,7 +159,7 @@  properties.
 
 - status: Marks the node enabled/disabled.
 
-- required-opp: This contains phandle to an OPP node in another device's OPP
+- required-opps: This contains phandle to an OPP node in another device's OPP
   table. It may contain an array of phandles, where each phandle points to an
   OPP of a different device. It should not contain multiple phandles to the OPP
   nodes in the same OPP table. This specifies the minimum required OPP of the
diff --git a/Documentation/devicetree/bindings/power/power_domain.txt b/Documentation/devicetree/bindings/power/power_domain.txt
index f3355313c020..4733f76cbe48 100644
--- a/Documentation/devicetree/bindings/power/power_domain.txt
+++ b/Documentation/devicetree/bindings/power/power_domain.txt
@@ -127,7 +127,7 @@  inside a PM domain with index 0 of a power controller represented by a node
 with the label "power".
 
 Optional properties:
-- required-opp: This contains phandle to an OPP node in another device's OPP
+- required-opps: This contains phandle to an OPP node in another device's OPP
   table. It may contain an array of phandles, where each phandle points to an
   OPP of a different device. It should not contain multiple phandles to the OPP
   nodes in the same OPP table. This specifies the minimum required OPP of the
@@ -175,14 +175,14 @@  with the label "power".
 		compatible = "foo,i-leak-current";
 		reg = <0x12350000 0x1000>;
 		power-domains = <&power 0>;
-		required-opp = <&domain0_opp_0>;
+		required-opps = <&domain0_opp_0>;
 	};
 
 	leaky-device1@12350000 {
 		compatible = "foo,i-leak-current";
 		reg = <0x12350000 0x1000>;
 		power-domains = <&power 1>;
-		required-opp = <&domain1_opp_1>;
+		required-opps = <&domain1_opp_1>;
 	};
 
 [1]. Documentation/devicetree/bindings/power/domain-idle-state.txt